From: Alexey Dobriyan <adobriyan@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: akpm@linux-foundation.org, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] extract and use FILE_LINE macro
Date: Tue, 3 Oct 2023 19:20:53 +0300 [thread overview]
Message-ID: <73bedf42-decf-450a-8e54-a318950ddc67@p183> (raw)
In-Reply-To: <202310021033.A5F0159F25@keescook>
On Mon, Oct 02, 2023 at 10:33:49AM -0700, Kees Cook wrote:
> > +#define FILE_LINE __FILE__ ":" __stringify(__LINE__)
> > +
> > #endif /* !__LINUX_STRINGIFY_H */
> > --- a/sound/pci/asihpi/hpidebug.h
> > +++ b/sound/pci/asihpi/hpidebug.h
> > @@ -29,16 +29,15 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0, /* always log errors */
> > the start of each message, eg see linux kernel hpios.h */
> >
> > #ifdef SOURCEFILE_NAME
> > +#undef FILE_LINE
> > #define FILE_LINE SOURCEFILE_NAME ":" __stringify(__LINE__) " "
>
> Should this drop the trailing " " to match the new macro?
Yes, probably. This SOURCEFILE_NAME is some out of tree stuff.
prev parent reply other threads:[~2023-10-03 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 18:21 [PATCH] extract and use FILE_LINE macro Alexey Dobriyan
2023-10-02 17:33 ` Kees Cook
2023-10-03 16:20 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73bedf42-decf-450a-8e54-a318950ddc67@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.