From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
linux-sound@vger.kernel.org, broonie@kernel.org, tiwai@suse.de,
vkoul@kernel.org
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
peter.ujfalusi@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH] ASoC/soundwire: Intel: reset the PCMSyCM registers in hda_sdw_bpt_close
Date: Thu, 30 Jul 2026 11:12:49 +0200 [thread overview]
Message-ID: <73c4ffc5-e048-4561-904d-2919327398ef@linux.dev> (raw)
In-Reply-To: <20260730012518.2180906-1-yung-chuan.liao@linux.intel.com>
On 7/30/26 03:25, Bard Liao wrote:
> Resetting the PCMSyCM registers is required for Intel SoundWire stream. The
> same procedure is done in sdw_hda_dai_hw_params() for the normal
it's actually in sdw_hda_dai_hw_free() for the regular cases, the
sequence is also used in hw_params() but for corner cases such as
xruns/drops, see comment:
/*
* reset the PCMSyCM registers to handle a prepare callback when the
PCM is restarted
* due to xruns or after a call to snd_pcm_drain/drop()
*/
No need to respin the patch for this nit-pick.
> SoundWire stream, too.
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
LGTM, this patch makes the _close() sequence and api mimic the _open() one.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
prev parent reply other threads:[~2026-07-30 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 1:25 [PATCH] ASoC/soundwire: Intel: reset the PCMSyCM registers in hda_sdw_bpt_close Bard Liao
2026-07-30 9:12 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c4ffc5-e048-4561-904d-2919327398ef@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.