From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41A0C433EF for ; Sun, 21 Nov 2021 23:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=C3HdZhovl5g/VxTEtgRXIhg2BL/t6hiravprUMY7NKs=; b=AP0Y9E17YMfY5NAvjxuVtS3I6/ sQX5i/TBC0ZgWae1y+u15aJzI6U8VzZc7lsfTZmtJOxdeCXlSEQhK9pHlFBHD63gOigiGX1tt/Ywt Mzo7BTG31YPmd0vJh0tzagH7mL+ncRp9ZjEXy5aPrBj102QZg5DQ/sP9GdWHmtcAnYZfvluve5PcP dlaxtF3oCHlNrlbFNXigFy1gO+B2J0CT5q6YciXK8IjVZ5IuR1xxuVlnmZZ/LavZ2zIR2FjmFy70j RY08NL2iHaaF/FiXMne67gxFgbChLEt6YB4N43OEZK5jfqx6A87b7F8PFtb/XcVTwQLaNDaqL53M7 OV2EKEQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mow6p-00ESSX-AZ; Sun, 21 Nov 2021 23:18:55 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mow6l-00ESRq-F1; Sun, 21 Nov 2021 23:18:53 +0000 Received: by mail-wr1-x434.google.com with SMTP id r8so29205563wra.7; Sun, 21 Nov 2021 15:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=pVVV5o4k9iKc92GByRt/kiMair0asSOHzgLz3IkU02B74n8vt0DfLH4QnRX5ZksoZU 5t4jJ2FJJzUznGabZT1ghwRcvb9hrIEJY4zj6RnbbSg8RCltlBj87/LEQKQ/KStFgR6w zn3uDs8jA+C/TUuF4bIK/wErPxGmG27UOsokhuZDkzQ+N4rZboLXXr1tn+e+mdibc+Wr BDcKRssX7FA8FB4za4sAlplzDg15Yd2YYyyGRDRa3aBVBWICQBOk9cpyA9XWewywXBFU MT3FXw9E5O/geRq+KQ8QnLMWtduXvHZLm9EbF7Vj4WVc1l/lmsY4b1Bmo39PTUCrb8IO HWqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=f8J1sB1j5T6/koybxJCcoOSBObvW76gg9Ri6dhzZRQ5r6ItsQcE9uhKj37iB17+mKE nlOSIJyInA3r8kmQ3xAde73xQ6yVMe3hfU7jvaaemx4AKrBSi3cB5iFs3V1uZ52N48Tn fFzXZTfRtkI2i/v2NNv2dxLnFOGAmdNkqjsGVt7lTXp/VXqpVa0ddTEXXdr+rrYY7oTm lJL2RuQXVyVxD478IEjjkP7h+KmNt3k8s/gNhHFoj8ym5zyYjz90e/dFDB27DKqbFVnL /Chm8f0Ddz1tJLItX0xhEZozJ5NF2OuPN2hZXUH3FLhdmjN5+BPmAkPMb2Zyhiia3lGn xixA== X-Gm-Message-State: AOAM530SD89V2XXsMz/0ap/tPop+mAnTIWDm2WE4u91zL+gTtvzmpGCd iqQhLIK4CLK9qahL4P2Apw== X-Google-Smtp-Source: ABdhPJx2INaINAEgviHhidQlQTMYTw9PV/lb6oU11lO2qAR8cCZPrWN7OL85v/eZ2ePUsk8rxhtYRw== X-Received: by 2002:adf:f60c:: with SMTP id t12mr32376728wrp.341.1637536729122; Sun, 21 Nov 2021 15:18:49 -0800 (PST) Received: from [192.168.200.23] (ip5b435a69.dynamic.kabel-deutschland.de. [91.67.90.105]) by smtp.gmail.com with ESMTPSA id 4sm9293595wrz.90.2021.11.21.15.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 15:18:48 -0800 (PST) Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20211117143347.314294-1-s.hauer@pengutronix.de> From: Alex Bee Message-ID: <73c57643-a0db-e7e7-174d-3cb6a978d98a@gmail.com> Date: Mon, 22 Nov 2021 00:18:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211121_151851_531485_47D8F78D X-CRM114-Status: GOOD ( 32.55 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhLAoKQW0gMTcuMTEuMjEgdW0gMTU6MzMgc2NocmllYiBTYXNjaGEgSGF1ZXI6Cj4g VGhpcyBzZXJpZXMgYWRkcyBpbml0aWFsIGdyYXBoaWNzIHN1cHBvcnQgZm9yIHRoZSBSb2NrY2hp cCBSSzM1Nls2OF0KPiBTb0NzLiAgR3JhcGhpY3Mgc3VwcG9ydCBpcyBiYXNlZCBhcm91bmQgdGhl IFZPUDIgY29udHJvbGxlciB3aGljaAo+IHJlcGxhY2VzIHRoZSBWT1AgY29udHJvbGxlciBmb3Vu ZCBvbiBlYXJsaWVyIFJvY2tjaGlwIFNvQ3MuIFRoZSBkcml2ZXIKPiBoYXMgYmVlbiB0ZXN0ZWQg d2l0aCBIRE1JIHN1cHBvcnQgaW5jbHVkZWQgaW4gdGhpcyBzZXJpZXMgYW5kIE1JUEktRFNJCj4g d2hpY2ggaXMgbm90IGluY2x1ZGVkIGJlY2F1c2UgaXQgbmVlZHMgc29tZSBtb3JlIHdvcmsuIFRo ZSBkcml2ZXIgaXMKPiB0YWtlbiBmcm9tIHRoZSBkb3duc3RyZWFtIFJvY2tjaGlwIGtlcm5lbCBh bmQgaGVhdmlseSBwb2xpc2hlZCwgbW9zdCBub24KPiBzdGFuZGFyZCBmZWF0dXJlcyBoYXZlIGJl ZW4gcmVtb3ZlZCBmb3Igbm93LiBJIHRlc3RlZCB0aGUgZHJpdmVyIHdpdGgKPiB0aGUgbGliZHJt IG1vZGV0ZXN0IHV0aWxpdHkgYW5kIGFsc28gd2l0aCB3ZXN0b24gd2l0aCBib3RoIHBpeG1hbiBh bmQKPiBwYW5mcm9zdCBkcml2ZXIgc3VwcG9ydC4gTWljaGFlbCBSaWVzY2ggcmVwb3J0ZWQgdGhl IGRyaXZlciB0byB3b3JrIG9uCj4gdGhlIFJLMzU2NiBhcyB3ZWxsLCBidXQgZGV2aWNlIHRyZWUg c3VwcG9ydCBmb3IgdGhpcyBTb0MgaXMgbm90IHlldAo+IGluY2x1ZGVkIGluIHRoaXMgc2VyaWVz Lgo+Cj4gVGhlIEhETUkgY2hhbmdlcyBhcmUgYmFzZWQgb24gcGF0Y2hlcyBmcm9tIEJlbmphbWlu IEdhaWduYXJkLCBidXQKPiBtb2RpZmllZCBhIGJpdCBhcyBJIGZvdW5kIG91dCB0aGF0IHRoZSBI RE1JIHBvcnQgb24gdGhlIFJLMzU2OCBvbmx5Cj4gbmVlZHMgb25lIGFkZGl0aW9uYWwgY2xvY2ss IG5vdCB0d28uIEFsc28gSSBhZGRlZCByZWd1bGF0b3Igc3VwcG9ydAo+IHdoaWNoIGlzIG5lZWRl ZCB0byBnZXQgdGhlIEhETUkgdXAgb24gdGhlIHJrMzU2OC1FVkIgYm9hcmQuCj4KPiBBbGwgcmV2 aWV3IGFuZCB0ZXN0aW5nIGZlZWRiYWNrIHdlbGNvbWUKCgp0aGFua3MgZm9yIHdvcmtpbmcgb24g dGhhdCAtIGl0J3MgdmVyeSAodmVyeSx2ZXJ5KSBtdWNoIGFwcHJlY2lhdGVkLgoKSXQgdG9vayBt ZSBzb21lIHRpbWUgdG8gZmlndXJlIGl0IG91dDogSXQgc2VlbXMgcmszNTY4LWlvbW11IGRyaXZl ciBzCmJyb2tlbiAtIEkgZGlkIG9ubHkgZ2V0ICJ3aGl0ZSBub2lzZSIgd2hlbiB1c2luZyBpdCBh bG9uZ3NpZGUgdm9wCihzaW1pbGFyIGxpa2UgaXQgd2FzIHJlcG9ydGVkIGhlcmUgYmVmb3JlKS4g SG93ZXZlcjogcmVtb3ZpbmcgdGhlCmlvbW11LXByb3BlcnR5IGZyb20gdm9wIG1ha2VzIGl0IHdv cmtpbmcgZm9yIG1lIHdpdGggSERNSSBvdXRwdXQgb24KcXVhcnR6NjQgYXMgd2VsbC4gQ291bGQg eW91IGNoZWNrIGlmIHlvdSBoYXZlIHRoZSBpb21tdSBkcml2ZXIgaW4ga2VybmVsCmVuYWJsZWQg aWYgaXQgd29ya3MgZm9yIHlvdSwgaWYgdGhlIHByb3BlcnR5IGlzIHByZXNlbnQgaW4gRFQ/IChJ IHVzZWQKNS4xNi1yYzEgKyB0aGlzIHNlcmllcyArIFswXSkuIEFsc28gdm9wIG1tdSBzZWVtcyB0 byBoYXZlIHRoZQpwb3dlci1kb21haW4gbWlzc2luZyBpbiB5b3VyIHNlcmllcyAoc2FtZSBhcyBk b3duc3RyZWFtKSAtIGhvd2V2ZXIKYWRkaW5nIHRoYXQgZG9lc24ndCBoZWxwIG11Y2ggY3VycmVu dGx5LgpBcyBhIHNpZGVub3RlOiBJIHZlcmZpZWQgdGhpcyB3aXRoIHVzaW5nIEV6ZXF1aWVsJ3Mg dnB1IGFkZHRpb24gZm9yClJLMzU2eDogSXQgZGlkIG9ubHkgd29yayB3aGVuIHJlbW92aW5nIHRo ZSBpb21tdSB0aGVyZSBhcyB3ZWxsIChnZXR0aW5nCnRvbnMgb2YgcGFnZSBmYXVsdHMgb3RoZXJ3 aXNlKSAtIHNvIGlvbW11IGRyaXZlciByZWFsbHkgc2VlbXMgdG8gYnJva2VuLAphdCBsZWFzdCBm b3IgUkszNTY2LiAoT3IgSSdtIGEgbWlzc2luZyBhIG9wdGlvbiBpbiBrZXJuZWwgY29uZmlnLCB3 aGljaAp3YXNuJ3QgcmVxdWlyZWQgZm9yIHRoZSBvbGRlciBpb21tdSB2ZXJzaW9uPykKwqAKQnV0 IGFzIHJlcG9ydGVkIGJlZm9yZTogRm9yIEhETUkgdGhpcyBkb2VzIGN1cnJlbnRseSBvbmx5IHdv cmsgZm9yIHBpeGVsCmNsb2NrIHJhdGVzLCB3aGljaCBhcmUgaW50ZWdlci1kaXZpc2FibGUgd2l0 aCBocGxsIGNsb2NrIHJhdGUgKHdoaWNoIGlzCnRoZSBoYXJkY29kZWQgcGFyZW50IG9mIHZvcDAn cyBkY2xrKQpBcyBkaXNjdXNzZWQgaW4gQmVuamFtaW4ncyBpbml0aWFsIHN1Ym1pc3Npb24gb2Yg dGhlIGFkZGl0aW9uIG9mClJLMzU2OCdzIGhkbWkgY29udHJvbGxlciBbMV0gc2FtZSBhcyB3aXRo IFJLMzI4OCdzIGFuZCBSSzMzOTkncyBoZG1pIHBoeQpuZWVkcyBhIHJlZmVyZW5jZSBjbG9jayAo aXQncyBjYWxsZWQgdnBsbCB0aGVyZSkgd2hpY2ggbmVlZHMgdG8gZ2V0CnN3aXRjaGVkIGJlZm9y ZSB0aGUgdm9wIHN3aXRjaGVzIHRoZSBtb2RlIChzaW5jZSBwaHkgcmF0ZSBzd2l0Y2hpbmcgaXMK ZG9uZSBiZWZvcmUpIC0gaXQncyBIUExMIGluIGNhc2Ugb2YgUkszNTZ4LiBGb3Igd2hhdGV2ZXIg cmVhc29uIGl0J3MKY2FsbGVkICJyZWYiIGZvciBSSzM1Nnggb25seSBkb3duc3RyZWFtIFsyXSAt IHNvIHlvdSBzaG91bGQgYWRkIGFub3RoZXIKY2xvY2sgInZwbGwiIChyZW5hbWluZyBpdCB0byAi cmVmIiBmb3IgX0FMTF8gU29DcyB3aGljaCBoYXZlIGl0IHdvdWxkIGJlCmEgX0dSRUFUXyBpZGVh KSB3aGljaCBpcyA8JnBtdWNydSBQTExfSFBMTD4uCldoYXQgYnJpbmdzIHVzIHRvIHRoZSAicmVh bCIgY2xvY2sgcHJvYmxlbSBhbmQgdGhlIHJlYXNvbiwgd2h5Cm5vbi1pbnRlZ2VyIGRpdmlzYWJs ZSBwaXhlbCBjbG9jayByYXRlcyBhcmUgbm90IHBvc3NpYmxlIEFUTTogVGhpcyBpcyBhCmxvbmcg c3RhbmRpbmcgaXNzdWUgZm9yIFJLMzI4OCBhbmQgUkszMzk5IGFzIHdlbGwgKGFuZCBvbmUgb2Yg dGhlIG1haW4KcmVhc29ucyB3aHkgNGsgbW9kZXMgYXJlIG5vdCBwb3NzaWJsZSBmb3IgdGhvc2Ug b2xkZXIgU29DcyBjdXJyZW50bHkpOgpVcHN0cmVhbSBhbGwgUExMIHJhdGVzIGFyZSBjb250cm9s bGVkIHdpdGggdGhvc2UgUExMIHJhdGUgdGFibGVzIGluIHRoZQpjbG9jayBkcml2ZXIgYW5kIHRo ZXkgaGF2ZSB0byBiZSBfZXhhY3RseV8gZGVmaW5lZCBhcyB0aGV5IGFyZSB1c2VkCihIRE1JIHNp bmtzIGFyZSB2ZXJ5IHBpY2t5KS4KWW91IHdpbGwgbm90IHNlZSBhbnkgYWRkaXRpb25hbCByYXRl cyBkb3duc3RyZWFtIGZvciBSSzM1Njg6IHRoZXkgaGF2ZSBhCm1lY2hhbmlzbSB0aGVyZSB0byBh dXRvbWF0aWNhbGx5IGNhbGN1bGF0ZSB0aGUgUExMIHNldHRpbmdzIGlmIHRoZSByYXRlCmRvZXNu J3QgZXhpc3QgaW4gdGhlc2UgdGFibGVzIChJSVJDIHRoaXMgd2FzIHN1Ym1pdHRlZCB1cHN0cmVh bSBhbHNvOgpidXQgaXQgd2FzIHJlamVjdGVkL2lnbm9yZWQgYnkgbWFpbnRhaW5lcnMpLiBBcyBh IHF1aWNrIGhhY2thcnJvdW5kIChmb3IKdGVzdGluZyk6IFlvdSBjb3VsZCB1c2UgdGhpcyB0YWJs ZSBbM10gd2UgYXJlIHVzaW5nIGluIExpYnJlRWxlYyBmb3IKUkszMzk5IHRvIGdldCA0ayBtb2Rl cyB3b3JraW5nIGFuZCBhc3NpZ24gaXQgdG8gSFBMTCBpbiBSSzM1NjgncyBjbG9jawpkcml2ZXIg KEkgdGVzdGVkIGl0IGFuZCBpdCB3b3JrcyBncmVhdCkuIEl0IG1pZ2h0IGJlIHBvc3NpYmxlIHRv IGp1c3QKYWRkIHRob3NlIHJhdGVzIChzb21lIGFsc28gd2l0aG91dCBmcmFjIGRpdmlkZXJzKSB0 byB0aGUgY29tbW9uIFBMTAp0YWJsZSBmb3IgUkszNTY4LgrCoApJJ20gc29ycnkgSSBkaWRuJ3Qg cmVwbHkgaW5saW5lIGFzIEknbSBzdXBwb3NlZCB0byBkbzogSXQncyBsYXRlIGFuZCBJCndhbnRl ZCB0byBvZmZsb2FkIG15IGZpbmRpbmdzIG5vdyA6KQrCoAooWW91IHByb2JhYmx5IHNob3VsZCBh bHNvIHJlbW92ZSB0aGUgcHJpbnRrcyBpbiBWMikKwqAKQmVzdCwKCkFsZXgKCgpbMF0KaHR0cHM6 Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXJvY2tjaGlwL3BhdGNoLzIwMjEx MTE3MTU0NDI5LjIyNzQ0NDMtMS1taWNoYWVsLnJpZXNjaEB3b2xmdmlzaW9uLm5ldC8KClsxXSBo dHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL2NvbW1lbnQvMjQyOTU2ODMvClsyXQpodHRwczov L2dpdGh1Yi5jb20vcm9ja2NoaXAtbGludXgva2VybmVsL2Jsb2IvZGV2ZWxvcC00LjE5L2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LmR0c2kjTDE3MTUtTDE3MjAKClszXQpodHRw czovL2dpdGh1Yi5jb20vTGlicmVFTEVDL0xpYnJlRUxFQy50di9ibG9iL21hc3Rlci9wcm9qZWN0 cy9Sb2NrY2hpcC9wYXRjaGVzL2xpbnV4L2RlZmF1bHQvbGludXgtMTAwMC1kcm0tcm9ja2NoaXAu cGF0Y2gjTDMxNTUtTDMxODIKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E758C4332F for ; Sun, 21 Nov 2021 23:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=05GC8UwkSC1rfFiMm2v0NOy+U4ekTxLNXC3zM2ofTc4=; b=3fEW7qNEzKkCAYWoIkNEQmtclq rzCxr5GxcOQB7zeRdoxbL+XdU4K49/GI1tQ2cHAAd4YyHYOkJWNKogZ+dgyiB6Zluw6yJbhZex931 iwJ85goXdV7lOVpJAZRef39Lao0k/rlI8cvfdVfJH4GjZnLV7chpx9GHRNTW8CQywyv04ptaHCsnr axxF9YOhgIWiPdCebW3J3yIBvotSRFNZQK4Bc2gpNY9kS2oOKaSdnncWcUuIlFw8TUmFJhfX8CVKI VhB8TV3ofJDtso26NIrhW18yCUvHs2huAPBGCu1twGaOytAR8MgU8JmwO1GGZJVF9d3YEkWgc37mj iyyVf0Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mow6r-00ESSc-4G; Sun, 21 Nov 2021 23:18:57 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mow6l-00ESRq-F1; Sun, 21 Nov 2021 23:18:53 +0000 Received: by mail-wr1-x434.google.com with SMTP id r8so29205563wra.7; Sun, 21 Nov 2021 15:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=pVVV5o4k9iKc92GByRt/kiMair0asSOHzgLz3IkU02B74n8vt0DfLH4QnRX5ZksoZU 5t4jJ2FJJzUznGabZT1ghwRcvb9hrIEJY4zj6RnbbSg8RCltlBj87/LEQKQ/KStFgR6w zn3uDs8jA+C/TUuF4bIK/wErPxGmG27UOsokhuZDkzQ+N4rZboLXXr1tn+e+mdibc+Wr BDcKRssX7FA8FB4za4sAlplzDg15Yd2YYyyGRDRa3aBVBWICQBOk9cpyA9XWewywXBFU MT3FXw9E5O/geRq+KQ8QnLMWtduXvHZLm9EbF7Vj4WVc1l/lmsY4b1Bmo39PTUCrb8IO HWqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=f8J1sB1j5T6/koybxJCcoOSBObvW76gg9Ri6dhzZRQ5r6ItsQcE9uhKj37iB17+mKE nlOSIJyInA3r8kmQ3xAde73xQ6yVMe3hfU7jvaaemx4AKrBSi3cB5iFs3V1uZ52N48Tn fFzXZTfRtkI2i/v2NNv2dxLnFOGAmdNkqjsGVt7lTXp/VXqpVa0ddTEXXdr+rrYY7oTm lJL2RuQXVyVxD478IEjjkP7h+KmNt3k8s/gNhHFoj8ym5zyYjz90e/dFDB27DKqbFVnL /Chm8f0Ddz1tJLItX0xhEZozJ5NF2OuPN2hZXUH3FLhdmjN5+BPmAkPMb2Zyhiia3lGn xixA== X-Gm-Message-State: AOAM530SD89V2XXsMz/0ap/tPop+mAnTIWDm2WE4u91zL+gTtvzmpGCd iqQhLIK4CLK9qahL4P2Apw== X-Google-Smtp-Source: ABdhPJx2INaINAEgviHhidQlQTMYTw9PV/lb6oU11lO2qAR8cCZPrWN7OL85v/eZ2ePUsk8rxhtYRw== X-Received: by 2002:adf:f60c:: with SMTP id t12mr32376728wrp.341.1637536729122; Sun, 21 Nov 2021 15:18:49 -0800 (PST) Received: from [192.168.200.23] (ip5b435a69.dynamic.kabel-deutschland.de. [91.67.90.105]) by smtp.gmail.com with ESMTPSA id 4sm9293595wrz.90.2021.11.21.15.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 15:18:48 -0800 (PST) Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20211117143347.314294-1-s.hauer@pengutronix.de> From: Alex Bee Message-ID: <73c57643-a0db-e7e7-174d-3cb6a978d98a@gmail.com> Date: Mon, 22 Nov 2021 00:18:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211121_151851_531485_47D8F78D X-CRM114-Status: GOOD ( 32.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhLAoKQW0gMTcuMTEuMjEgdW0gMTU6MzMgc2NocmllYiBTYXNjaGEgSGF1ZXI6Cj4g VGhpcyBzZXJpZXMgYWRkcyBpbml0aWFsIGdyYXBoaWNzIHN1cHBvcnQgZm9yIHRoZSBSb2NrY2hp cCBSSzM1Nls2OF0KPiBTb0NzLiAgR3JhcGhpY3Mgc3VwcG9ydCBpcyBiYXNlZCBhcm91bmQgdGhl IFZPUDIgY29udHJvbGxlciB3aGljaAo+IHJlcGxhY2VzIHRoZSBWT1AgY29udHJvbGxlciBmb3Vu ZCBvbiBlYXJsaWVyIFJvY2tjaGlwIFNvQ3MuIFRoZSBkcml2ZXIKPiBoYXMgYmVlbiB0ZXN0ZWQg d2l0aCBIRE1JIHN1cHBvcnQgaW5jbHVkZWQgaW4gdGhpcyBzZXJpZXMgYW5kIE1JUEktRFNJCj4g d2hpY2ggaXMgbm90IGluY2x1ZGVkIGJlY2F1c2UgaXQgbmVlZHMgc29tZSBtb3JlIHdvcmsuIFRo ZSBkcml2ZXIgaXMKPiB0YWtlbiBmcm9tIHRoZSBkb3duc3RyZWFtIFJvY2tjaGlwIGtlcm5lbCBh bmQgaGVhdmlseSBwb2xpc2hlZCwgbW9zdCBub24KPiBzdGFuZGFyZCBmZWF0dXJlcyBoYXZlIGJl ZW4gcmVtb3ZlZCBmb3Igbm93LiBJIHRlc3RlZCB0aGUgZHJpdmVyIHdpdGgKPiB0aGUgbGliZHJt IG1vZGV0ZXN0IHV0aWxpdHkgYW5kIGFsc28gd2l0aCB3ZXN0b24gd2l0aCBib3RoIHBpeG1hbiBh bmQKPiBwYW5mcm9zdCBkcml2ZXIgc3VwcG9ydC4gTWljaGFlbCBSaWVzY2ggcmVwb3J0ZWQgdGhl IGRyaXZlciB0byB3b3JrIG9uCj4gdGhlIFJLMzU2NiBhcyB3ZWxsLCBidXQgZGV2aWNlIHRyZWUg c3VwcG9ydCBmb3IgdGhpcyBTb0MgaXMgbm90IHlldAo+IGluY2x1ZGVkIGluIHRoaXMgc2VyaWVz Lgo+Cj4gVGhlIEhETUkgY2hhbmdlcyBhcmUgYmFzZWQgb24gcGF0Y2hlcyBmcm9tIEJlbmphbWlu IEdhaWduYXJkLCBidXQKPiBtb2RpZmllZCBhIGJpdCBhcyBJIGZvdW5kIG91dCB0aGF0IHRoZSBI RE1JIHBvcnQgb24gdGhlIFJLMzU2OCBvbmx5Cj4gbmVlZHMgb25lIGFkZGl0aW9uYWwgY2xvY2ss IG5vdCB0d28uIEFsc28gSSBhZGRlZCByZWd1bGF0b3Igc3VwcG9ydAo+IHdoaWNoIGlzIG5lZWRl ZCB0byBnZXQgdGhlIEhETUkgdXAgb24gdGhlIHJrMzU2OC1FVkIgYm9hcmQuCj4KPiBBbGwgcmV2 aWV3IGFuZCB0ZXN0aW5nIGZlZWRiYWNrIHdlbGNvbWUKCgp0aGFua3MgZm9yIHdvcmtpbmcgb24g dGhhdCAtIGl0J3MgdmVyeSAodmVyeSx2ZXJ5KSBtdWNoIGFwcHJlY2lhdGVkLgoKSXQgdG9vayBt ZSBzb21lIHRpbWUgdG8gZmlndXJlIGl0IG91dDogSXQgc2VlbXMgcmszNTY4LWlvbW11IGRyaXZl ciBzCmJyb2tlbiAtIEkgZGlkIG9ubHkgZ2V0ICJ3aGl0ZSBub2lzZSIgd2hlbiB1c2luZyBpdCBh bG9uZ3NpZGUgdm9wCihzaW1pbGFyIGxpa2UgaXQgd2FzIHJlcG9ydGVkIGhlcmUgYmVmb3JlKS4g SG93ZXZlcjogcmVtb3ZpbmcgdGhlCmlvbW11LXByb3BlcnR5IGZyb20gdm9wIG1ha2VzIGl0IHdv cmtpbmcgZm9yIG1lIHdpdGggSERNSSBvdXRwdXQgb24KcXVhcnR6NjQgYXMgd2VsbC4gQ291bGQg eW91IGNoZWNrIGlmIHlvdSBoYXZlIHRoZSBpb21tdSBkcml2ZXIgaW4ga2VybmVsCmVuYWJsZWQg aWYgaXQgd29ya3MgZm9yIHlvdSwgaWYgdGhlIHByb3BlcnR5IGlzIHByZXNlbnQgaW4gRFQ/IChJ IHVzZWQKNS4xNi1yYzEgKyB0aGlzIHNlcmllcyArIFswXSkuIEFsc28gdm9wIG1tdSBzZWVtcyB0 byBoYXZlIHRoZQpwb3dlci1kb21haW4gbWlzc2luZyBpbiB5b3VyIHNlcmllcyAoc2FtZSBhcyBk b3duc3RyZWFtKSAtIGhvd2V2ZXIKYWRkaW5nIHRoYXQgZG9lc24ndCBoZWxwIG11Y2ggY3VycmVu dGx5LgpBcyBhIHNpZGVub3RlOiBJIHZlcmZpZWQgdGhpcyB3aXRoIHVzaW5nIEV6ZXF1aWVsJ3Mg dnB1IGFkZHRpb24gZm9yClJLMzU2eDogSXQgZGlkIG9ubHkgd29yayB3aGVuIHJlbW92aW5nIHRo ZSBpb21tdSB0aGVyZSBhcyB3ZWxsIChnZXR0aW5nCnRvbnMgb2YgcGFnZSBmYXVsdHMgb3RoZXJ3 aXNlKSAtIHNvIGlvbW11IGRyaXZlciByZWFsbHkgc2VlbXMgdG8gYnJva2VuLAphdCBsZWFzdCBm b3IgUkszNTY2LiAoT3IgSSdtIGEgbWlzc2luZyBhIG9wdGlvbiBpbiBrZXJuZWwgY29uZmlnLCB3 aGljaAp3YXNuJ3QgcmVxdWlyZWQgZm9yIHRoZSBvbGRlciBpb21tdSB2ZXJzaW9uPykKwqAKQnV0 IGFzIHJlcG9ydGVkIGJlZm9yZTogRm9yIEhETUkgdGhpcyBkb2VzIGN1cnJlbnRseSBvbmx5IHdv cmsgZm9yIHBpeGVsCmNsb2NrIHJhdGVzLCB3aGljaCBhcmUgaW50ZWdlci1kaXZpc2FibGUgd2l0 aCBocGxsIGNsb2NrIHJhdGUgKHdoaWNoIGlzCnRoZSBoYXJkY29kZWQgcGFyZW50IG9mIHZvcDAn cyBkY2xrKQpBcyBkaXNjdXNzZWQgaW4gQmVuamFtaW4ncyBpbml0aWFsIHN1Ym1pc3Npb24gb2Yg dGhlIGFkZGl0aW9uIG9mClJLMzU2OCdzIGhkbWkgY29udHJvbGxlciBbMV0gc2FtZSBhcyB3aXRo IFJLMzI4OCdzIGFuZCBSSzMzOTkncyBoZG1pIHBoeQpuZWVkcyBhIHJlZmVyZW5jZSBjbG9jayAo aXQncyBjYWxsZWQgdnBsbCB0aGVyZSkgd2hpY2ggbmVlZHMgdG8gZ2V0CnN3aXRjaGVkIGJlZm9y ZSB0aGUgdm9wIHN3aXRjaGVzIHRoZSBtb2RlIChzaW5jZSBwaHkgcmF0ZSBzd2l0Y2hpbmcgaXMK ZG9uZSBiZWZvcmUpIC0gaXQncyBIUExMIGluIGNhc2Ugb2YgUkszNTZ4LiBGb3Igd2hhdGV2ZXIg cmVhc29uIGl0J3MKY2FsbGVkICJyZWYiIGZvciBSSzM1Nnggb25seSBkb3duc3RyZWFtIFsyXSAt IHNvIHlvdSBzaG91bGQgYWRkIGFub3RoZXIKY2xvY2sgInZwbGwiIChyZW5hbWluZyBpdCB0byAi cmVmIiBmb3IgX0FMTF8gU29DcyB3aGljaCBoYXZlIGl0IHdvdWxkIGJlCmEgX0dSRUFUXyBpZGVh KSB3aGljaCBpcyA8JnBtdWNydSBQTExfSFBMTD4uCldoYXQgYnJpbmdzIHVzIHRvIHRoZSAicmVh bCIgY2xvY2sgcHJvYmxlbSBhbmQgdGhlIHJlYXNvbiwgd2h5Cm5vbi1pbnRlZ2VyIGRpdmlzYWJs ZSBwaXhlbCBjbG9jayByYXRlcyBhcmUgbm90IHBvc3NpYmxlIEFUTTogVGhpcyBpcyBhCmxvbmcg c3RhbmRpbmcgaXNzdWUgZm9yIFJLMzI4OCBhbmQgUkszMzk5IGFzIHdlbGwgKGFuZCBvbmUgb2Yg dGhlIG1haW4KcmVhc29ucyB3aHkgNGsgbW9kZXMgYXJlIG5vdCBwb3NzaWJsZSBmb3IgdGhvc2Ug b2xkZXIgU29DcyBjdXJyZW50bHkpOgpVcHN0cmVhbSBhbGwgUExMIHJhdGVzIGFyZSBjb250cm9s bGVkIHdpdGggdGhvc2UgUExMIHJhdGUgdGFibGVzIGluIHRoZQpjbG9jayBkcml2ZXIgYW5kIHRo ZXkgaGF2ZSB0byBiZSBfZXhhY3RseV8gZGVmaW5lZCBhcyB0aGV5IGFyZSB1c2VkCihIRE1JIHNp bmtzIGFyZSB2ZXJ5IHBpY2t5KS4KWW91IHdpbGwgbm90IHNlZSBhbnkgYWRkaXRpb25hbCByYXRl cyBkb3duc3RyZWFtIGZvciBSSzM1Njg6IHRoZXkgaGF2ZSBhCm1lY2hhbmlzbSB0aGVyZSB0byBh dXRvbWF0aWNhbGx5IGNhbGN1bGF0ZSB0aGUgUExMIHNldHRpbmdzIGlmIHRoZSByYXRlCmRvZXNu J3QgZXhpc3QgaW4gdGhlc2UgdGFibGVzIChJSVJDIHRoaXMgd2FzIHN1Ym1pdHRlZCB1cHN0cmVh bSBhbHNvOgpidXQgaXQgd2FzIHJlamVjdGVkL2lnbm9yZWQgYnkgbWFpbnRhaW5lcnMpLiBBcyBh IHF1aWNrIGhhY2thcnJvdW5kIChmb3IKdGVzdGluZyk6IFlvdSBjb3VsZCB1c2UgdGhpcyB0YWJs ZSBbM10gd2UgYXJlIHVzaW5nIGluIExpYnJlRWxlYyBmb3IKUkszMzk5IHRvIGdldCA0ayBtb2Rl cyB3b3JraW5nIGFuZCBhc3NpZ24gaXQgdG8gSFBMTCBpbiBSSzM1NjgncyBjbG9jawpkcml2ZXIg KEkgdGVzdGVkIGl0IGFuZCBpdCB3b3JrcyBncmVhdCkuIEl0IG1pZ2h0IGJlIHBvc3NpYmxlIHRv IGp1c3QKYWRkIHRob3NlIHJhdGVzIChzb21lIGFsc28gd2l0aG91dCBmcmFjIGRpdmlkZXJzKSB0 byB0aGUgY29tbW9uIFBMTAp0YWJsZSBmb3IgUkszNTY4LgrCoApJJ20gc29ycnkgSSBkaWRuJ3Qg cmVwbHkgaW5saW5lIGFzIEknbSBzdXBwb3NlZCB0byBkbzogSXQncyBsYXRlIGFuZCBJCndhbnRl ZCB0byBvZmZsb2FkIG15IGZpbmRpbmdzIG5vdyA6KQrCoAooWW91IHByb2JhYmx5IHNob3VsZCBh bHNvIHJlbW92ZSB0aGUgcHJpbnRrcyBpbiBWMikKwqAKQmVzdCwKCkFsZXgKCgpbMF0KaHR0cHM6 Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXJvY2tjaGlwL3BhdGNoLzIwMjEx MTE3MTU0NDI5LjIyNzQ0NDMtMS1taWNoYWVsLnJpZXNjaEB3b2xmdmlzaW9uLm5ldC8KClsxXSBo dHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL2NvbW1lbnQvMjQyOTU2ODMvClsyXQpodHRwczov L2dpdGh1Yi5jb20vcm9ja2NoaXAtbGludXgva2VybmVsL2Jsb2IvZGV2ZWxvcC00LjE5L2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LmR0c2kjTDE3MTUtTDE3MjAKClszXQpodHRw czovL2dpdGh1Yi5jb20vTGlicmVFTEVDL0xpYnJlRUxFQy50di9ibG9iL21hc3Rlci9wcm9qZWN0 cy9Sb2NrY2hpcC9wYXRjaGVzL2xpbnV4L2RlZmF1bHQvbGludXgtMTAwMC1kcm0tcm9ja2NoaXAu cGF0Y2gjTDMxNTUtTDMxODIKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ECD5C433FE for ; Sun, 21 Nov 2021 23:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbhKUXV5 (ORCPT ); Sun, 21 Nov 2021 18:21:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhKUXV4 (ORCPT ); Sun, 21 Nov 2021 18:21:56 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A18C3C061574 for ; Sun, 21 Nov 2021 15:18:50 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id u1so29230402wru.13 for ; Sun, 21 Nov 2021 15:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=pVVV5o4k9iKc92GByRt/kiMair0asSOHzgLz3IkU02B74n8vt0DfLH4QnRX5ZksoZU 5t4jJ2FJJzUznGabZT1ghwRcvb9hrIEJY4zj6RnbbSg8RCltlBj87/LEQKQ/KStFgR6w zn3uDs8jA+C/TUuF4bIK/wErPxGmG27UOsokhuZDkzQ+N4rZboLXXr1tn+e+mdibc+Wr BDcKRssX7FA8FB4za4sAlplzDg15Yd2YYyyGRDRa3aBVBWICQBOk9cpyA9XWewywXBFU MT3FXw9E5O/geRq+KQ8QnLMWtduXvHZLm9EbF7Vj4WVc1l/lmsY4b1Bmo39PTUCrb8IO HWqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=hFAobHqm9HtVOpujxC4uTO8pE50470IUevin0mYNTM9ISwripP4X9P1HWlmn3yZvCp zJwTC6B4av1++ce/p2qwnJE6WlNUUwNiAopVgJEfayzVlLtK8TizRXOT5xf+4CkBd/Pt psgBJgwV3i7RzDCrrPXJ6hgrtpGmbWdFcOy3RT74DHhfxLp2PLGSqTrjrZMyGjIH2Ikl JjGQ1VhLkk9pfSeh42jg6wd18F2EYnUw5czPCy3o1PRFO/iOGCFVNH7xehdS2L0QhktQ Wbl4x1mOIB6Tjf1qYHxpm/+UxSUMRad9Vn10TF/Ou8UfGCRfqQMNb1uWM0KM8JVHbRdf BQMQ== X-Gm-Message-State: AOAM531CdjYniRcM8FjA7ZgZjTXbdc+l39SFNKNZgtU1XeHqmkeexjPp SKZlQ+DIKmJwRcE4dunON3aJjiTX9dVC X-Google-Smtp-Source: ABdhPJx2INaINAEgviHhidQlQTMYTw9PV/lb6oU11lO2qAR8cCZPrWN7OL85v/eZ2ePUsk8rxhtYRw== X-Received: by 2002:adf:f60c:: with SMTP id t12mr32376728wrp.341.1637536729122; Sun, 21 Nov 2021 15:18:49 -0800 (PST) Received: from [192.168.200.23] (ip5b435a69.dynamic.kabel-deutschland.de. [91.67.90.105]) by smtp.gmail.com with ESMTPSA id 4sm9293595wrz.90.2021.11.21.15.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 15:18:48 -0800 (PST) Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20211117143347.314294-1-s.hauer@pengutronix.de> From: Alex Bee Message-ID: <73c57643-a0db-e7e7-174d-3cb6a978d98a@gmail.com> Date: Mon, 22 Nov 2021 00:18:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sascha, Am 17.11.21 um 15:33 schrieb Sascha Hauer: > This series adds initial graphics support for the Rockchip RK356[68] > SoCs. Graphics support is based around the VOP2 controller which > replaces the VOP controller found on earlier Rockchip SoCs. The driver > has been tested with HDMI support included in this series and MIPI-DSI > which is not included because it needs some more work. The driver is > taken from the downstream Rockchip kernel and heavily polished, most non > standard features have been removed for now. I tested the driver with > the libdrm modetest utility and also with weston with both pixman and > panfrost driver support. Michael Riesch reported the driver to work on > the RK3566 as well, but device tree support for this SoC is not yet > included in this series. > > The HDMI changes are based on patches from Benjamin Gaignard, but > modified a bit as I found out that the HDMI port on the RK3568 only > needs one additional clock, not two. Also I added regulator support > which is needed to get the HDMI up on the rk3568-EVB board. > > All review and testing feedback welcome thanks for working on that - it's very (very,very) much appreciated. It took me some time to figure it out: It seems rk3568-iommu driver s broken - I did only get "white noise" when using it alongside vop (similar like it was reported here before). However: removing the iommu-property from vop makes it working for me with HDMI output on quartz64 as well. Could you check if you have the iommu driver in kernel enabled if it works for you, if the property is present in DT? (I used 5.16-rc1 + this series + [0]). Also vop mmu seems to have the power-domain missing in your series (same as downstream) - however adding that doesn't help much currently. As a sidenote: I verfied this with using Ezequiel's vpu addtion for RK356x: It did only work when removing the iommu there as well (getting tons of page faults otherwise) - so iommu driver really seems to broken, at least for RK3566. (Or I'm a missing a option in kernel config, which wasn't required for the older iommu version?)   But as reported before: For HDMI this does currently only work for pixel clock rates, which are integer-divisable with hpll clock rate (which is the hardcoded parent of vop0's dclk) As discussed in Benjamin's initial submission of the addition of RK3568's hdmi controller [1] same as with RK3288's and RK3399's hdmi phy needs a reference clock (it's called vpll there) which needs to get switched before the vop switches the mode (since phy rate switching is done before) - it's HPLL in case of RK356x. For whatever reason it's called "ref" for RK356x only downstream [2] - so you should add another clock "vpll" (renaming it to "ref" for _ALL_ SoCs which have it would be a _GREAT_ idea) which is <&pmucru PLL_HPLL>. What brings us to the "real" clock problem and the reason, why non-integer divisable pixel clock rates are not possible ATM: This is a long standing issue for RK3288 and RK3399 as well (and one of the main reasons why 4k modes are not possible for those older SoCs currently): Upstream all PLL rates are controlled with those PLL rate tables in the clock driver and they have to be _exactly_ defined as they are used (HDMI sinks are very picky). You will not see any additional rates downstream for RK3568: they have a mechanism there to automatically calculate the PLL settings if the rate doesn't exist in these tables (IIRC this was submitted upstream also: but it was rejected/ignored by maintainers). As a quick hackarround (for testing): You could use this table [3] we are using in LibreElec for RK3399 to get 4k modes working and assign it to HPLL in RK3568's clock driver (I tested it and it works great). It might be possible to just add those rates (some also without frac dividers) to the common PLL table for RK3568.   I'm sorry I didn't reply inline as I'm supposed to do: It's late and I wanted to offload my findings now :)   (You probably should also remove the printks in V2)   Best, Alex [0] https://patchwork.kernel.org/project/linux-rockchip/patch/20211117154429.2274443-1-michael.riesch@wolfvision.net/ [1] https://patchwork.kernel.org/comment/24295683/ [2] https://github.com/rockchip-linux/kernel/blob/develop-4.19/arch/arm64/boot/dts/rockchip/rk3568.dtsi#L1715-L1720 [3] https://github.com/LibreELEC/LibreELEC.tv/blob/master/projects/Rockchip/patches/linux/default/linux-1000-drm-rockchip.patch#L3155-L3182 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33DE8C433EF for ; Sun, 21 Nov 2021 23:18:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A16D89BF4; Sun, 21 Nov 2021 23:18:52 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDEA489BF4 for ; Sun, 21 Nov 2021 23:18:50 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id d5so29309298wrc.1 for ; Sun, 21 Nov 2021 15:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=pVVV5o4k9iKc92GByRt/kiMair0asSOHzgLz3IkU02B74n8vt0DfLH4QnRX5ZksoZU 5t4jJ2FJJzUznGabZT1ghwRcvb9hrIEJY4zj6RnbbSg8RCltlBj87/LEQKQ/KStFgR6w zn3uDs8jA+C/TUuF4bIK/wErPxGmG27UOsokhuZDkzQ+N4rZboLXXr1tn+e+mdibc+Wr BDcKRssX7FA8FB4za4sAlplzDg15Yd2YYyyGRDRa3aBVBWICQBOk9cpyA9XWewywXBFU MT3FXw9E5O/geRq+KQ8QnLMWtduXvHZLm9EbF7Vj4WVc1l/lmsY4b1Bmo39PTUCrb8IO HWqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qwEuDzuvO+yZhJXEU0BL1F4ycS9cXS3hWwFrPyPW0yQ=; b=s5aw4R2mxSoRg+wqmNZMC21ZwQoOrWskefjymmlTea9hKyJ8TuHWAJgHj49jfbfHLy zLErIYysdBAO2MBrEO1iRUJ8UV4QXhw8Fj7j06o1SoUyW4N9l2oikfcEGEsNUKIA2UWr gHKC71I2P/9aCOnUzmLoriBtkr0rpQoDGrXYTF03PXHu6AYDaQRNW6IU+G6pJUxA0YRg 4KcKHkveUx/b34TRKvVEWjeuGP4KjHu6dJXupA40o1O2BjRUqv0mPqvfabOFPpBfogma vjv1nlNvOOMB2aDALL8CkFoo/mwe5kpQzgzUxgKNGeUbgqdGgNnGOTtjWdvCNh42W5xJ U2zA== X-Gm-Message-State: AOAM530UHKj72s+lGt5IuY/I/zwPwDSX/z8q7cLg14xUJBqiMxom0KhX hUN4NTiZ94BKwf4qdqvYPw== X-Google-Smtp-Source: ABdhPJx2INaINAEgviHhidQlQTMYTw9PV/lb6oU11lO2qAR8cCZPrWN7OL85v/eZ2ePUsk8rxhtYRw== X-Received: by 2002:adf:f60c:: with SMTP id t12mr32376728wrp.341.1637536729122; Sun, 21 Nov 2021 15:18:49 -0800 (PST) Received: from [192.168.200.23] (ip5b435a69.dynamic.kabel-deutschland.de. [91.67.90.105]) by smtp.gmail.com with ESMTPSA id 4sm9293595wrz.90.2021.11.21.15.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 15:18:48 -0800 (PST) Subject: Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support To: Sascha Hauer , dri-devel@lists.freedesktop.org References: <20211117143347.314294-1-s.hauer@pengutronix.de> From: Alex Bee Message-ID: <73c57643-a0db-e7e7-174d-3cb6a978d98a@gmail.com> Date: Mon, 22 Nov 2021 00:18:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211117143347.314294-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sascha, Am 17.11.21 um 15:33 schrieb Sascha Hauer: > This series adds initial graphics support for the Rockchip RK356[68] > SoCs. Graphics support is based around the VOP2 controller which > replaces the VOP controller found on earlier Rockchip SoCs. The driver > has been tested with HDMI support included in this series and MIPI-DSI > which is not included because it needs some more work. The driver is > taken from the downstream Rockchip kernel and heavily polished, most non > standard features have been removed for now. I tested the driver with > the libdrm modetest utility and also with weston with both pixman and > panfrost driver support. Michael Riesch reported the driver to work on > the RK3566 as well, but device tree support for this SoC is not yet > included in this series. > > The HDMI changes are based on patches from Benjamin Gaignard, but > modified a bit as I found out that the HDMI port on the RK3568 only > needs one additional clock, not two. Also I added regulator support > which is needed to get the HDMI up on the rk3568-EVB board. > > All review and testing feedback welcome thanks for working on that - it's very (very,very) much appreciated. It took me some time to figure it out: It seems rk3568-iommu driver s broken - I did only get "white noise" when using it alongside vop (similar like it was reported here before). However: removing the iommu-property from vop makes it working for me with HDMI output on quartz64 as well. Could you check if you have the iommu driver in kernel enabled if it works for you, if the property is present in DT? (I used 5.16-rc1 + this series + [0]). Also vop mmu seems to have the power-domain missing in your series (same as downstream) - however adding that doesn't help much currently. As a sidenote: I verfied this with using Ezequiel's vpu addtion for RK356x: It did only work when removing the iommu there as well (getting tons of page faults otherwise) - so iommu driver really seems to broken, at least for RK3566. (Or I'm a missing a option in kernel config, which wasn't required for the older iommu version?)   But as reported before: For HDMI this does currently only work for pixel clock rates, which are integer-divisable with hpll clock rate (which is the hardcoded parent of vop0's dclk) As discussed in Benjamin's initial submission of the addition of RK3568's hdmi controller [1] same as with RK3288's and RK3399's hdmi phy needs a reference clock (it's called vpll there) which needs to get switched before the vop switches the mode (since phy rate switching is done before) - it's HPLL in case of RK356x. For whatever reason it's called "ref" for RK356x only downstream [2] - so you should add another clock "vpll" (renaming it to "ref" for _ALL_ SoCs which have it would be a _GREAT_ idea) which is <&pmucru PLL_HPLL>. What brings us to the "real" clock problem and the reason, why non-integer divisable pixel clock rates are not possible ATM: This is a long standing issue for RK3288 and RK3399 as well (and one of the main reasons why 4k modes are not possible for those older SoCs currently): Upstream all PLL rates are controlled with those PLL rate tables in the clock driver and they have to be _exactly_ defined as they are used (HDMI sinks are very picky). You will not see any additional rates downstream for RK3568: they have a mechanism there to automatically calculate the PLL settings if the rate doesn't exist in these tables (IIRC this was submitted upstream also: but it was rejected/ignored by maintainers). As a quick hackarround (for testing): You could use this table [3] we are using in LibreElec for RK3399 to get 4k modes working and assign it to HPLL in RK3568's clock driver (I tested it and it works great). It might be possible to just add those rates (some also without frac dividers) to the common PLL table for RK3568.   I'm sorry I didn't reply inline as I'm supposed to do: It's late and I wanted to offload my findings now :)   (You probably should also remove the printks in V2)   Best, Alex [0] https://patchwork.kernel.org/project/linux-rockchip/patch/20211117154429.2274443-1-michael.riesch@wolfvision.net/ [1] https://patchwork.kernel.org/comment/24295683/ [2] https://github.com/rockchip-linux/kernel/blob/develop-4.19/arch/arm64/boot/dts/rockchip/rk3568.dtsi#L1715-L1720 [3] https://github.com/LibreELEC/LibreELEC.tv/blob/master/projects/Rockchip/patches/linux/default/linux-1000-drm-rockchip.patch#L3155-L3182