From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277DFC4345F for ; Thu, 2 May 2024 14:12:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70A676B0093; Thu, 2 May 2024 10:12:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BB0F6B0096; Thu, 2 May 2024 10:12:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5822B6B0098; Thu, 2 May 2024 10:12:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 395636B0093 for ; Thu, 2 May 2024 10:12:21 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4863780EC5 for ; Thu, 2 May 2024 14:12:20 +0000 (UTC) X-FDA: 82073645640.25.5BDF057 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 337EE18000C for ; Thu, 2 May 2024 14:12:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wt8FQxKg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V6GoaZXY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wt8FQxKg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V6GoaZXY; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714659138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jsVTCkjDHkXTboCJKNp+sthyco/1v9Ji8UUCPt1zBRU=; b=PJ1KK0esR9azJMWhZdTTRtPt1NGR+WDqWRfBaikY6NVP5lvEJ2nzxXIkcFivlRoGqdPGy9 t6jYe5Qo9Q9D92TzuX7Q4JR5q8u1ubU7mPUWo+OWff0U6xoFtoRZp/f87rptiud9P4m3gD drutHUOxXbX3Sy2OQfStAmG1A1L6ezI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wt8FQxKg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V6GoaZXY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wt8FQxKg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V6GoaZXY; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714659138; a=rsa-sha256; cv=none; b=She5s3hc3LdshVaATaZQ6wjD+5Ez4QBloKW4wJdToJvs39F6pDms29cjv7EOKMQRNSnfQh +X/cXNL5+1T6slng77L1MAW9XeA3aDtjvp8rJ6nsJCzJcvaJYTExdm9YCKZGRxLrAUwyhz FT1XuzAMlBeC1j+PX/K42IjvpLqo/0A= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 39FDC1FC2A; Thu, 2 May 2024 14:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714659135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsVTCkjDHkXTboCJKNp+sthyco/1v9Ji8UUCPt1zBRU=; b=wt8FQxKg07+BURDxaya+Rxe7xDbCZ6MVfEUrg2RdzxUAkfj0v8d3YF6EUjq7R1yDMMZNBO sEEZ7vvghwW2MSU/wl9foczh/tTAXY9z+afuiORNZazpMDpNSk6poS9zw6mvLthKGKs7Jx qtZhUlYhwVgee3Sf5tE2IbOpyPKhqYU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714659135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsVTCkjDHkXTboCJKNp+sthyco/1v9Ji8UUCPt1zBRU=; b=V6GoaZXYlpFstWw8zYPU5Vh7dUhlD6mrxbn9MXpraxie2iUDl30FllrxNz+2aaY6g5kaCM agMvDVjz8A6C1mCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714659135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsVTCkjDHkXTboCJKNp+sthyco/1v9Ji8UUCPt1zBRU=; b=wt8FQxKg07+BURDxaya+Rxe7xDbCZ6MVfEUrg2RdzxUAkfj0v8d3YF6EUjq7R1yDMMZNBO sEEZ7vvghwW2MSU/wl9foczh/tTAXY9z+afuiORNZazpMDpNSk6poS9zw6mvLthKGKs7Jx qtZhUlYhwVgee3Sf5tE2IbOpyPKhqYU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714659135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsVTCkjDHkXTboCJKNp+sthyco/1v9Ji8UUCPt1zBRU=; b=V6GoaZXYlpFstWw8zYPU5Vh7dUhlD6mrxbn9MXpraxie2iUDl30FllrxNz+2aaY6g5kaCM agMvDVjz8A6C1mCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29E9A13957; Thu, 2 May 2024 14:12:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id HZMHCj+fM2YhXgAAD6G6ig (envelope-from ); Thu, 02 May 2024 14:12:15 +0000 Message-ID: <73c850f5-3402-4731-9afd-cb57a285fdec@suse.cz> Date: Thu, 2 May 2024 16:12:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] clean-up for create_kmalloc_caches() To: Hyunmin Lee , linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jeungwoo Yoo , Sangyun Kim , Gwan-gyeong Mun References: <20240424140422.12780-1-hyunminlr@gmail.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20240424140422.12780-1-hyunminlr@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 337EE18000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: sjmoszppxaeqa6xfzcqc8dnsptyopkze X-HE-Tag: 1714659136-156579 X-HE-Meta: U2FsdGVkX18cvYoQepMrl3M5HkMnQ/UXv6pTkJcSp6tFKchgMo33dLkPixTkLoMMa+U8Ewp4b6cUmDD29pl3EO2gFsM2KuUY0ZRtcW1/ztQGp0fH9N2cSJUsedg9M8tp0In17uY3VoAtobo6hnAenFSJGHH2a6sjE85G3ipMt++yTcCcnszULhQjyFYSEXbLoqAtHtr/IzTzeX8ThQa8HWDdSI4aInM17SDoFryi4ehcmFr0KcXbcojTDDGZEu2b1XBfySmdEH7pN8ywRvs4UesT7JRhWM4OikBIx1/LJtjKoQ4h5Ho3bBTmTAzDey+c3Tcs2F/TCQXaOlmMAedgFgC+YupQblbH9aP4r5prNxE8XeBixQsaDqjWAuyfSTAZm0+Xqd/XgXrERMgBgF5O9J9cNU5wJZcG4JwK+/ru+he8M61Wjy2XWDctA4YLlWFZvZpbQ+M9aUajmtv52ii0NR8RJdMER6lLEB5f9tmQeapYepllEwbOgCsCnQ6Jr8yG01lmITdna8kA73mTg1kgnWwwflmTeEcwW+HqgPxVxACQNgQTxv7quTmZUywwwVtB83hZ7g4jjXcWVf7vZtgf1kJkwb35HJQgT/rRdnA5i8eWtX2wqBeQ0SBRet+z6DJcH1BEYEfvxPqsGHYniJgeIO9QMmvNuhzpPcuYVzEAk5dneYzsnwWgPujcPiJFceqLvOeLiq+HjZsyJYTUiHq4dcn9kabmwjqyEkYme2fWpx3/pnVG2ls8YRK/XrSQepV+ATY3fhuPTZb9mwU784OgquePiv6NpmGGVjxgjCu03PN38qKiWviGUFcHJ9yhffBURtJuDZvNdkV6IOe2Wups1D6XFIcgh+OGgBhLdiKimASySQIAID9IiKhUQn0VLmwBmpVifxLaBqJFx3W8MNWOL+1gsJ4dk/uI5or3KUjDyC7d5kwze1ahf+sLhEGsXuxqpD4Zd1dTsYy4yRHhtPT 8+E9LpYM tr9MeMcHm0oAcDPCgyp/ed5b/0X7YYdF3QwK9t3cM4FG51ScuSCmI54DdvqqTwIgfe9RnWZVxYx9v46BOYHGA9d0FPG/M7ZzqjL/KsZB2csWf1yjWX+lv8r31rawHGraJ40ICn8bBvR8gsFJ6325lHE+CNsO4m7KH0YqDgLAIdVyE3E6UQ3DoMBzc3nyKXyV6T6/SFPDjtE+Vm0e/C+j0GCu7omQlyVsksNJpM6BF7MZGtiLo2gftvOgYTa9HsX/iMJPgz6zSSM4t9ekH6YH/ktYynbfUyIqX83V1zptdsbaX8rOt7u7jCX1sORuvtTUz0cyByU1UkcPx3XBS52N5sUdGnV4gw2L0phQCjlUX1+mUWa8MNkdzbniS82ThNW1z9FcI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/24/24 16:04, Hyunmin Lee wrote: > Hi pals, > > I am cleanning up unnecessary code in create_kmalloc_caches(). I added > one more commit to remove the check for NULL kmalloc_cachee according to > the review comments like below. > > - David Rientjes suggested moving the check for NULL kmalloc_caches to > new_kmalloc_cache(). > - Christoph Lameter suggested skipping the check for the kmalloc caches > already being present. > > Thanks, > Hyunmin Thanks, applied to slab/for-6.10 > Hyunmin Lee (2): > mm/slub: create kmalloc 96 and 192 caches regardless cache size order > mm/slub: remove the check for NULL kmalloc_caches > > mm/slab_common.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) >