All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Philip Oberfichtner <pro@denx.de>, u-boot@lists.denx.de
Cc: Andre Przywara <andre.przywara@arm.com>,
	Anshul Dalal <anshuld@ti.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Greg Malysa <malysagreg@gmail.com>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Jerome Forissier <jerome.forissier@linaro.org>,
	Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
	Peng Fan <peng.fan@nxp.com>, Simon Glass <sjg@chromium.org>,
	Tom Rini <trini@konsulko.com>,
	Trevor Woerner <twoerner@gmail.com>, Ye Li <ye.li@nxp.com>
Subject: Re: [PATCH v4 1/3] Image size checks: Use HAS_SIZE_LIMIT consistently
Date: Sun, 9 Nov 2025 19:41:13 +0100	[thread overview]
Message-ID: <73d7e852-b2c3-4ef2-a9f6-af4e37941ceb@mailbox.org> (raw)
In-Reply-To: <20251015012320.2331007-2-pro@denx.de>

On 10/15/25 3:23 AM, Philip Oberfichtner wrote:
> Use a consistent logic for image size checks. No functional change.
> 
> Before this commit, there were two concurrent approaches of how image
> size checks are disabled: Whereas BOARD_SIZE_LIMIT was gated through a
> dedicated Kconfig symbol to achieve this, all the other size checks were
> disabled by assigning them a limit of zero bytes.
> 
> By this commit we achieve a consistent logic for size limiting, by
> introducing CONFIG_HAS_XXX_SIZE_LIMIT for all those options that don't
> have it yet.

[...]

> diff --git a/Makefile b/Makefile
> index 2402f9313d8..e68dce2c1d5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1109,19 +1109,19 @@ else
>   BOARD_SIZE_CHECK =
>   endif
>   
> -ifneq ($(CONFIG_SPL_SIZE_LIMIT),0x0)
> +ifneq ($(CONFIG_SPL_SIZE_LIMIT),)

Why does this check not use HAS_SPL_SIZE_LIMIT introduced below ?

>   SPL_SIZE_CHECK = @$(call size_check,$@,$$(tools/spl_size_limit))
>   else
>   SPL_SIZE_CHECK =
>   endif
>   
> -ifneq ($(CONFIG_TPL_SIZE_LIMIT),0x0)
> +ifneq ($(CONFIG_TPL_SIZE_LIMIT),)

DTTO

>   TPL_SIZE_CHECK = @$(call size_check,$@,$(CONFIG_TPL_SIZE_LIMIT))
>   else
>   TPL_SIZE_CHECK =
>   endif
>   
> -ifneq ($(CONFIG_VPL_SIZE_LIMIT),0x0)
> +ifneq ($(CONFIG_VPL_SIZE_LIMIT),)

DTTO

[...]

> +++ b/common/spl/Kconfig
> @@ -36,19 +36,33 @@ config SPL_FRAMEWORK_BOARD_INIT_F
>   	  - initialize the serial (preloader_console_init)
>   	  Unless you want to provide your own board_init_f, you should say Y.
>   
> +config HAS_SPL_SIZE_LIMIT
> +	bool "Enable size limit check for the SPL image"
> +	depends on !COMPILE_TEST
[...]

  reply	other threads:[~2025-11-09 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  1:23 [PATCH v4 0/3] Harmonize image size checks Philip Oberfichtner
2025-10-15  1:23 ` [PATCH v4 1/3] Image size checks: Use HAS_SIZE_LIMIT consistently Philip Oberfichtner
2025-11-09 18:41   ` Marek Vasut [this message]
2025-11-10  7:46     ` Philip Oberfichtner
2025-10-15  1:23 ` [PATCH v4 2/3] Image size checks: Clarify help texts Philip Oberfichtner
2025-11-09 18:55   ` Marek Vasut
2025-10-15  1:23 ` [PATCH v4 3/3] Image size checks: Deduplicate Makefile Philip Oberfichtner
2025-11-09 19:00   ` Marek Vasut
2025-11-04 11:28 ` [PATCH v4 0/3] Harmonize image size checks Philip Oberfichtner
2025-11-04 11:56   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d7e852-b2c3-4ef2-a9f6-af4e37941ceb@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=andre.przywara@arm.com \
    --cc=anshuld@ti.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=malysagreg@gmail.com \
    --cc=nathan.morrison@timesys.com \
    --cc=peng.fan@nxp.com \
    --cc=pro@denx.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=twoerner@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.