From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B001C433DF for ; Mon, 15 Jun 2020 16:17:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3303C20663 for ; Mon, 15 Jun 2020 16:17:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3303C20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkrnL-0004t1-8Z; Mon, 15 Jun 2020 16:17:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkrnJ-0004sw-KT for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 16:17:09 +0000 X-Inumbo-ID: a90e7e06-af23-11ea-bb8b-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a90e7e06-af23-11ea-bb8b-bc764e2007e4; Mon, 15 Jun 2020 16:17:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 95C0AAE61; Mon, 15 Jun 2020 16:17:11 +0000 (UTC) Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for GSIs not requiring an EOI or unmask To: paul@xen.org, 'Andrew Cooper' References: <20200610142923.9074-1-roger.pau@citrix.com> <20200610142923.9074-3-roger.pau@citrix.com> <6de3a582-d9a8-60b5-9525-c9223932e4ed@citrix.com> <00f901d64013$6615a860$3240f920$@xen.org> From: Jan Beulich Message-ID: <73dcc93f-3d2e-e6f0-a044-83a060bddaa4@suse.com> Date: Mon, 15 Jun 2020 18:17:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <00f901d64013$6615a860$3240f920$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, 'Wei Liu' , 'Roger Pau Monne' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.06.2020 19:11, Paul Durrant wrote: >> -----Original Message----- >> From: Andrew Cooper >> Sent: 11 June 2020 17:26 >> To: Roger Pau Monne ; xen-devel@lists.xenproject.org >> Cc: paul@xen.org; Jan Beulich ; Wei Liu >> Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for GSIs not requiring an EOI >> or unmask >> >> On 10/06/2020 15:29, Roger Pau Monne wrote: >>> There's no need to setup a timer for GSIs that are edge triggered, >>> since those don't require any EIO or unmask, and hence couldn't block >>> other interrupts. >>> >>> Note this is only used by PVH dom0, that can setup the passthrough of >>> edge triggered interrupts from the vIO-APIC. One example of such kind >>> of interrupt that can be used by a PVH dom0 would be the RTC timer. >>> >>> While there introduce an out label to do the unlock and reduce code >>> duplication. >>> >>> Signed-off-by: Roger Pau Monné >> >> Acked-by: Andrew Cooper > > Release-acked-by: Paul Durrant Strictly speaking these tags were too little for the patch to go in - the change to drivers/passthrough/io.c would also have required Paul's (or my) R-b. I take it that this was sort of implied by the R-a-b. Jan