From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Evan Green <evgreen@chromium.org>
Cc: Rajat Jain <rajatja@chromium.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Ben Zhang <benzh@chromium.org>, Mark Brown <broonie@kernel.org>,
"M R, Sathya Prakash" <sathya.prakash.m.r@intel.com>,
"M, Naveen" <naveen.m@intel.com>
Subject: Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID
Date: Tue, 7 May 2019 16:06:46 -0500 [thread overview]
Message-ID: <73ebe767-0371-00aa-bb0b-9cb2ba708a42@linux.intel.com> (raw)
In-Reply-To: <CAE=gft5TeW1h3GAT9Gkwdf8eE_p5aoywveE2ddXgYQ+fET8Sdg@mail.gmail.com>
>> What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML
>> PCH-H (0x06C8).
>>
>> Can we respin this patchset to add support for those last two instead of
>> just the -LP case?
>
> Sure. So just to clarify, you want the entry for 0x02c8, and you want
> an additional entry for 0x06c8 under the same config. Will do.
I'd like both entries but with different Kconfigs (e.g. CometLake-LP and
CometLake-H). We have one PCI ID per Kconfig so far.
>>
>> I'll send a patch to add those IDs for the HDaudio legacy driver for
>> consistency.
>
> Actually I've got that change ready to go too, I'm happy to send that out.
I guess I beat you to it.
Thanks for reporting all this.
-Pierre
next prev parent reply other threads:[~2019-05-07 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 22:53 [PATCH v1 0/2] ASoC: Intel: Add Cometlake PCI IDs Evan Green
2019-05-06 22:53 ` [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID Evan Green
2019-05-07 1:40 ` Pierre-Louis Bossart
2019-05-07 3:34 ` M R, Sathya Prakash
2019-05-07 13:37 ` [alsa-devel] " Pierre-Louis Bossart
2019-05-07 20:26 ` Pierre-Louis Bossart
2019-05-07 20:51 ` Evan Green
2019-05-07 21:06 ` Pierre-Louis Bossart [this message]
2019-05-06 22:53 ` [PATCH v1 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs Evan Green
2019-05-06 22:56 ` [PATCH v1 0/2] ASoC: Intel: " Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ebe767-0371-00aa-bb0b-9cb2ba708a42@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=evgreen@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=rajatja@chromium.org \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.