From: MD Danish Anwar <danishanwar@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh@kernel.org>, Roger Quadros <rogerq@ti.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Vignesh Raghavendra <vigneshr@ti.com>,
Simon Horman <horms@kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<srk@ti.com>, <r-gunasekaran@ti.com>,
Roger Quadros <rogerq@kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v2 1/2] dt-bindings: net: Add documentation for Half duplex support.
Date: Wed, 13 Sep 2023 11:47:50 +0530 [thread overview]
Message-ID: <73ec102b-94de-e5ca-f425-8228bf5e2511@ti.com> (raw)
In-Reply-To: <90b3e6cc-7246-4d02-bd0f-2ce7847bc261@lunn.ch>
On 12/09/23 20:46, Andrew Lunn wrote:
>> Sure Rob, I will change the description to below.
>>
>> description:
>> Indicates that the PHY output pin (COL) is routed to ICSSG GPIO
>
> The PHY has multiple output pins, so i would not put COL in brackets,
> but make it explicit which pin you are referring to.
>
Sure, I will remove the brackets and make it explicit.
>> pin (PRGx_PRU0/1_GPIO10) as input and ICSSG MII port is capable
>> of half duplex operations.
>
> "input and so the ICSSG MII port is"
>
I think "input so that the ICSSG MII port is" will be better.
The description would look something like below,
description:
Indicates that the PHY output pin COL is routed to ICSSG GPIO pin
(PRGx_PRU0/1_GPIO10) as input so that the ICSSG MII port is
capable of half duplex operations.
I will post the next version with this change.
> Andrew
--
Thanks and Regards,
Danish
next prev parent reply other threads:[~2023-09-13 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 6:01 [PATCH net-next v2 0/2] Add Half Duplex support for ICSSG Driver MD Danish Anwar
2023-09-11 6:01 ` [PATCH net-next v2 1/2] dt-bindings: net: Add documentation for Half duplex support MD Danish Anwar
2023-09-11 16:46 ` Rob Herring
2023-09-12 5:55 ` MD Danish Anwar
2023-09-12 15:16 ` Andrew Lunn
2023-09-13 6:17 ` MD Danish Anwar [this message]
2023-09-14 10:35 ` Simon Horman
2023-09-11 6:02 ` [PATCH net-next v2 2/2] net: ti: icssg-prueth: Add support for half duplex operation MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ec102b-94de-e5ca-f425-8228bf5e2511@ti.com \
--to=danishanwar@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.