All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] block/meson.build: Restore alphabetical order of files
Date: Tue, 5 Sep 2023 15:28:51 +0200	[thread overview]
Message-ID: <73f5ca15-e079-08c4-5965-e373b3fa3770@linaro.org> (raw)
In-Reply-To: <20230905130607.35134-2-kwolf@redhat.com>

On 5/9/23 15:06, Kevin Wolf wrote:
> When commit 5e5733e5999 created block/meson.build, the list of
> unconditionally added files was in alphabetical order. Later commits
> added new files in random places. Reorder the list to be alphabetical
> again. (As for ordering foo.c against foo-*.c, there are both ways used
> currently; standardise on having foo.c first, even though this is
> different from the original commit 5e5733e5999.)
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/meson.build | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-09-05 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 13:06 [PATCH 0/2] block: Minor cleanups Kevin Wolf
2023-09-05 13:06 ` [PATCH 1/2] block/meson.build: Restore alphabetical order of files Kevin Wolf
2023-09-05 13:28   ` Philippe Mathieu-Daudé [this message]
2023-09-05 13:06 ` [PATCH 2/2] block: Make more BlockDriver definitions static Kevin Wolf
2023-09-05 13:33   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73f5ca15-e079-08c4-5965-e373b3fa3770@linaro.org \
    --to=philmd@linaro.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.