From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pKmKX-0005CH-GK for mharc-grub-devel@gnu.org; Wed, 25 Jan 2023 15:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKmKR-0005By-2C for grub-devel@gnu.org; Wed, 25 Jan 2023 15:25:07 -0500 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKmKO-0008Jw-Kl for grub-devel@gnu.org; Wed, 25 Jan 2023 15:25:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1674678273; bh=sy3frNPcO2jk0BsZCAjXkeZRKKPNuptij/TRpN1ElUM=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=AkawEu/LrznCgifs9ulaiJnrBdUfllLLrtUGfPIQ4qOeqPEsIVTN+9IQHPNxLPQ2a 2GU22GrlpceTZTEEr4OrXTq43oj7yuHQ+ZBIjvPhoXdw+r/SRxcYecOR4XnslqltWG m9Nq187H0YLbKdem+rW4qOv+guWP4+0Xdf1A2cjtWmeaVn+6fIUfXt3vFgNPpsk4G/ YIdGP7JMBD61mVCJgwfRF+7q11fBU92s4dH9cnRZ8U2ql2hI0fqNTrF8Jq28qc4cJP jDx+XAlQfJXRV72nJ02SnDP2baWe2/VCdrgbg/3T+j/C1JZJCda72NHpC7kWvE4cYO NiqTVsCwsaPkQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.236.73]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MHGCu-1pPCBE42sq-00DFCE; Wed, 25 Jan 2023 21:24:33 +0100 Date: Wed, 25 Jan 2023 21:24:00 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v3 0/5] fs/iso9660: Fix out-of-bounds read Content-Type: text/plain; charset="utf-8" Cc: lidong.chen@oracle.com, fengtao40@huawei.com, yanan@huawei.com, daniel.kiper@oracle.com, lichenca2005@gmail.com, development@efficientek.com References: In-Reply-To: Message-Id: <7405393520348946132@scdbackup.webframe.org> X-Provags-ID: V03:K1:rtm7lRhjJmVshPEXwG8or2sNKHtHTdI/kIqlnIuUG7q83XMB0+m V8CeNyXFEbXc4x18t0QQ1O1GLSLuDIhH5M5WNGYNay40+dUiU78gYtKy1eMGKdN3SxwX8RG bCvVA+uO7ROwLllOAqi6RMgYpx1Dl4MGByrKs/pZNCj3Edb5hDQ8GFn1M7Mf8o+VUAZS8+N gnfkxR27ENJPUo5zWehwg== UI-OutboundReport: notjunk:1;M01:P0:ZyA/fl0p6Jk=;GYX4pEPXiQ1JrGlp5AaIoCMnEYf HRlryigVpHTV7+TJNrSF7KqL+5LqnPD+quL90YbiY/wCmUbQEa0yxusxaE1vn786f906j4bvg TjZJ9nxMSbsuI1JM2aL/ctsh94E62zceN1SWkLkx90mUT7z/otd+tCz0x6eizZv2Ev6cTGTS0 HyJA7oaF+jaHmqvzwWR0SdQefzkRgmyJ8FpgYvZMtiQqeaDWFSv/IDLOSqX7UocO54NEDHsJ+ 1k7Sj+gwi5P5GOSggsx8xYUE2oHSBTqDb4JPj9BOcFESeCKBl0ETH1lghgXtqRTRSXuvuuwbA h9jB/1t/Nldfx+/bASSgcGYtkDUR5iXF0bi2+den93Qvvp42lA1+QlA9Xhyi5EUezpBd59rue Qln9HvzN3o0umy3O96hUouJjIUR1X+bjkv4b8Dr7W5dG1V1H+Q93f3VVQ4q4jBD4s2RBfkklF 7IEW80JTAQCpiBDm0sWwZHPLk36gGnbMOSU3gF3oLd0pidXi54waMzeV5+kP6ClnmvRGyS1A7 tXJBQSBB32YkrSUuQlqE9Y5txHI/wJi2lroOHNCdWUcUA4Cd2pMPkWDw2Q4w8zj5TtJ4maD+G 8kk+HBKq9ToPo1iv3ExB24NuUHJHAzYVU1H10H8KayS/dryslHMI46ynyhoCPp6+g2O82e1uo fOD+0GPAqlQMzXR/GUPty/8/SSjnRcE2bK/pQ7mmyPQsr54x+9I1htfPcpcsc3yVnwAtI+11H SZRgfmmoqt4GFaIy8PqbybpIGQ6sOZ+62C5WGsMT5CmChc+OUvN/4FhmmhqVol9qyPn1kg4oo KRSvI29Wi0kPP363PcW4/b+jcBzyNejzdjX+IrhZRBukSv7rusptD5Ftv+7Ld1EPKJ/ZZTj3P 2cQqr/QT27ayJKTRI+B3g5wSdCRN+JAE7oDe7vMg/Qa9ME52x4rpKuQ1wiB6KZ10p3LZWK0pb hegJM8cbdYBB2MMmPIV/zR/3Elc= Received-SPF: pass client-ip=212.227.17.22; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2023 20:25:07 -0000 Hi, Daniel Kiper wrote: > Thomas, it would be nice if you could add the broken ISOs images which you > used for tests to the tests in the GRUB. If you do that please CC Glenn. Is it wise to have a test which will loop endlessly in case of failure ? Is there a way to let a test time out ? Whatever: After poking in my memory and GRUB's tests directory i came to tests/util/grub-fs-tester.in which produces its ISOs as needed. It could be appropriate to create one or both CE loop ISOs there. But this might become a problem in the future, because the post-production hacks depend on correct byte addresses in the ISO image. So it would be better to add one or two canned images: 897 bytes of http://scdbackup.webframe.org/ce_loop.iso.gz 904 bytes of http://scdbackup.webframe.org/ce_loop2.iso.gz Next problem is that these images do not go well with the other tests in grub-fs-tester.in. I would want to run gunzip ce_loop.iso run_grubfstest ls / in the neighborhood of the xorriso runs and then bail out immediately. But i don't yet fully understand what the for-loops around the xorriso runs mean: for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do ... for BLKSIZE in $blksizes; do ... for NDEVICES in $(range "$MINDEVICES" "$MAXDEVICES" 1); do ... x"ziso9660") FSUUID=$(date -u +%Y-%m-%d-%H-%M-%S-00); xorriso ... So how to bail out properly at this point after e.g. x"iso9660_ce_loop") gunzip ce_loop.iso run_grubfstest ls / ? And why do the ls tests in grub-fs-tester.in look like run_grubfstest ls -- -la which i cannot decipher by help of the options[]-list in grub-fstest.c ? I CC Glenn Washburn already now, in the hope that he can point me to examples or states that these ISOs should not become part of the tests. (Crossing fingers for the latter case ... ;-) Have a nice day :) Thomas