From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options
Date: Tue, 06 Oct 2020 00:55:19 +0200 [thread overview]
Message-ID: <7417467.3Ncg9TYYCI@thomas> (raw)
In-Reply-To: <20200901094755.561661-1-michael.pfeiffer@tu-ilmenau.de>
> - cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> + cksum = rte_raw_cksum(ipv4_hdr, (ipv4_hdr->version_ihl & 0xf) * 4);
Truly naive questions:
- doesn't it deserve a static inline function rte_ipv4_hdr_len()?
- how generated code for "* 4" compares with "<< 2"?
next prev parent reply other threads:[~2020-10-05 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:32 [dpdk-dev] [PATCH] net: calculate checksums for packets with IPv4 options Michael Pfeiffer
2020-08-29 11:43 ` Andrew Rybchenko
2020-09-01 9:47 ` [dpdk-dev] [PATCH v2] " Michael Pfeiffer
2020-09-07 7:48 ` Andrew Rybchenko
2020-10-05 22:55 ` Thomas Monjalon [this message]
2020-10-06 2:39 ` Stephen Hemminger
2020-10-06 8:10 ` Olivier Matz
2020-10-06 9:51 ` Michael Pfeiffer
2020-10-06 15:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7417467.3Ncg9TYYCI@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=michael.pfeiffer@tu-ilmenau.de \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.