All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"Song, Hongyan" <hongyan.song@intel.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: orientation: hid-sensor-rotation: Add PM function
Date: Sat, 5 Nov 2016 17:49:35 +0000	[thread overview]
Message-ID: <74221bb4-b854-4e64-a645-e4271d188178@kernel.org> (raw)
In-Reply-To: <1477873760.8025.46.camel@intel.com>

On 31/10/16 00:32, Pandruvada, Srinivas wrote:
> On Sun, 2016-10-30 at 16:22 +0000, Jonathan Cameron wrote:
>> On 25/10/16 02:06, Song Hongyan wrote:
>>>
>>> Rotation sensor function does not work due to miss PM function.
>>> Add common hid sensor iio pm function for rotation sensor.
>>>
>>> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> 
> Fixes: 2b89635e9a9e ("iio: hid_sensor_hub: Common PM functions")
> 
>> Does this completely prevent the driver working or merely make it
>> consume
>> too much power?
> If CONFIG_PM is not defined, then this prevents this sensor to
> function. So above commit caused this.
> 
> This sensor was supposed to be always on to trigger wake up in prior
> external hubs. But with the new ISH hub this is not the case.
>>
>> Only really makes a difference to which route it takes to mainline
>> and how
>> fast it gets there!
> If possible push to 4.9 and mark to stable.
I've added some more description cribbed from your reply here
and a little header from me to make the point it's actually a fix
that wants to go in fast!

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> 
> Thanks,
> Srinivas
> N�����r��y���b�X��ǧv�^�)޺{.n�+����{��*"��^n�r���z�\x1a��h����&��\x1e�G���h�\x03(�階�ݢj"��\x1a�^[m�����z�ޖ���f���h���~�mml==
> 


      reply	other threads:[~2016-11-05 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  1:06 [PATCH] iio: orientation: hid-sensor-rotation: Add PM function Song Hongyan
2016-10-30 16:22 ` Jonathan Cameron
2016-10-31  0:32   ` Pandruvada, Srinivas
2016-11-05 17:49     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74221bb4-b854-4e64-a645-e4271d188178@kernel.org \
    --to=jic23@kernel.org \
    --cc=hongyan.song@intel.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.