From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E2A3C64E7B for ; Mon, 30 Nov 2020 13:18:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC47D206F9 for ; Mon, 30 Nov 2020 13:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dM0+9ms0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OX+Oqc/Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC47D206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RO3DOUdO6Qcqqovo/zqZscjLyceEt4ld6f1DppgdHpM=; b=dM0+9ms0jnXp3TEoRZP6dxBgA 1YA8I25n75f09QqixqBaU0CJCAp8SkDPdWaOHMEvA0uIEurGjGq5+lR+lfpAeZapkYxIJdecmSaqP EH64sAiGwyioKxPMsIzvZKiSQru4LcxAZimd4zEnx3Czw+e430C7Y8sPgVwHQVyEsahXOncoU+bDj H/dgdOfaFLhl+ZTCRhBW1xUYx2T5UIenWyAIdV4va0tMNLb3ODV3r/CaqSjRp3TFO+fQmQKHZHbjo oxU47HMK6G4MI/lgLzRacOxfJSI2p/MQ/JlEsdYEBgtkj93X2eFCyKSEXJyv0lk/qS7Y50ZmmtzxV vRGTPgVLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjj3K-0007fq-6x; Mon, 30 Nov 2020 13:17:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjj2y-0007Wu-Nb for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 13:17:10 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EE9F206F9; Mon, 30 Nov 2020 13:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606742211; bh=1zr1UMCcOfl2mGxHxT7EB+EAZA8oBQSjYHyotMbE2Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OX+Oqc/QaNqdyRhkmycg1jXs0/AB9qaBnvGnyYOBRvuSyg+YPI9em3wURWewdMImM q11Oi/wQSfCPJE8n4OwmfxHbwSg4a7s2LKXWGqf+HxbeOs5aK9wmOCGZbA496jUILq yl0R3TAM1lRLgWI296MmDo3RLhxNlvp7zGQ9hSWo= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kjj2v-00EhLk-67; Mon, 30 Nov 2020 13:16:49 +0000 MIME-Version: 1.0 Date: Mon, 30 Nov 2020 13:16:49 +0000 From: Marc Zyngier To: Shameerali Kolothum Thodi Subject: Re: [PATCH] irqchip/gic-v3: Check SRE bit for GICv2 legacy support In-Reply-To: References: <20201130102639.7504-1-shameerali.kolothum.thodi@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7422841eba7a0243c8aaefb6c0f044bf@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_081653_074267_D1A9831C X-CRM114-Status: GOOD ( 37.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuzenghui , eric.auger@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linuxarm Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMS0zMCAxMjowNiwgU2hhbWVlcmFsaSBLb2xvdGh1bSBUaG9kaSB3cm90ZToKPiBI aSBaZW5naHVpLAo+IAo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiB5dXpl bmdodWkKPj4gU2VudDogMzAgTm92ZW1iZXIgMjAyMCAxMTo1MQo+PiBUbzogU2hhbWVlcmFsaSBL b2xvdGh1bSBUaG9kaSA8c2hhbWVlcmFsaS5rb2xvdGh1bS50aG9kaUBodWF3ZWkuY29tPjsKPj4g bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCj4+IENjOiBtYXpAa2VybmVsLm9yZzsgTGludXhhcm0gPGxpbnV4YXJtQGh1YXdl aS5jb20+Owo+PiBlcmljLmF1Z2VyQHJlZGhhdC5jb20KPj4gU3ViamVjdDogUmU6IFtQQVRDSF0g aXJxY2hpcC9naWMtdjM6IENoZWNrIFNSRSBiaXQgZm9yIEdJQ3YyIGxlZ2FjeSAKPj4gc3VwcG9y dAo+PiAKPj4gSGkgU2hhbWVlciwKPj4gCj4+IE9uIDIwMjAvMTEvMzAgMTg6MjYsIFNoYW1lZXIg S29sb3RodW0gd3JvdGU6Cj4+ID4gQXQgcHJlc2VudCwgdGhlIHN1cHBvcnQgZm9yIEdJQ3YyIGJh Y2t3YXJkIGNvbXBhdGliaWxpdHkgb24gR0lDdjMvdjQKPj4gPiBoYXJkd2FyZSBpcyBkZXRlcm1p bmVkIGJhc2VkIG9uIHdoZXRoZXIgRFQvQUNQSSBwcm92aWRlcyBhIG1lbW9yeQo+PiA+IG1hcHBl ZCBwaHlzIGJhc2UgYWRkcmVzcyBmb3IgR0lDIHZpcnR1YWwgQ1BVIGludGVyZmFjZSByZWdpc3Rl cihHSUNWKS4KPj4gPiBUaGlzIGNyZWF0ZXMgYSBwcm9ibGVtIHRoYXQgYSBRZW11IGd1ZXN0IGJv b3Qgd2l0aCBkZWZhdWx0IEdJQyhHSUN2MikKPj4gPiBoYW5ncyB3aGVuIGZpcm13YXJlIGZhbHNl bHkgcmVwb3J0cyB0aGlzIGFkZHJlc3Mgb24gc3lzdGVtcyB0aGF0IGRvbid0Cj4+ID4gaGF2ZSBz dXBwb3J0IGZvciBsZWdhY3kgbW9kZS4KPj4gCj4+IFNvIHRoZSBwcm9ibGVtIGlzIHRoYXQgQklP UyBoYXMgcHJvdmlkZWQgdXMgYSBib2d1cyBHSUNDIFN0cnVjdHVyZS4KPiAKPiBZZXMuIEFuZCBr ZXJuZWwgdXNlcyB0aGlzIGZpZWxkIHRvIGRldGVybWluZSB0aGUgbGVnYWN5IHN1cHBvcnQuCj4g Cj4+IAo+PiA+IEFzIHBlciBHSUN2My92NCBzcGVjLCBpbiBhbiBpbXBsZW1lbnRhdGlvbiB0aGF0 IGRvZXMgbm90IHN1cHBvcnQgbGVnYWN5Cj4+ID4gb3BlcmF0aW9uLCBhZmZpbml0eSByb3V0aW5n IGFuZCBzeXN0ZW0gcmVnaXN0ZXIgYWNjZXNzIGFyZSBwZXJtYW5lbnRseQo+PiA+IGVuYWJsZWQu IFRoaXMgbWVhbnMgdGhhdCB0aGUgYXNzb2NpYXRlZCBjb250cm9sIGJpdHMgYXJlIFJBTy9XSS4g SGVuY2UKPj4gPiB1c2UgdGhlIElDQ19TUkVfRUwxLlNSRSBiaXQgdG8gZGVjaWRlIHdoZXRoZXIg aGFyZHdhcmUgc3VwcG9ydHMgR0lDdjIKPj4gPiBtb2RlIGluIGFkZGl0aW9uIHRvIHRoZSBhYm92 ZSBmaXJtd2FyZSBiYXNlZCBjaGVjay4KPj4gPgo+PiA+IFNpZ25lZC1vZmYtYnk6IFNoYW1lZXIg S29sb3RodW0gPHNoYW1lZXJhbGkua29sb3RodW0udGhvZGlAaHVhd2VpLmNvbT4KPj4gPiAtLS0K Pj4gPiBPbiBIaXNpbGljb24gRDA2LCBVRUZJIHNldHMgdGhlIEdJQyBNQURUIEdJQ0MgZ2ljdl9i YXNlX2FkZHJlc3MgYnV0IHRoZQo+PiA+IEdJQyBpbXBsZW1lbnRhdGlvbsKgb24gdGhlc2UgYm9h cmRzIGRvZXNuJ3QgaGF2ZSB0aGUgR0lDdjIgbGVnYWN5IHN1cHBvcnQuCj4+ID4gVGhpcyByZXN1 bHRzIGluLCBHdWVzdCBib290IGhhbmcgd2hlbiBRZW11IHVzZXMgdGhlIGRlZmF1bHQgR0lDIG9w dGlvbi4KPj4gPgo+PiA+IFdpdGggdGhpcyBwYXRjaCwgdGhlIFFlbXUgR3Vlc3Qgd2l0aCBHSUN2 MiBub3cgZ3JhY2VmdWxseSBleGl0cywKPj4gPiAgICJxZW11LXN5c3RlbS1hYXJjaDY0OiBob3N0 IGRvZXMgbm90IHN1cHBvcnQgaW4ta2VybmVsIEdJQ3YyIGVtdWxhdGlvbiIKPj4gPgo+PiA+IE5v dCB2ZXJ5IHN1cmUgdGhlcmUgaXMgYSBiZXR0ZXIgd2F5IHRvIGRldGVjdCB0aGlzIG90aGVyIHRo YW4gY2hlY2tpbmcKPj4gPiB0aGUgU1JFIGJpdCBhcyBkb25lIGluIHRoaXMgcGF0Y2goT2YgY291 cnNlLCB3ZSB3aWxsIGJlIGZpeGluZyB0aGUgVUVGSQo+PiA+IGdvaW5nIGZvcndhcmQpLgo+PiAK Pj4gWWVzLCBJIGhhZCBzZWVuIHRoZSBzYW1lIHByb2JsZW0gb24gdGhlIEQwNi4gQnV0IEkgKmRv KiB0aGluayBpdCdzIHRoZQo+PiBmaXJtd2FyZSB0aGF0IGFjdHVhbGx5IG5lZWRzIHRvIGJlIGZp eGVkLgo+IAo+IFdlbGwsIEkgYW0gbm90IHN1cmUgSSBhZ3JlZSB3aXRoIHRoYXQuIFRoZSBBQ1BJ IHNwZWMgNi4zLCBzZWN0aW9uCj4gNS4yLjEyLjE0LCBzYXlzLAo+ICJJZiB0aGUgcGxhdGZvcm0g aXMgbm90IHByZXNlbnRpbmcgYSBHSUN2MiB3aXRoIHZpcnR1YWxpemF0aW9uIAo+IGV4dGVuc2lv bnMgdGhpcwo+IGZpZWxkICpjYW4qIGJlIDAiLiBTbyBkb27igJl0IHRoaW5rIGl0IG1hbmRhdGVz IHRoYXQuCgpOb3RlOiAqR0lDdjIqLCBub3QgR0lDdjMgd2l0aCB2MiBjb21wYXRpYmlsaXR5LiBJ IHN0aWxsIHRoaW5rIHRoZSAKZmlybXdhcmUKc2hvdWxkIGJlIGZpeGVkLiBCdXQgdGhhdCBhbHNv IHJlbGllcyBvbiBmaW5kaW5nIG91dCB3aGV0aGVyIHRoZSBicm9rZW4KRlcgaXMgaW4gdGhlIHdp bGQgb3Igbm90LiBJZiBpdCBpcyBhbHJlYWR5LCB3ZSBuZWVkIHNvbWV0aGluZyBpbiB0aGUgCmtl cm5lbC4KCj4+IAo+PiA+IFRoYW5rcywKPj4gPiBTaGFtZWVyCj4+ID4KPj4gPiAtLS0KPj4gPiAg IGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLmMgfCAzMyArKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0KPj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA1IGRl bGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2lj LXYzLmMgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My5jCj4+ID4gaW5kZXggMTZmZWNjMGZl YmU4Li4xNWZhMWVlYTQ1ZTQgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9pcnFjaGlwL2lycS1n aWMtdjMuYwo+PiA+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLmMKPj4gPiBAQCAt MTgzNSw2ICsxODM1LDI3IEBAIHN0YXRpYyB2b2lkIF9faW5pdAo+PiBnaWNfcG9wdWxhdGVfcHBp X3BhcnRpdGlvbnMoc3RydWN0IGRldmljZV9ub2RlICpnaWNfbm9kZSkKPj4gPiAgIAlvZl9ub2Rl X3B1dChwYXJ0c19ub2RlKTsKPj4gPiAgIH0KPj4gPgo+PiA+ICsvKiBTUkUgYml0IGJlaW5nIFJB Ty9XSSBpbXBsaWVzIG5vIEdJQ3YyIGxlZ2FjeSBtb2RlIHN1cHBvcnQgKi8KPj4gCj4+IEknbSB3 b25kZXJpbmcgaWYgdGhpcyBpcyBhIG1hbmRhdGUgb2YgdGhlIGFyY2hpdGVjdHVyZS4KPiAKPiBB cyBJIG1lbnRpb25lZCBhYm92ZSwgSSBhbSBub3Qgc3VyZSB0aGlzIGlzIHRoZSBiZXN0IHdheSwg dGhvdWdoLAo+IHNlY3Rpb24gMS4zLjUgb2YgR0lDdjMgc3BlYywgc2F5cyhmb3Igbm8gbGVnYWN5 IHN1cHBvcnQgY2FzZSAiYWZmaW5pdHkKPiByb3V0aW5nIGFuZCBzeXN0ZW0gcmVnaXN0ZXIgYWNj ZXNzIGFyZSBwZXJtYW5lbnRseSBlbmFibGVkLiBUaGlzIG1lYW5zCj4gdGhhdCB0aGUgYXNzb2Np YXRlZCBjb250cm9sIGJpdHMgYXJlIFJBTy9XSSIKPiAKPiBCdXQgYWdhaW4gbGF0ZXIgaW4gdGhl IHNwZWMsIGl0IHVzZXMgIm1pZ2h0IGNob29zZSB0bwo+IG1ha2UgdGhpcyBiaXQgUkFPL1dJIi4g U28gaXQgaXMgYXJndWFibGUgdGhhdCBpdCBtYW5kYXRlcyBpdCBvciBub3QuCj4gCj4gSSBsZWF2 ZSB0aGF0IHRvIE1hcmMgOikKCi0gSWYgd2UgY2Fubm90IGNsZWFyIFNSRSwgdGhlbiB3ZSBjYW5u b3QgdXNlIHYyIGNvbXBhdCwgYW5kIHdlJ3JlIGdvb2QuCgotIElmIHdlIGNhbiBjbGVhciBTUkUg YW5kIHRoYXQgdGhlcmUgaXMgbm8gR0lDViByZWdpb24sIHdlJ3JlIGdvbyB0b28uCgotIElmIHdl IGNhbiBjbGVhciBTUkUgYW5kIHRoYXQgdGhlcmUgaXMgYSAqYm9ndXMqIEdJQ1YgcmVnaW9uLCB0 aGVyZQogICBpcyBub3RoaW5nIHdlIGNhbiBkbyBhbmQgdGhlIG1hY2hpbmUgd2lsbCBleHBsb2Rl IHdoZW4gdGhlIGd1ZXN0CiAgIHBva2VzIGF0IGl0LgoKVXNpbmcgQVJFIHdvdWxkIGJlIHRlbXB0 aW5nLCBidXQgQUZBSUtUIGl0IGlzIG9ubHkgcmVsZXZhbnQgdG8gdGhlCnBoeXNpY2FsIHNpZGUg b2YgdGhlIEdJQywgYW5kIGhhcyBubyBiZWFyaW5nIG9uIHRoZSB2aXJ0dWFsIHNpZGUKKHNpbmNl IHRoZSBkaXN0cmlidXRvciBpcyBpdHNlbGYgdmlydHVhbCkuCgpUaGFua3MsCgogICAgICAgICBN LgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A21C64E90 for ; Mon, 30 Nov 2020 13:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C77952073C for ; Mon, 30 Nov 2020 13:17:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OX+Oqc/Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgK3NRd (ORCPT ); Mon, 30 Nov 2020 08:17:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:54186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgK3NRc (ORCPT ); Mon, 30 Nov 2020 08:17:32 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EE9F206F9; Mon, 30 Nov 2020 13:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606742211; bh=1zr1UMCcOfl2mGxHxT7EB+EAZA8oBQSjYHyotMbE2Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OX+Oqc/QaNqdyRhkmycg1jXs0/AB9qaBnvGnyYOBRvuSyg+YPI9em3wURWewdMImM q11Oi/wQSfCPJE8n4OwmfxHbwSg4a7s2LKXWGqf+HxbeOs5aK9wmOCGZbA496jUILq yl0R3TAM1lRLgWI296MmDo3RLhxNlvp7zGQ9hSWo= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kjj2v-00EhLk-67; Mon, 30 Nov 2020 13:16:49 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 30 Nov 2020 13:16:49 +0000 From: Marc Zyngier To: Shameerali Kolothum Thodi Cc: yuzenghui , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linuxarm , eric.auger@redhat.com Subject: Re: [PATCH] irqchip/gic-v3: Check SRE bit for GICv2 legacy support In-Reply-To: References: <20201130102639.7504-1-shameerali.kolothum.thodi@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7422841eba7a0243c8aaefb6c0f044bf@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-30 12:06, Shameerali Kolothum Thodi wrote: > Hi Zenghui, > >> -----Original Message----- >> From: yuzenghui >> Sent: 30 November 2020 11:51 >> To: Shameerali Kolothum Thodi ; >> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Cc: maz@kernel.org; Linuxarm ; >> eric.auger@redhat.com >> Subject: Re: [PATCH] irqchip/gic-v3: Check SRE bit for GICv2 legacy >> support >> >> Hi Shameer, >> >> On 2020/11/30 18:26, Shameer Kolothum wrote: >> > At present, the support for GICv2 backward compatibility on GICv3/v4 >> > hardware is determined based on whether DT/ACPI provides a memory >> > mapped phys base address for GIC virtual CPU interface register(GICV). >> > This creates a problem that a Qemu guest boot with default GIC(GICv2) >> > hangs when firmware falsely reports this address on systems that don't >> > have support for legacy mode. >> >> So the problem is that BIOS has provided us a bogus GICC Structure. > > Yes. And kernel uses this field to determine the legacy support. > >> >> > As per GICv3/v4 spec, in an implementation that does not support legacy >> > operation, affinity routing and system register access are permanently >> > enabled. This means that the associated control bits are RAO/WI. Hence >> > use the ICC_SRE_EL1.SRE bit to decide whether hardware supports GICv2 >> > mode in addition to the above firmware based check. >> > >> > Signed-off-by: Shameer Kolothum >> > --- >> > On Hisilicon D06, UEFI sets the GIC MADT GICC gicv_base_address but the >> > GIC implementation on these boards doesn't have the GICv2 legacy support. >> > This results in, Guest boot hang when Qemu uses the default GIC option. >> > >> > With this patch, the Qemu Guest with GICv2 now gracefully exits, >> > "qemu-system-aarch64: host does not support in-kernel GICv2 emulation" >> > >> > Not very sure there is a better way to detect this other than checking >> > the SRE bit as done in this patch(Of course, we will be fixing the UEFI >> > going forward). >> >> Yes, I had seen the same problem on the D06. But I *do* think it's the >> firmware that actually needs to be fixed. > > Well, I am not sure I agree with that. The ACPI spec 6.3, section > 5.2.12.14, says, > "If the platform is not presenting a GICv2 with virtualization > extensions this > field *can* be 0". So don’t think it mandates that. Note: *GICv2*, not GICv3 with v2 compatibility. I still think the firmware should be fixed. But that also relies on finding out whether the broken FW is in the wild or not. If it is already, we need something in the kernel. >> >> > Thanks, >> > Shameer >> > >> > --- >> > drivers/irqchip/irq-gic-v3.c | 33 ++++++++++++++++++++++++++++----- >> > 1 file changed, 28 insertions(+), 5 deletions(-) >> > >> > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c >> > index 16fecc0febe8..15fa1eea45e4 100644 >> > --- a/drivers/irqchip/irq-gic-v3.c >> > +++ b/drivers/irqchip/irq-gic-v3.c >> > @@ -1835,6 +1835,27 @@ static void __init >> gic_populate_ppi_partitions(struct device_node *gic_node) >> > of_node_put(parts_node); >> > } >> > >> > +/* SRE bit being RAO/WI implies no GICv2 legacy mode support */ >> >> I'm wondering if this is a mandate of the architecture. > > As I mentioned above, I am not sure this is the best way, though, > section 1.3.5 of GICv3 spec, says(for no legacy support case "affinity > routing and system register access are permanently enabled. This means > that the associated control bits are RAO/WI" > > But again later in the spec, it uses "might choose to > make this bit RAO/WI". So it is arguable that it mandates it or not. > > I leave that to Marc :) - If we cannot clear SRE, then we cannot use v2 compat, and we're good. - If we can clear SRE and that there is no GICV region, we're goo too. - If we can clear SRE and that there is a *bogus* GICV region, there is nothing we can do and the machine will explode when the guest pokes at it. Using ARE would be tempting, but AFAIKT it is only relevant to the physical side of the GIC, and has no bearing on the virtual side (since the distributor is itself virtual). Thanks, M. -- Jazz is not dead. It just smells funny...