From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:33789 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753079AbeCTMh3 (ORCPT ); Tue, 20 Mar 2018 08:37:29 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Niklas =?ISO-8859-1?Q?S=F6derlund?= , Jacopo Mondi , architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle Date: Tue, 20 Mar 2018 14:38:34 +0200 Message-ID: <7425649.OD69MjNjYI@avalon> In-Reply-To: <20180316093953.GC31710@w540> References: <1521130316-1221-1-git-send-email-jacopo+renesas@jmondi.org> <20180316000004.GC3432@bigcity.dyn.berto.se> <20180316093953.GC31710@w540> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, On Friday, 16 March 2018 11:39:53 EET jacopo mondi wrote: > On Fri, Mar 16, 2018 at 01:00:04AM +0100, Niklas S=F6derlund wrote: > > Hi Jacopo, > >=20 > > Thanks for your patch. > >=20 > > This one must depend on '[PATCH v2 0/5] arm64: dts: renesas: r8a77970: > > enable HDMI output' or something similar not yet in renesas-drivers > > repository correct? >=20 > Yes, I have listed dependencies of this series in my v1 cover letter: >=20 > -------------------------------------------------------------------------= =2D- > The series is based on Laurent's drm/next/du branch with patches on top f= or: > - Sergei: Enable PFC, I2c, GPIOs for r8a77970 > - Sergei: Add support for r8a77970 in DU and add display device nodes in > r8a77970 DTSI > - Niklas: Connect DU LVDS output to HDMI bridge adv7511w in Eagle DTS > - Sergei: fix video output on R8A77970 >=20 > A base branch with these patches applied is available at > git://jmondi.org/linux v3m/v4.16-rc3/base > -------------------------------------------------------------------------= =2D- >=20 > My bad I have not reported this in all cover letters (and I have not > reported the full name of the series) >=20 > PFC, GPIO and I2c support I have listed as dependencies seems to have > landed in renesas-drivers, while I don't see yet: >=20 > Sergei: > [PATCH v2 0/5] Add R8A77970/V3MSK LVDS/HDMI support >=20 > whose patches for r8a77970 dtsi are included in yours: > [PATCH v2 0/5] arm64: dts: renesas: r8a77970: enable HDMI output >=20 > On top I also have Sergei's/Laurent's: > [PATCH v4] v4l: vsp1: Fix video output on R8A77970 >=20 > > In the next version would you care to include the LVDS commit from the > > dependency series and squash this change into that one or in some other > > good manger stack to two? Laurent told me he did not like 5/5 in that > > patch-set as it did not yet have the LVDS decoder node due to no driver > > existed at that time when I posted that even if it's not strictly needed > > to get the display working :-) >=20 > I'll let Simon suggest how he preferes to handle this, if he wants me > to re-submit your series with this patch squashed on top or he prefers > to deal with this himself. >=20 > > I also think you should split this last patch out to a separate series > > as it should go in Simon's tree while the driver and documentation is > > going in earlier in a different tree right? >=20 > I assume bindings and driver go through DRM and Simon is to pick up > the Eagle changes. >=20 > > On a side note, do you plan to update the Gen2 boards DTS files which > > also have a decoder which are not yet described in DT? >=20 > Actually I'm not aware of Gen2 boards with this chip and similar > display pipelines. Can you point me to which one needs to have its > DTS brushed? It's the Lager board. > > On 2018-03-15 17:11:56 +0100, Jacopo Mondi wrote: > > > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > > > decoder, connected to the on-chip LVDS encoder output on one side > > > and to HDMI encoder ADV7511w on the other one. > > >=20 > > > As the decoder does not need any configuration it has been so-far > > > omitted from DTS. Now that a driver is available, describe it in DT > > > as well. > > >=20 > > > Signed-off-by: Jacopo Mondi > > > Reviewed-by: Andrzej Hajda > > > --- > > >=20 > > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 33 ++++++++++++++++= =2D-- > > > 1 file changed, 30 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > > > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index c0fd144..69f43= b8 > > > 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > > > @@ -42,6 +42,33 @@ > > > }; > > > }; > > > }; > > > + > > > + thc63lvd1024: lvds-decoder { > > > + compatible =3D "thine,thc63lvd1024"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + > > > + thc63lvd1024_in_0: endpoint { > > > + remote-endpoint =3D <&lvds0_out>; > > > + }; > > > + }; > > > + > > > + port@2{ > > > + reg =3D <2>; > > > + > > > + thc63lvd1024_out_2: endpoint { > > > + remote-endpoint =3D <&adv7511_in>; > > > + }; > > > + > > > + }; > > > + > > > + }; > > > + }; > > > }; > > > =20 > > > &avb { > > > @@ -98,7 +125,7 @@ > > > port@0 { > > > reg =3D <0>; > > > adv7511_in: endpoint { > > > - remote-endpoint =3D <&lvds0_out>; > > > + remote-endpoint =3D <&thc63lvd1024_out_2>; > > > }; > > > }; > > >=20 > > > @@ -152,8 +179,8 @@ > > >=20 > > > ports { > > > port@1 { > > > - endpoint { > > > - remote-endpoint =3D <&adv7511_in>; > > > + lvds0_out: endpoint { > > > + remote-endpoint =3D <&thc63lvd1024_in_0>; > > > }; > > > }; > > > }; =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v5 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle Date: Tue, 20 Mar 2018 14:38:34 +0200 Message-ID: <7425649.OD69MjNjYI@avalon> References: <1521130316-1221-1-git-send-email-jacopo+renesas@jmondi.org> <20180316000004.GC3432@bigcity.dyn.berto.se> <20180316093953.GC31710@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180316093953.GC31710@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, airlied@linux.ie, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, Jacopo Mondi , dri-devel@lists.freedesktop.org, Niklas =?ISO-8859-1?Q?S=F6derlund?= , geert@linux-m68k.org List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKT24gRnJpZGF5LCAxNiBNYXJjaCAyMDE4IDExOjM5OjUzIEVFVCBqYWNvcG8g bW9uZGkgd3JvdGU6Cj4gT24gRnJpLCBNYXIgMTYsIDIwMTggYXQgMDE6MDA6MDRBTSArMDEwMCwg TmlrbGFzIFPDtmRlcmx1bmQgd3JvdGU6Cj4gPiBIaSBKYWNvcG8sCj4gPiAKPiA+IFRoYW5rcyBm b3IgeW91ciBwYXRjaC4KPiA+IAo+ID4gVGhpcyBvbmUgbXVzdCBkZXBlbmQgb24gJ1tQQVRDSCB2 MiAwLzVdIGFybTY0OiBkdHM6IHJlbmVzYXM6IHI4YTc3OTcwOgo+ID4gZW5hYmxlIEhETUkgb3V0 cHV0JyBvciBzb21ldGhpbmcgc2ltaWxhciBub3QgeWV0IGluIHJlbmVzYXMtZHJpdmVycwo+ID4g cmVwb3NpdG9yeSBjb3JyZWN0Pwo+IAo+IFllcywgSSBoYXZlIGxpc3RlZCBkZXBlbmRlbmNpZXMg b2YgdGhpcyBzZXJpZXMgaW4gbXkgdjEgY292ZXIgbGV0dGVyOgo+IAo+IC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+IFRoZSBzZXJpZXMgaXMgYmFzZWQgb24gTGF1cmVudCdzIGRybS9uZXh0L2R1IGJyYW5j aCB3aXRoIHBhdGNoZXMgb24gdG9wIGZvcjoKPiAtIFNlcmdlaTogRW5hYmxlIFBGQywgSTJjLCBH UElPcyBmb3IgcjhhNzc5NzAKPiAtIFNlcmdlaTogQWRkIHN1cHBvcnQgZm9yIHI4YTc3OTcwIGlu IERVIGFuZCBhZGQgZGlzcGxheSBkZXZpY2Ugbm9kZXMgaW4KPiAgIHI4YTc3OTcwIERUU0kKPiAt IE5pa2xhczogQ29ubmVjdCBEVSBMVkRTIG91dHB1dCB0byBIRE1JIGJyaWRnZSBhZHY3NTExdyBp biBFYWdsZSBEVFMKPiAtIFNlcmdlaTogZml4IHZpZGVvIG91dHB1dCBvbiBSOEE3Nzk3MAo+IAo+ IEEgYmFzZSBicmFuY2ggd2l0aCB0aGVzZSBwYXRjaGVzIGFwcGxpZWQgaXMgYXZhaWxhYmxlIGF0 Cj4gZ2l0Oi8vam1vbmRpLm9yZy9saW51eCB2M20vdjQuMTYtcmMzL2Jhc2UKPiAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPiAKPiBNeSBiYWQgSSBoYXZlIG5vdCByZXBvcnRlZCB0aGlzIGluIGFsbCBjb3Zl ciBsZXR0ZXJzIChhbmQgSSBoYXZlIG5vdAo+IHJlcG9ydGVkIHRoZSBmdWxsIG5hbWUgb2YgdGhl IHNlcmllcykKPiAKPiBQRkMsIEdQSU8gYW5kIEkyYyBzdXBwb3J0IEkgaGF2ZSBsaXN0ZWQgYXMg ZGVwZW5kZW5jaWVzIHNlZW1zIHRvIGhhdmUKPiBsYW5kZWQgaW4gcmVuZXNhcy1kcml2ZXJzLCB3 aGlsZSBJIGRvbid0IHNlZSB5ZXQ6Cj4gCj4gU2VyZ2VpOgo+IFtQQVRDSCB2MiAwLzVdIEFkZCBS OEE3Nzk3MC9WM01TSyBMVkRTL0hETUkgc3VwcG9ydAo+IAo+IHdob3NlIHBhdGNoZXMgZm9yIHI4 YTc3OTcwIGR0c2kgYXJlIGluY2x1ZGVkIGluIHlvdXJzOgo+IFtQQVRDSCB2MiAwLzVdIGFybTY0 OiBkdHM6IHJlbmVzYXM6IHI4YTc3OTcwOiBlbmFibGUgSERNSSBvdXRwdXQKPiAKPiBPbiB0b3Ag SSBhbHNvIGhhdmUgU2VyZ2VpJ3MvTGF1cmVudCdzOgo+IFtQQVRDSCB2NF0gdjRsOiB2c3AxOiBG aXggdmlkZW8gb3V0cHV0IG9uIFI4QTc3OTcwCj4gCj4gPiBJbiB0aGUgbmV4dCB2ZXJzaW9uIHdv dWxkIHlvdSBjYXJlIHRvIGluY2x1ZGUgdGhlIExWRFMgY29tbWl0IGZyb20gdGhlCj4gPiBkZXBl bmRlbmN5ICBzZXJpZXMgYW5kIHNxdWFzaCB0aGlzIGNoYW5nZSBpbnRvIHRoYXQgb25lIG9yIGlu IHNvbWUgb3RoZXIKPiA+IGdvb2QgbWFuZ2VyIHN0YWNrIHRvIHR3bz8gTGF1cmVudCB0b2xkIG1l IGhlIGRpZCBub3QgbGlrZSA1LzUgaW4gdGhhdAo+ID4gcGF0Y2gtc2V0IGFzIGl0IGRpZCBub3Qg eWV0IGhhdmUgdGhlIExWRFMgZGVjb2RlciBub2RlIGR1ZSB0byBubyBkcml2ZXIKPiA+IGV4aXN0 ZWQgYXQgdGhhdCB0aW1lIHdoZW4gSSBwb3N0ZWQgdGhhdCBldmVuIGlmIGl0J3Mgbm90IHN0cmlj dGx5IG5lZWRlZAo+ID4gdG8gZ2V0IHRoZSBkaXNwbGF5IHdvcmtpbmcgOi0pCj4gCj4gSSdsbCBs ZXQgU2ltb24gc3VnZ2VzdCBob3cgaGUgcHJlZmVyZXMgdG8gaGFuZGxlIHRoaXMsIGlmIGhlIHdh bnRzIG1lCj4gdG8gcmUtc3VibWl0IHlvdXIgc2VyaWVzIHdpdGggdGhpcyBwYXRjaCBzcXVhc2hl ZCBvbiB0b3Agb3IgaGUgcHJlZmVycwo+IHRvIGRlYWwgd2l0aCB0aGlzIGhpbXNlbGYuCj4gCj4g PiBJIGFsc28gdGhpbmsgeW91IHNob3VsZCBzcGxpdCB0aGlzIGxhc3QgcGF0Y2ggb3V0IHRvIGEg c2VwYXJhdGUgc2VyaWVzCj4gPiBhcyBpdCBzaG91bGQgZ28gaW4gU2ltb24ncyB0cmVlIHdoaWxl IHRoZSBkcml2ZXIgYW5kIGRvY3VtZW50YXRpb24gaXMKPiA+IGdvaW5nIGluIGVhcmxpZXIgaW4g YSBkaWZmZXJlbnQgdHJlZSByaWdodD8KPiAKPiBJIGFzc3VtZSBiaW5kaW5ncyBhbmQgZHJpdmVy IGdvIHRocm91Z2ggRFJNIGFuZCBTaW1vbiBpcyB0byBwaWNrIHVwCj4gdGhlIEVhZ2xlIGNoYW5n ZXMuCj4gCj4gPiBPbiBhIHNpZGUgbm90ZSwgZG8geW91IHBsYW4gdG8gdXBkYXRlIHRoZSBHZW4y IGJvYXJkcyBEVFMgZmlsZXMgd2hpY2gKPiA+IGFsc28gaGF2ZSBhIGRlY29kZXIgd2hpY2ggYXJl IG5vdCB5ZXQgZGVzY3JpYmVkIGluIERUPwo+IAo+IEFjdHVhbGx5IEknbSBub3QgYXdhcmUgb2Yg R2VuMiBib2FyZHMgd2l0aCB0aGlzIGNoaXAgYW5kIHNpbWlsYXIKPiBkaXNwbGF5IHBpcGVsaW5l cy4gQ2FuIHlvdSBwb2ludCBtZSB0byB3aGljaCBvbmUgbmVlZHMgdG8gaGF2ZSBpdHMKPiBEVFMg YnJ1c2hlZD8KCkl0J3MgdGhlIExhZ2VyIGJvYXJkLgoKPiA+IE9uIDIwMTgtMDMtMTUgMTc6MTE6 NTYgKzAxMDAsIEphY29wbyBNb25kaSB3cm90ZToKPiA+ID4gVGhlIFItQ2FyIFYzTSBFYWdsZSBi b2FyZCBpbmNsdWRlcyBhIHRyYW5zcGFyZW50IFRIQzYzTFZEMTAyNCBMVkRTCj4gPiA+IGRlY29k ZXIsIGNvbm5lY3RlZCB0byB0aGUgb24tY2hpcCBMVkRTIGVuY29kZXIgb3V0cHV0IG9uIG9uZSBz aWRlCj4gPiA+IGFuZCB0byBIRE1JIGVuY29kZXIgQURWNzUxMXcgb24gdGhlIG90aGVyIG9uZS4K PiA+ID4gCj4gPiA+IEFzIHRoZSBkZWNvZGVyIGRvZXMgbm90IG5lZWQgYW55IGNvbmZpZ3VyYXRp b24gaXQgaGFzIGJlZW4gc28tZmFyCj4gPiA+IG9taXR0ZWQgZnJvbSBEVFMuIE5vdyB0aGF0IGEg ZHJpdmVyIGlzIGF2YWlsYWJsZSwgZGVzY3JpYmUgaXQgaW4gRFQKPiA+ID4gYXMgd2VsbC4KPiA+ ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEphY29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1v bmRpLm9yZz4KPiA+ID4gUmV2aWV3ZWQtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3Vu Zy5jb20+Cj4gPiA+IC0tLQo+ID4gPiAKPiA+ID4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNh cy9yOGE3Nzk3MC1lYWdsZS5kdHMgfCAzMyArKysrKysrKysrKysrKysrLS0tCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+ IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5NzAtZWFnbGUu ZHRzCj4gPiA+IGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTcwLWVhZ2xlLmR0 cyBpbmRleCBjMGZkMTQ0Li42OWY0M2I4Cj4gPiA+IDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2Fy bTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5NzAtZWFnbGUuZHRzCj4gPiA+ICsrKyBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk3MC1lYWdsZS5kdHMKPiA+ID4gQEAgLTQyLDYg KzQyLDMzIEBACj4gPiA+ICAJCQl9Owo+ID4gPiAgCQl9Owo+ID4gPiAgCX07Cj4gPiA+ICsKPiA+ ID4gKwl0aGM2M2x2ZDEwMjQ6IGx2ZHMtZGVjb2RlciB7Cj4gPiA+ICsJCWNvbXBhdGlibGUgPSAi dGhpbmUsdGhjNjNsdmQxMDI0IjsKPiA+ID4gKwo+ID4gPiArCQlwb3J0cyB7Cj4gPiA+ICsJCQkj YWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+ID4gKwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ID4gPiAr Cj4gPiA+ICsJCQlwb3J0QDAgewo+ID4gPiArCQkJCXJlZyA9IDwwPjsKPiA+ID4gKwo+ID4gPiAr CQkJCXRoYzYzbHZkMTAyNF9pbl8wOiBlbmRwb2ludCB7Cj4gPiA+ICsJCQkJCXJlbW90ZS1lbmRw b2ludCA9IDwmbHZkczBfb3V0PjsKPiA+ID4gKwkJCQl9Owo+ID4gPiArCQkJfTsKPiA+ID4gKwo+ ID4gPiArCQkJcG9ydEAyewo+ID4gPiArCQkJCXJlZyA9IDwyPjsKPiA+ID4gKwo+ID4gPiArCQkJ CXRoYzYzbHZkMTAyNF9vdXRfMjogZW5kcG9pbnQgewo+ID4gPiArCQkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JmFkdjc1MTFfaW4+Owo+ID4gPiArCQkJCX07Cj4gPiA+ICsKPiA+ID4gKwkJCX07Cj4g PiA+ICsKPiA+ID4gKwkJfTsKPiA+ID4gKwl9Owo+ID4gPiAgfTsKPiA+ID4gIAo+ID4gPiAgJmF2 YiB7Cj4gPiA+IEBAIC05OCw3ICsxMjUsNyBAQAo+ID4gPiAgCQkJcG9ydEAwIHsKPiA+ID4gIAkJ CQlyZWcgPSA8MD47Cj4gPiA+ICAJCQkJYWR2NzUxMV9pbjogZW5kcG9pbnQgewo+ID4gPiAtCQkJ CQlyZW1vdGUtZW5kcG9pbnQgPSA8Jmx2ZHMwX291dD47Cj4gPiA+ICsJCQkJCXJlbW90ZS1lbmRw b2ludCA9IDwmdGhjNjNsdmQxMDI0X291dF8yPjsKPiA+ID4gIAkJCQl9Owo+ID4gPiAgCQkJfTsK PiA+ID4gCj4gPiA+IEBAIC0xNTIsOCArMTc5LDggQEAKPiA+ID4gCj4gPiA+ICAJcG9ydHMgewo+ ID4gPiAgCQlwb3J0QDEgewo+ID4gPiAtCQkJZW5kcG9pbnQgewo+ID4gPiAtCQkJCXJlbW90ZS1l bmRwb2ludCA9IDwmYWR2NzUxMV9pbj47Cj4gPiA+ICsJCQlsdmRzMF9vdXQ6IGVuZHBvaW50IHsK PiA+ID4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnRoYzYzbHZkMTAyNF9pbl8wPjsKPiA+ID4g IAkJCX07Cj4gPiA+ICAJCX07Cj4gPiA+ICAJfTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==