From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686Ab2IUOV5 (ORCPT ); Fri, 21 Sep 2012 10:21:57 -0400 Received: from forward5h.mail.yandex.net ([84.201.186.23]:59437 "EHLO forward5h.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349Ab2IUOVz (ORCPT ); Fri, 21 Sep 2012 10:21:55 -0400 From: Kirill Tkhai To: "linux-kernel@vger.kernel.org" Cc: Steven Rostedt , Ingo Molnar , Peter Zijlstra In-Reply-To: <668281348234555@web30d.yandex.ru> References: <668281348234555@web30d.yandex.ru> Subject: Re: [PATCH]sched/rt.c: leaf_rt_rq_list contains empty queues. Fix it MIME-Version: 1.0 Message-Id: <742911348237311@web12h.yandex.ru> Date: Fri, 21 Sep 2012 18:21:51 +0400 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Second version. Add every not empty queue once. The patch: Function __enqueue_rt_entity() adds an empty queue to leaf_rt_rq_list. So, pick_next_highest_task_rt() picks empty queues. Fix it. Signed-off-by: Kirill Tkhai --- kernel/sched/rt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 944cb68..97a0954 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1103,7 +1103,7 @@ static void __enqueue_rt_entity(struct sched_rt_entity *rt_se, bool head) if (group_rq && (rt_rq_throttled(group_rq) || !group_rq->rt_nr_running)) return; - if (!rt_rq->rt_nr_running) + if (rt_rq->rt_nr_running == 1) list_add_leaf_rt_rq(rt_rq); if (head)