From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE0C1C4828D for ; Wed, 7 Feb 2024 07:20:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.677261.1053750 (Exim 4.92) (envelope-from ) id 1rXcE2-0003l3-IX; Wed, 07 Feb 2024 07:20:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 677261.1053750; Wed, 07 Feb 2024 07:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rXcE2-0003kw-Ce; Wed, 07 Feb 2024 07:20:06 +0000 Received: by outflank-mailman (input) for mailman id 677261; Wed, 07 Feb 2024 07:20:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rXcE1-0003PF-5b for xen-devel@lists.xenproject.org; Wed, 07 Feb 2024 07:20:05 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f714469-c589-11ee-8a49-1f161083a0e0; Wed, 07 Feb 2024 08:20:03 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40fe59b22dbso2077435e9.3 for ; Tue, 06 Feb 2024 23:20:03 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id bl13-20020adfe24d000000b0033b39cba5e4sm733640wrb.116.2024.02.06.23.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 23:20:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f714469-c589-11ee-8a49-1f161083a0e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707290402; x=1707895202; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dsqIjtdJvYnDqXUdFBSMbduiUGYGKQ1mhaQP04o58Tc=; b=XomLSKWkxd1SpHezyzkMeWFwujpUsFMXITAv7YmCqrrYeIZ01jWkqyJ6tCRhHB+dXX 55MYr0vC+gAp0GpuCRzPryVH6bXmUp8y2iMyBR15AYMkwiF/h/HPvls5YtjlE7Nk3S1f dq6C6h3GGEIVAC51A9J54oqAcJaemZsEJjv8IOAriTQiCP+3i8wdu1d95nXHL0JgCse2 aWGUYW8MGLk/dPpjxxRJ+vtHEKUIiW04pjVMbIPgeRSMxND5YZ/i77YmM1GjR2qXiBNE 5VsH2Ejtn+MzC1Gv6su2CikfJjm/vLSru91aJfx6GNXXBVC9vtSA/iUcfdzdC/IguOgm teng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707290402; x=1707895202; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dsqIjtdJvYnDqXUdFBSMbduiUGYGKQ1mhaQP04o58Tc=; b=V5E1qISHDdg668WwT54FZn6rDNrAh6Hc8y3tmy6UkE7nyMcDDe73KX2YM23pzXFT+f 2vWKmx+zHJBxXFCLCMWUSbgXhpTLDIUceFzA2HBnrfjJhYeEqKTSPdPwicuDC7WppC/p 1Bv/uh8VGuUR7eL2iSB/iZHp0JG762ITYHpedK8136CZia6Djl1YVbBFUWInZpM8mP/w eqTIUuxNi0mq9NkKZmEKe2vrGtoz1hRVODVgbVqMuh9eF8wU1zfkyRW44PACd69p2G7O uf/tYmuB9ON6ud9Unf9CEMCJI8U1LP7sBpzPjBWWIRzEj6z6dtrb1B1Ac34mD5sn5NV3 lWrA== X-Gm-Message-State: AOJu0Yx+sEojKCvRG3KM42362Xnqf5nd2WH4yqELzO+fySNljclqFCGH KYH/YPtiJKT+hoZL9pdAEEp6Ocw6jZr12sbvMrGfXJrNJQcTX4LjQYJ+Fswkdg== X-Google-Smtp-Source: AGHT+IFcpg0VM145aEdMVYTIcloClLOv/UjrIDtDOAG91vYxrgMpKXzsHjMR2DJZRCT2NS+S/4HIOQ== X-Received: by 2002:a5d:5349:0:b0:33b:4d13:30a1 with SMTP id t9-20020a5d5349000000b0033b4d1330a1mr859313wrv.2.1707290402551; Tue, 06 Feb 2024 23:20:02 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV24P5J20ieH0txA7sN6eEEXGwRT3nD/+ghLEH9d022U0+YJ+wTsKhMMugS7+0pvVZvLFmo9si8GH9iUDCyQYI/ErDGjc4uXZYUxYmEd3lNZkBlRWZVzhR6CKpAO4Skpx3ie8cOADWk5mNsKY637l8yvRkQDKdTK8VgVytnSwnUt3CQyYwWkPwQNRsjN2jnjN2iyVh0PMvAP37p5Mc/5ejNT7rFk8bn3nv89Fvp/9ttfQBcRP1RU37yQVADsXC8YfSX33kjkls2E7eK8EAaaWl+k0JKJ56/X9LP Message-ID: <743801de-1fe2-4575-9987-a9fbf80afdb9@suse.com> Date: Wed, 7 Feb 2024 08:20:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] x86/IOMMU: address violations of MISRA C:2012 Rule 14.4 Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Maria Celeste Cesario , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Kevin Tian , Simone Ballarin References: <746a33fff1386b2e76657b5f7cfb31f3b117a1fe.1702310368.git.maria.celeste.cesario@bugseng.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07.02.2024 01:51, Stefano Stabellini wrote: > On Wed, 13 Dec 2023, Simone Ballarin wrote: >> From: Maria Celeste Cesario >> >> The xen sources contain violations of MISRA C:2012 Rule 14.4 whose >> headline states: >> "The controlling expression of an if statement and the controlling >> expression of an iteration-statement shall have essentially Boolean type". >> >> Add comparisons to avoid using enum constants as controlling expressions >> to comply with Rule 14.4. >> No functional change. >> >> Signed-off-by: Maria Celeste Cesario >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini > > However it needs an ack from an x86 maintainer And from respective IOMMU ones. Jan