From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/5] app/test: rework crypto AES unit test Date: Tue, 07 Jun 2016 22:03:51 +0200 Message-ID: <7438899.qkiIA9Ph5u@xps13> References: <1464685789-8386-1-git-send-email-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, declan.doherty@intel.com To: Fan Zhang Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 21C21AD93 for ; Tue, 7 Jun 2016 22:03:53 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id m124so129050891wme.1 for ; Tue, 07 Jun 2016 13:03:53 -0700 (PDT) In-Reply-To: <1464685789-8386-1-git-send-email-roy.fan.zhang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-31 10:09, Fan Zhang: > Fan Zhang (5): > app/test: categorize crypto AES test vectors into new file > app/test: add unified crypto aes test > app/test: utilize new unified crypto AES test function The first three patches have no real meaning separately. As they move and rework some code, it is better to not split with some patches which add code from nowhere and others which remove old code. Please squash. Clang throw an error for the second patch. The file permissions are wrong for the new files. > app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit > tests > examples/l2fwd-crypto: enable AES counter mode cipher algorithm The fifth patch is already applied from another patchset.