From: hooanon05@yahoo.co.jp
To: Hugh Dickins <hugh@veritas.com>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
Andrew Morton <akpm@linux-foundation.org>,
mhalcrow@us.ibm.com, hch@infradead.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsstack: fsstack_copy_inode_size locking
Date: Mon, 30 Jun 2008 22:08:12 +0900 [thread overview]
Message-ID: <7439.1214831292@jrobl> (raw)
In-Reply-To: <Pine.LNX.4.64.0806301238080.6538@blonde.site>
Hugh Dickins:
> It certainly shouldn't be. The problem would have come from two
> racing i_size_write(dst)s, one of the unlocked increments getting
> lost, leaving seqcount odd, so the next i_size_read(dst) would
> spin forever waiting for it to go even.
I see.
The unlocked increment can cause the next i_size_read() hang.
> I'm not sure what you mean by that. i_size_read() doesn't fail,
> but it may loop; and if the seqcount has got out of step from
> concurrent unlocked i_size_write()s, then it'll spin forever.
What I meant by "fail" was "loop" actually.
And I understand that you didn't writing directly (bypassing unionfs)
too.
Junjiro Okajima
prev parent reply other threads:[~2008-06-30 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 0:05 [PATCH] fsstack: fsstack_copy_inode_size locking Hugh Dickins
2008-06-29 0:07 ` [PATCH] unionfs: fix memory leak Hugh Dickins
2008-06-30 18:11 ` Erez Zadok
2008-06-29 7:15 ` [PATCH] fsstack: fsstack_copy_inode_size locking Christoph Hellwig
2008-06-29 11:56 ` Hugh Dickins
2008-06-30 18:19 ` Erez Zadok
2008-06-30 21:49 ` Michael Halcrow
2008-07-01 7:03 ` Christoph Hellwig
2008-07-02 0:00 ` Erez Zadok
2008-06-30 4:31 ` hooanon05
2008-06-30 12:10 ` Hugh Dickins
2008-06-30 13:08 ` hooanon05 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7439.1214831292@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.