From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F651C54E60 for ; Tue, 19 Mar 2024 04:34:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ZTAFK3kI; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TzJly1zk3z3cL0 for ; Tue, 19 Mar 2024 15:34:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ZTAFK3kI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=2001:41d0:203:375::ad; helo=out-173.mta1.migadu.com; envelope-from=muchun.song@linux.dev; receiver=lists.ozlabs.org) X-Greylist: delayed 422 seconds by postgrey-1.37 at boromir; Tue, 19 Mar 2024 15:33:53 AEDT Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [IPv6:2001:41d0:203:375::ad]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TzJl52js3z3cDT for ; Tue, 19 Mar 2024 15:33:52 +1100 (AEDT) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710822380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgOYrA8AEdh1woTHtD2vW3ca3PCtrZkdcZD77qbWikM=; b=ZTAFK3kIV8AKtSNFLFj4r5t0E2RLRk79ahMgFgMUh3jepMgCaS/mVJWw+RNCCrBHBN52gG NXM8ti3nDdYB1W5KBlYW6GIieZZXNfTfpKEBYqCv/yKV1dd9Ool2dQxzcp3DvEWHCDX49h rpX1jczrZg5j7IQxr3uyYzwVPdmEh3E= Mime-Version: 1.0 Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240318200404.448346-6-peterx@redhat.com> Date: Tue, 19 Mar 2024 12:25:39 +0800 Content-Transfer-Encoding: quoted-printable Message-Id: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> To: Peter Xu X-Migadu-Flow: FLOW_OUT X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Andreas Larsson , x86@kernel.org, LKML , Matthew Wilcox , Linux-MM , Jason Gunthorpe , sparclinux@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > On Mar 19, 2024, at 04:03, peterx@redhat.com wrote: >=20 > From: Peter Xu >=20 > Please refer to the previous patch on the reasoning for x86. Now = sparc is > the only architecture that will allow swap entries to be reported as > pXd_huge(). After this patch, all architectures should forbid swap = entries > in pXd_huge(). >=20 > Cc: David S. Miller > Cc: Andreas Larsson > Cc: sparclinux@vger.kernel.org > Signed-off-by: Peter Xu > --- > arch/sparc/mm/hugetlbpage.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index b432500c13a5..d31c2cec35c9 100644 > --- a/arch/sparc/mm/hugetlbpage.c > +++ b/arch/sparc/mm/hugetlbpage.c > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct = *mm, unsigned long addr, >=20 > int pmd_huge(pmd_t pmd) > { > - return !pmd_none(pmd) && > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) !=3D _PAGE_VALID; > + return pmd_leaf(pmd);; There is a redundant semicolon in the end. Thanks. > } >=20 > int pud_huge(pud_t pud) > { > - return !pud_none(pud) && > - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) !=3D _PAGE_VALID; > + return pud_leaf(pud); > } >=20 > static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, > --=20 > 2.44.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C887C0BA for ; Tue, 19 Mar 2024 04:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710822385; cv=none; b=Z/rV94LYpiqL90J2bTZrgi1u5KphNUqI4g06mJMZBjj2OdAmVqrFRgA/Ll603RKLFbPpUNRA9eZN5m+li77VzqwfjPgnXGLuaF9UF5R7AiNIzv8GKcNLozhm+hmtGjam0QAdFazSkTiB+7t8czAi5+CJnDfwHuHrxbHStfENN1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710822385; c=relaxed/simple; bh=u02e9JnhtgF01wLoGi9eloHZoYbmUfQfrlrPML9EgIU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=cle0ksoDIVzfWipJbcrtfa1Tk8/CgrWniYHNEhc0xlQkeLs/aWqcovVWBvJS4HEd0Ruy1RPgI4522tT3fHgUQXXrj4JwcOF2sP7NlZnirTkuAkJUe+wzTMgl1Vy7KNyP5csC1sTOwtmBUeenKN/MWRF6VIafmJWJBucEiigd87c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZTAFK3kI; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZTAFK3kI" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710822380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgOYrA8AEdh1woTHtD2vW3ca3PCtrZkdcZD77qbWikM=; b=ZTAFK3kIV8AKtSNFLFj4r5t0E2RLRk79ahMgFgMUh3jepMgCaS/mVJWw+RNCCrBHBN52gG NXM8ti3nDdYB1W5KBlYW6GIieZZXNfTfpKEBYqCv/yKV1dd9Ool2dQxzcp3DvEWHCDX49h rpX1jczrZg5j7IQxr3uyYzwVPdmEh3E= Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240318200404.448346-6-peterx@redhat.com> Date: Tue, 19 Mar 2024 12:25:39 +0800 Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Content-Transfer-Encoding: quoted-printable Message-Id: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> To: Peter Xu X-Migadu-Flow: FLOW_OUT > On Mar 19, 2024, at 04:03, peterx@redhat.com wrote: >=20 > From: Peter Xu >=20 > Please refer to the previous patch on the reasoning for x86. Now = sparc is > the only architecture that will allow swap entries to be reported as > pXd_huge(). After this patch, all architectures should forbid swap = entries > in pXd_huge(). >=20 > Cc: David S. Miller > Cc: Andreas Larsson > Cc: sparclinux@vger.kernel.org > Signed-off-by: Peter Xu > --- > arch/sparc/mm/hugetlbpage.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index b432500c13a5..d31c2cec35c9 100644 > --- a/arch/sparc/mm/hugetlbpage.c > +++ b/arch/sparc/mm/hugetlbpage.c > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct = *mm, unsigned long addr, >=20 > int pmd_huge(pmd_t pmd) > { > - return !pmd_none(pmd) && > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) !=3D _PAGE_VALID; > + return pmd_leaf(pmd);; There is a redundant semicolon in the end. Thanks. > } >=20 > int pud_huge(pud_t pud) > { > - return !pud_none(pud) && > - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) !=3D _PAGE_VALID; > + return pud_leaf(pud); > } >=20 > static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, > --=20 > 2.44.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04E03C54E5D for ; Tue, 19 Mar 2024 04:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IER4g6mWFXiP6StnqKk2ezhCw+dgMwAUXS/cPvnmS8o=; b=FRLVivv+sDPgZc lwKGAS827thTli8NG+GmBiRL9oJsNy8VZgCtaN01q9xZNOAwnwGQ98MD1RNsL3moDKz7KuYlk1L4f In6kvSfz/FIp0A0WeJ/vWlEHYO7WAi/e6M/wwC/pS1lFNdLpRdpgiy1Mi0m+6FrAvlad7EFOSbjCW uS5jpi4mzU+Dc2BFJdkO/GNEXxChzMtJioXuumwKZNtm0n0IZy9kP3U6ZvmV1OL3kBf/NJam38B9c pjZA3WADtagIEB5lif1MrmYe/XBmpk6E75v2JgiUeIBwh+XPTqnUXytVIANTnKUNwRSaoK+aVJUrj DciJVlFd+1qhGvd/CO2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmR3W-0000000BCwk-1mHM; Tue, 19 Mar 2024 04:26:30 +0000 Received: from out-174.mta1.migadu.com ([2001:41d0:203:375::ae]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmR3S-0000000BCvU-3ESN for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 04:26:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710822380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgOYrA8AEdh1woTHtD2vW3ca3PCtrZkdcZD77qbWikM=; b=ZTAFK3kIV8AKtSNFLFj4r5t0E2RLRk79ahMgFgMUh3jepMgCaS/mVJWw+RNCCrBHBN52gG NXM8ti3nDdYB1W5KBlYW6GIieZZXNfTfpKEBYqCv/yKV1dd9Ool2dQxzcp3DvEWHCDX49h rpX1jczrZg5j7IQxr3uyYzwVPdmEh3E= Mime-Version: 1.0 Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240318200404.448346-6-peterx@redhat.com> Date: Tue, 19 Mar 2024 12:25:39 +0800 Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Message-Id: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> To: Peter Xu X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_212627_253259_83CA3F2F X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Mar 19, 2024, at 04:03, peterx@redhat.com wrote: > > From: Peter Xu > > Please refer to the previous patch on the reasoning for x86. Now sparc is > the only architecture that will allow swap entries to be reported as > pXd_huge(). After this patch, all architectures should forbid swap entries > in pXd_huge(). > > Cc: David S. Miller > Cc: Andreas Larsson > Cc: sparclinux@vger.kernel.org > Signed-off-by: Peter Xu > --- > arch/sparc/mm/hugetlbpage.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index b432500c13a5..d31c2cec35c9 100644 > --- a/arch/sparc/mm/hugetlbpage.c > +++ b/arch/sparc/mm/hugetlbpage.c > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > > int pmd_huge(pmd_t pmd) > { > - return !pmd_none(pmd) && > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; > + return pmd_leaf(pmd);; There is a redundant semicolon in the end. Thanks. > } > > int pud_huge(pud_t pud) > { > - return !pud_none(pud) && > - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) != _PAGE_VALID; > + return pud_leaf(pud); > } > > static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, > -- > 2.44.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel