From: Jens Axboe <axboe@kernel.dk>
To: Greg Edwards <gedwards@ddn.com>, linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: bvec_nr_vecs() returns value for wrong slab
Date: Thu, 9 Aug 2018 08:28:29 -0600 [thread overview]
Message-ID: <744cd24e-de0b-30b4-e0e2-e1570d0f80e1@kernel.dk> (raw)
In-Reply-To: <20180808192753.817-1-gedwards@ddn.com>
On 8/8/18 1:27 PM, Greg Edwards wrote:
> In commit ed996a52c868 ("block: simplify and cleanup bvec pool
> handling"), the value of the slab index is incremented by one in
> bvec_alloc() after the allocation is done to indicate an index value of
> 0 does not need to be later freed.
>
> bvec_nr_vecs() was not updated accordingly, and thus returns the wrong
> value. Decrement idx before performing the lookup.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-08-09 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 19:27 [PATCH] block: bvec_nr_vecs() returns value for wrong slab Greg Edwards
2018-08-09 14:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744cd24e-de0b-30b4-e0e2-e1570d0f80e1@kernel.dk \
--to=axboe@kernel.dk \
--cc=gedwards@ddn.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.