From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] ring: build with global includes
Date: Mon, 21 Nov 2022 22:36:24 +0100 [thread overview]
Message-ID: <7452459.EvYhyI6sBW@thomas> (raw)
In-Reply-To: <d8b89ca6dee54e508cc8d3addd022d81@huawei.com>
21/11/2022 22:27, Konstantin Ananyev:
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > e.g. i don't see.
> >
> > deps += ['eal']
> >
> > is the dependency on eal the library or just eal headers? because if it
> > is header only it is equivalent to telemetry i think?
>
> rte_ring.c uses bunch of EAL functions:
> rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc.
I think deps += ['eal'] is missing in ring meson file.
next prev parent reply other threads:[~2022-11-21 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 23:22 [PATCH] ring: build with global includes Tyler Retzlaff
2022-11-18 23:22 ` Tyler Retzlaff
2022-11-21 10:31 ` Bruce Richardson
2022-11-21 19:53 ` Tyler Retzlaff
2022-11-21 21:27 ` Konstantin Ananyev
2022-11-21 21:36 ` Thomas Monjalon [this message]
2022-11-21 22:48 ` Tyler Retzlaff
2022-11-22 8:51 ` David Marchand
2022-11-22 9:17 ` Bruce Richardson
2022-11-22 16:22 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7452459.EvYhyI6sBW@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.