All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edgar Bonet via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Cc: Jesse Van Gavere <jesseevg@gmail.com>,
	Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/qt6/qt6declarative: move comment where it belongs
Date: Wed, 26 Aug 2026 16:35:19 +0200	[thread overview]
Message-ID: <7458079d-fecc-4bf1-94ed-e428e4d1bf82@grenoble.cnrs.fr> (raw)
In-Reply-To: <20260826142830.4040428-1-thomas.petazzoni@bootlin.com>

Hello Thomas, all,

On 2026-08-26, Thomas Petazzoni wrote:
> The commit "Enable host test module to ensure that qmltestrunner is

s/commit/comment/

Regards,

Edgar.

> built" in qt6declarative's Config.in feels lonely under
> BR2_PACKAGE_QT6DECLARATIVE. It's because it's actually related to a
> select done in the sub-option BR2_PACKAGE_QT6DECLARATIVE_QUICK, so
> move it there.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/qt6/qt6declarative/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/qt6/qt6declarative/Config.in b/package/qt6/qt6declarative/Config.in
> index 0a977ed808..a57b203071 100644
> --- a/package/qt6/qt6declarative/Config.in
> +++ b/package/qt6/qt6declarative/Config.in
> @@ -1,6 +1,5 @@
>  config BR2_PACKAGE_QT6DECLARATIVE
>  	bool "qt6declarative"
> -	# Enable host test module to ensure that qmltestrunner is built
>  	help
>  	  Qt is a cross-platform application and UI framework for
>  	  developers using C++.
> @@ -13,6 +12,7 @@ if BR2_PACKAGE_QT6DECLARATIVE
>  
>  config BR2_PACKAGE_QT6DECLARATIVE_QUICK
>  	bool "quick module"
> +	# Enable host test module to ensure that qmltestrunner is built
>  	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
>  	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
>  	select BR2_PACKAGE_QT6BASE_GUI

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-08-26 14:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 14:28 [Buildroot] [PATCH 1/2] package/qt6/qt6declarative: move comment where it belongs Thomas Petazzoni via buildroot
2026-08-26 14:28 ` [Buildroot] [PATCH 2/2] package/qt6/qt6declarative: fix select of host-qt6base network Thomas Petazzoni via buildroot
2026-09-04 12:18   ` Thomas Perale via buildroot
2026-08-26 14:35 ` Edgar Bonet via buildroot [this message]
2026-08-27 19:27 ` [Buildroot] [PATCH 1/2] package/qt6/qt6declarative: move comment where it belongs Julien Olivain via buildroot
2026-09-04 12:18 ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7458079d-fecc-4bf1-94ed-e428e4d1bf82@grenoble.cnrs.fr \
    --to=buildroot@buildroot.org \
    --cc=bonet@grenoble.cnrs.fr \
    --cc=jesseevg@gmail.com \
    --cc=roykollensvendsen@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.