From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:39258 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbeLDSMk (ORCPT ); Tue, 4 Dec 2018 13:12:40 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Kieran Bingham Subject: Re: [PATCH v2] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency Date: Tue, 04 Dec 2018 20:13:10 +0200 Message-ID: <7465409.qeCXr2vvpE@avalon> In-Reply-To: References: <20181204163640.316-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Tuesday, 4 December 2018 19:30:25 EET Geert Uytterhoeven wrote: > On Tue, Dec 4, 2018 at 5:36 PM Laurent Pinchart wrote: > > Implement a .mode_valid() handler in the R-Car glue layer to reject > > modes with an unsupported clock frequency. > > > > Signed-off-by: Laurent Pinchart > > > > Thanks for your patch! > > > --- a/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c > > @@ -35,6 +35,20 @@ static const struct rcar_hdmi_phy_params > > rcar_hdmi_phy_params[] = { > > { ~0UL, 0x0000, 0x0000, 0x0000 }, > > }; > > > > +static enum drm_mode_status > > +rcar_hdmi_mode_valid(struct drm_connector *connector, > > + const struct drm_display_mode *mode) > > +{ > > + /* > > + * The maximum supported clock frequency is 297 MHz, as shown in > > the PHY + * parameters table. > > + */ > > + if (mode->clock > 297000) > > + return MODE_CLOCK_HIGH; > > Perhaps you need a check for the lower limit (25 MHz), too? There's no lower limit implied by the rcar_hdmi_phy_params table. > > + > > + return MODE_OK; > > +} -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency Date: Tue, 04 Dec 2018 20:13:10 +0200 Message-ID: <7465409.qeCXr2vvpE@avalon> References: <20181204163640.316-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 364796E2E6 for ; Tue, 4 Dec 2018 18:12:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Linux-Renesas , Laurent Pinchart , Kieran Bingham , DRI Development List-Id: dri-devel@lists.freedesktop.org SGkgR2VlcnQsCgpPbiBUdWVzZGF5LCA0IERlY2VtYmVyIDIwMTggMTk6MzA6MjUgRUVUIEdlZXJ0 IFV5dHRlcmhvZXZlbiB3cm90ZToKPiBPbiBUdWUsIERlYyA0LCAyMDE4IGF0IDU6MzYgUE0gTGF1 cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEltcGxlbWVudCBhIC5tb2RlX3ZhbGlkKCkgaGFuZGxl ciBpbiB0aGUgUi1DYXIgZ2x1ZSBsYXllciB0byByZWplY3QKPiA+IG1vZGVzIHdpdGggYW4gdW5z dXBwb3J0ZWQgY2xvY2sgZnJlcXVlbmN5Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50 IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+ Cj4gCj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoIQo+IAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L3JjYXItZHUvcmNhcl9kd19oZG1pLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHdfaGRtaS5jCj4gPiBAQCAtMzUsNiArMzUsMjAgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCByY2FyX2hkbWlfcGh5X3BhcmFtcwo+ID4gcmNhcl9oZG1pX3BoeV9wYXJhbXNbXSA9IHsKPiA+ ICAgICAgICAgeyB+MFVMLCAgICAgIDB4MDAwMCwgMHgwMDAwLCAweDAwMDAgfSwKPiA+ICB9Owo+ ID4gCj4gPiArc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzCj4gPiArcmNhcl9oZG1pX21vZGVf dmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICsgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ID4gK3sKPiA+ICsg ICAgICAgLyoKPiA+ICsgICAgICAgICogVGhlIG1heGltdW0gc3VwcG9ydGVkIGNsb2NrIGZyZXF1 ZW5jeSBpcyAyOTcgTUh6LCBhcyBzaG93biBpbgo+ID4gdGhlIFBIWSArICAgICAgICAqIHBhcmFt ZXRlcnMgdGFibGUuCj4gPiArICAgICAgICAqLwo+ID4gKyAgICAgICBpZiAobW9kZS0+Y2xvY2sg PiAyOTcwMDApCj4gPiArICAgICAgICAgICAgICAgcmV0dXJuIE1PREVfQ0xPQ0tfSElHSDsKPiAK PiBQZXJoYXBzIHlvdSBuZWVkIGEgY2hlY2sgZm9yIHRoZSBsb3dlciBsaW1pdCAoMjUgTUh6KSwg dG9vPwoKVGhlcmUncyBubyBsb3dlciBsaW1pdCBpbXBsaWVkIGJ5IHRoZSByY2FyX2hkbWlfcGh5 X3BhcmFtcyB0YWJsZS4KCj4gPiArCj4gPiArICAgICAgIHJldHVybiBNT0RFX09LOwo+ID4gK30K Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK