All of lore.kernel.org
 help / color / mirror / Atom feed
From: ROUSSILLE Hector <hroussille@adeneo-embedded.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Adding support for directFB to mplayer2 recipe
Date: Wed, 27 May 2015 13:41:30 +0200 (CEST)	[thread overview]
Message-ID: <746866001.144064.1432726890076.JavaMail.zimbra@adeneo-embedded.com> (raw)
In-Reply-To: <5565AC43.6070406@mlbassoc.com>

I Thought the PACKAGECONFIG option was enough, well that's the answer i had on the IRC 


De: "Gary Thomas" <gary@mlbassoc.com> 
À: openembedded-devel@lists.openembedded.org 
Envoyé: Mercredi 27 Mai 2015 13:36:35 
Objet: Re: [oe] [PATCH] Adding support for directFB to mplayer2 recipe 

On 2015-05-27 05:13, Hector Roussille wrote: 
> Signed-off-by: Hector Roussille <hroussille@adeneo-embedded.com> 
> --- 
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++- 
> 1 file changed, 2 insertions(+), 1 deletion(-) 
> 
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> index 5b0e1de..b208144 100644 
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> @@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc" 
> PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis" 
> PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19" 
> PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123" 
> +PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb" 
> 
> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math" 
> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}" 
> @@ -134,7 +135,7 @@ do_configure() { 
> sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure 
> sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure 
> sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile 
> - 
> + sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure 
> export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)" 
> ./configure ${EXTRA_OECONF} 
> 

Shouldn't this at least be conditional on directfb support in 
DISTRO_FEATURES? It won't do much good to enable it in this 
recipe if the rest of the system isn't using directfb as well. 

-- 
------------------------------------------------------------ 
Gary Thomas | Consulting for the 
MLB Associates | Embedded world 
------------------------------------------------------------ 
-- 
_______________________________________________ 
Openembedded-devel mailing list 
Openembedded-devel@lists.openembedded.org 
http://lists.openembedded.org/mailman/listinfo/openembedded-devel 


  reply	other threads:[~2015-05-27 11:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 11:13 [PATCH] Adding support for directFB to mplayer2 recipe Hector Roussille
2015-05-27 11:36 ` Gary Thomas
2015-05-27 11:41   ` ROUSSILLE Hector [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-27  8:34 Hector Roussille
2015-05-27 10:35 ` Martin Jansa
2015-05-27  7:41 Hector Roussille
2015-05-27  7:52 ` Jussi Kukkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=746866001.144064.1432726890076.JavaMail.zimbra@adeneo-embedded.com \
    --to=hroussille@adeneo-embedded.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.