All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Cagnin <fcagnin@quarkslab.com>
To: Alexander Graf <graf@amazon.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, qemu-arm@nongnu.org,
	"Cameron Esfahani" <dirty@apple.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Bernhard Beschow" <shentey@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2 12/12] hw/vmapple/vmapple: Add vmapple machine type
Date: Thu, 12 Oct 2023 13:46:58 +0200	[thread overview]
Message-ID: <746bf183-d805-4e0d-8c5e-e989c5f46823@quarkslab.com> (raw)
In-Reply-To: <20230830161425.91946-13-graf@amazon.com>

Hi Alexander,

awesome work, thanks!

I don't know if it's the most appropriate fix but to have the patch series
working I had to add `select VMAPPLE_VIRTIO_BLK` to `hw/vmapple/Kconfig`:

 >  config VMAPPLE
 >      bool
 >      depends on ARM && HVF
 >      default y if ARM && HVF
 >      imply PCI_DEVICES
 >      select ARM_GIC
 >      select PLATFORM_BUS
 >      select PCI_EXPRESS
 >      select PCI_EXPRESS_GENERIC_BRIDGE
 >      select PL011 # UART
 >      select PL031 # RTC
 >      select PL061 # GPIO
 >      select GPIO_PWR
 >      select PVPANIC_MMIO
 >      select VMAPPLE_AES
 >      select VMAPPLE_BDIF
 >      select VMAPPLE_CFG
 >      select VMAPPLE_PVG
 > +    select VMAPPLE_VIRTIO_BLK

Otherwise QEMU raises the error `'vmapple-virtio-root' is not a valid device
model name`.

Francesco


      parent reply	other threads:[~2023-10-12 13:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 16:14 [PATCH v2 00/12] Introduce new vmapple machine type Alexander Graf
2023-08-30 16:14 ` [PATCH v2 01/12] build: Only define OS_OBJECT_USE_OBJC with gcc Alexander Graf
2023-08-31  8:12   ` Philippe Mathieu-Daudé
2023-08-31  8:53     ` Akihiko Odaki
2023-08-31  8:59       ` Alexander Graf
2023-08-31 10:45         ` Akihiko Odaki
2023-08-30 16:14 ` [PATCH v2 02/12] hw/misc/pvpanic: Add MMIO interface Alexander Graf
2023-09-01  5:19   ` Mark Cave-Ayland
2023-08-30 16:14 ` [PATCH v2 03/12] hvf: Increase number of possible memory slots Alexander Graf
2023-08-30 16:14 ` [PATCH v2 04/12] hvf: arm: Ignore writes to CNTP_CTL_EL0 Alexander Graf
2023-08-31  8:13   ` Philippe Mathieu-Daudé
2023-08-30 16:14 ` [PATCH v2 05/12] hw: Add vmapple subdir Alexander Graf
2023-08-30 16:14 ` [PATCH v2 06/12] gpex: Allow more than 4 legacy IRQs Alexander Graf
2023-08-30 16:14 ` [PATCH v2 07/12] hw/vmapple/aes: Introduce aes engine Alexander Graf
2023-09-01  5:34   ` Mark Cave-Ayland
2023-08-30 16:14 ` [PATCH v2 08/12] hw/vmapple/bdif: Introduce vmapple backdoor interface Alexander Graf
2023-08-31 19:46   ` Stefan Hajnoczi
2023-09-01  5:40   ` Mark Cave-Ayland
2023-08-30 16:14 ` [PATCH v2 09/12] hw/vmapple/cfg: Introduce vmapple cfg region Alexander Graf
2023-09-01  5:46   ` Mark Cave-Ayland
2023-08-30 16:14 ` [PATCH v2 10/12] hw/vmapple/apple-gfx: Introduce ParavirtualizedGraphics.Framework support Alexander Graf
2023-09-23 21:04   ` Phil Dennis-Jordan
2023-08-30 16:14 ` [PATCH v2 11/12] hw/vmapple/virtio-blk: Add support for apple virtio-blk Alexander Graf
2023-08-31 20:03   ` Stefan Hajnoczi
2023-08-31 20:34     ` Philippe Mathieu-Daudé
2023-09-01  6:53   ` Mark Cave-Ayland
2023-08-30 16:14 ` [PATCH v2 12/12] hw/vmapple/vmapple: Add vmapple machine type Alexander Graf
2023-09-01  7:07   ` Mark Cave-Ayland
2023-10-12 11:46   ` Francesco Cagnin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=746bf183-d805-4e0d-8c5e-e989c5f46823@quarkslab.com \
    --to=fcagnin@quarkslab.com \
    --cc=berrange@redhat.com \
    --cc=dirty@apple.com \
    --cc=graf@amazon.com \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mads@ynddal.dk \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shentey@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.