From: Lance Richardson <lrichard@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net] vxlan: eliminate cached dst leak
Date: Thu, 1 Jun 2017 15:07:08 -0400 (EDT) [thread overview]
Message-ID: <748426696.17969649.1496344028160.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170601.144648.1946518537495893731.davem@davemloft.net>
> From: "David Miller" <davem@davemloft.net>
> To: lrichard@redhat.com
> Cc: netdev@vger.kernel.org, pabeni@redhat.com
> Sent: Thursday, 1 June, 2017 2:46:48 PM
> Subject: Re: [PATCH net] vxlan: eliminate cached dst leak
>
> From: Lance Richardson <lrichard@redhat.com>
> Date: Mon, 29 May 2017 13:25:57 -0400
>
> > After commit 0c1d70af924b ("net: use dst_cache for vxlan device"),
> > cached dst entries could be leaked when more than one remote was
> > present for a given vxlan_fdb entry, causing subsequent netns
> > operations to block indefinitely and "unregister_netdevice: waiting
> > for lo to become free." messages to appear in the kernel log.
> >
> > Fix by properly releasing cached dst and freeing resources in this
> > case.
> >
> > Fixes: commit 0c1d70af924b ("net: use dst_cache for vxlan device")
>
> In the future please do not put that "commit " string there, it's not
> needed.
Oops, sorry about that, I know I've made that mistake before (both times
because a checkpatch.pl warning in the body made me think I needed to
change the Fixes: tag as well). Now I'm tempted to roll a checkpatch.pl
improvement...
>
> > Signed-off-by: Lance Richardson <lrichard@redhat.com>
>
> Applied and queued up for -stable, thank you.
>
prev parent reply other threads:[~2017-06-01 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 17:25 [PATCH net] vxlan: eliminate cached dst leak Lance Richardson
2017-05-30 8:34 ` Paolo Abeni
2017-05-31 15:48 ` Lance Richardson
2017-06-01 18:46 ` David Miller
2017-06-01 19:07 ` Lance Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748426696.17969649.1496344028160.JavaMail.zimbra@redhat.com \
--to=lrichard@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.