From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: jean.tourrilhes@hpe.com
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
olivier.matz@6wind.com, David Hunt <david.hunt@intel.com>
Subject: Re: [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs
Date: Wed, 05 Oct 2016 19:09:14 +0200 [thread overview]
Message-ID: <7491622.GqnA43pcBO@xps13> (raw)
In-Reply-To: <20161005164906.GB11912@labs.hpe.com>
2016-10-05 09:49, Jean Tourrilhes:
> On Wed, Oct 05, 2016 at 09:58:01AM +0200, David Marchand wrote:
> > I thought you had unaligned binaries.
> > You are compiling only one binary ?
>
> Primary is compiled using the DPDK build process.
> Secondary is build using the Snort build process.
> Both are pointing to the exact same libdpdk.a.
Probably that you would have some aligned builds if Snort was using
a pkg-config approach to link DPDK.
I cannot commit but I would like to generate some pkg-config files
in the DPDK build system to ease linking from external applications.
> > I am not sure Sergio is talking about the constructor approach.
>
> But, this is exactly the cause of the problem.
>
> > Anyway, the constructors invocation order should not matter.
>
> For tailq, I agree. For mempool constructors, order do matter.
I don't know why such a complex function (rte_mempool_register_ops) is
called inside a constructor. Maybe that's the main problem.
next prev parent reply other threads:[~2016-10-05 17:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 20:46 [Bug] Static constructors considered evil Jean Tourrilhes
2016-09-22 21:17 ` [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs Jean Tourrilhes
2016-10-04 13:11 ` Sergio Gonzalez Monroy
2016-10-04 16:59 ` Jean Tourrilhes
2016-10-05 7:58 ` David Marchand
2016-10-05 16:49 ` Jean Tourrilhes
2016-10-05 17:09 ` Thomas Monjalon [this message]
2016-10-05 17:34 ` Jean Tourrilhes
2016-10-05 17:47 ` [PATCH v2] eal: don't " Jean Tourrilhes
2018-12-21 15:50 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 23:33 [PATCH 1/1] eal: Don't " Burdick, Cliff
2018-11-13 9:21 ` Thomas Monjalon
2018-11-13 9:39 ` Burakov, Anatoly
2018-11-13 15:45 ` Burdick, Cliff
2018-11-13 16:06 ` Thomas Monjalon
2018-11-13 16:38 ` Burdick, Cliff
2018-11-13 16:44 ` Thomas Monjalon
2018-11-13 22:08 ` Burdick, Cliff
2018-11-13 22:18 ` Thomas Monjalon
2018-11-13 23:42 ` Burdick, Cliff
2018-11-14 11:47 ` Bruce Richardson
2018-11-14 17:40 ` Burdick, Cliff
2018-11-14 18:15 ` Luca Boccassi
2018-11-14 18:24 ` Burdick, Cliff
2018-11-15 9:33 ` Luca Boccassi
2018-11-15 16:15 ` Burdick, Cliff
2018-11-15 16:41 ` Bruce Richardson
2018-11-15 16:55 ` Burdick, Cliff
2018-11-15 17:01 ` Richardson, Bruce
2018-11-15 17:05 ` Luca Boccassi
2018-11-15 17:17 ` Bruce Richardson
2018-11-15 17:36 ` Burdick, Cliff
2018-11-16 10:22 ` Bruce Richardson
2018-11-15 18:22 ` Luca Boccassi
2018-11-16 10:23 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7491622.GqnA43pcBO@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jean.tourrilhes@hpe.com \
--cc=olivier.matz@6wind.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.