From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5] vfio: Support for no-IOMMU mode
Date: Wed, 27 Jan 2016 18:07:06 +0100
Message-ID: <7496408.z4nt1qSYiL@xps13>
References: <1453905124-28544-1-git-send-email-anatoly.burakov@intel.com>
 <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Anatoly Burakov <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id BEB13ADA2
 for <dev@dpdk.org>; Wed, 27 Jan 2016 18:08:16 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id l65so153243269wmf.1
 for <dev@dpdk.org>; Wed, 27 Jan 2016 09:08:16 -0800 (PST)
In-Reply-To: <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-01-27 16:50, Anatoly Burakov:
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +int vfio_type1_dma_map(int);
> +int vfio_noiommu_dma_map(int);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
I agree with checkpatch, they should be static ;)

> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +/* older kernels may not have no-IOMMU mode */
> +#ifndef VFIO_NOIOMMU_IOMMU
> +#define VFIO_NOIOMMU_IOMMU 8
> +#endif

Shouldn't it be defined privately in .c file?