From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F8DAC43334 for ; Tue, 14 Jun 2022 22:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=We10J4fWEL3o9gPo1GTbj94c6JiGIW8ao4zynuCzkwM=; b=35RDCMIViKDQsa8FyVzdpIzPAQ hIRGxZ93xUwb0r7N7yh2FbJWfgzttzMJMjlNGykdoHLF4F8E+0jggaSuaMral2+cb9sfWfSwwl6Rg vLWBe/hS/dSCJmiH/RQcIijPuc5H4zmeSVpxxlfGpTtsqVQawwmOm7sj1D3qWdTsQGtrwD99Di0Fu jpKUHNwMwtRUHgyHC8UUmnQpTNMKjU6nLwTebt0YU7sjaONyVGNtTdaq1ZsHsOcjTbAN9kUeOS4oO mZ61Y++d/WtrrEuUnBocBUU79DJfoZLzlVZnqesB74D4/RJuJfwXDBy8RO7KAekAsc0DWACKj7QrT a6bNb05Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7h-00BcVA-UQ; Tue, 14 Jun 2022 22:34:57 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7d-00BcQr-Qu; Tue, 14 Jun 2022 22:34:55 +0000 Received: by mail-pl1-x62d.google.com with SMTP id g8so3708937plt.8; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=EVNEZd6o3bpvxYSFtFISdR9FG0168s4U0mz6ypOOJp99KiPoh9Ik/oZ+zIH3YUQnQ2 HrLxu1Giim5FZGhqPLXL1rHISZdFRouO9OtygCS6VSiunI9tDUdPmn0m24L9MmwXzu/j KKNxIRlyokhcdqHq/190VDPEBsYt9a9HA8rLwuOC3I/KPwrPeCzRGuV4OCfN3xsv2HTk 3usgarfpE6/+sGxJyaVyfingn3erRrmcX78ZcUX56lKkhOVREgGEatdxuQzuaaWVhmr+ GvbPnDykhxVOgptRVZZnEjSXobDOW6H8uZ+Dc+sRRS/+eK4TEVX6cK2Jt0EiNNTGzQhW /t9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=AdHq8bP7Wgt30H2ZNJTKPvvPNZ8JmKFGQXduT3Bq8z+EnhzQTvy4wgm3pJxe6vTdZI v7fNAIClYDd8Nz6Q8seCtd/4VuwA7h0+oPRcw4zWWfK30DyM9oCaYWW2OU5JIBqgBYUs KUYSe5uFDOv40/UoIOgSzQcNLNVgKh02sRpcAbiio3gyhSQ/HYJzZ8eMTk6coLD6fcbi etaA4i/YB5WsV2kIouqhTLU0mbgyp2LkDYc9tDbMSvyAUeHBJj1VDJDkpEq8EXGYacBE eLQbDBLfnr8lnNpJ4OAVocvrDhYWfIygtiKGeV8mYHSYW3yXWhtbaRNodXFBfTOG0MgG ngrw== X-Gm-Message-State: AJIora9yG7zLxFEJ8keuk1AybHLsVMZf0C8Wjmr0dBsVwyVE/5wd/eq8 XQfMNaTh+CCL28yPVL4b59Y= X-Google-Smtp-Source: AGRyM1vSg0Mq52lrM13IeIik3eO1LGcurCS+YdMXofPrDxWGFdT/IKpkZVfHH2wr8mkFmN+be5zWIw== X-Received: by 2002:a17:90b:3b45:b0:1e8:8688:219d with SMTP id ot5-20020a17090b3b4500b001e88688219dmr6695879pjb.231.1655246090167; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q21-20020a170902edd500b0016797c33b6csm7736666plk.116.2022.06.14.15.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 15:34:49 -0700 (PDT) Message-ID: <749728f6-fe32-bf3f-e71b-020e58a4cde1@gmail.com> Date: Tue, 14 Jun 2022 15:34:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 2/6] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220610170541.8643-1-linux@fw-web.de> <20220610170541.8643-3-linux@fw-web.de> From: Florian Fainelli In-Reply-To: <20220610170541.8643-3-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_153453_956636_FDFB64AA X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heiko Stuebner , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Eric Dumazet , Krzysztof Kozlowski , Mauro Carvalho Chehab , Greg Ungerer , Jakub Kicinski , Paolo Abeni , Vivien Didelot , devicetree@vger.kernel.org, Landen Chao , Sean Wang , DENG Qingfang , Rob Herring , Matthias Brugger , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Geis , Vladimir Oltean , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 6/10/22 10:05, Frank Wunderlich wrote: > From: Frank Wunderlich > > Rework vlan_add/vlan_del functions in preparation for dynamic cpu port. > > Currently BIT(MT7530_CPU_PORT) is added to new_members, even though > mt7530_port_vlan_add() will be called on the CPU port too. > > Let DSA core decide when to call port_vlan_add for the CPU port, rather > than doing it implicitly. > > We can do autonomous forwarding in a certain VLAN, but not add br0 to that > VLAN and avoid flooding the CPU with those packets, if software knows it > doesn't need to process them. > > Suggested-by: Vladimir Oltean > Signed-off-by: Frank Wunderlich > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED7E9C43334 for ; Tue, 14 Jun 2022 22:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gBcIMlRxGPM9fdYV3z6OmrUwLoh9YYORQlWHTp2z+Bc=; b=t7G1haqJeFTUPI tIGyEivKWlZErlDiXxXL3IN8CANiF7LH3INgpwv4o7lgecst4uHzf9Cwzce5QfOi419TznuzH9lWS Xl6k5GkJc/OAHeSwDOT0TS6jemw27oMqlE7RQ65pYAYH8KFJ/CZdusXX06CQdBIP3ZXHq3ak9NbnZ X3pulnf2XjxGBgZ48p6Gc0ZPR7XtMJJ+OZhINEPqWvw+ypwEc/wPRFGxNHdHqDhVtvMYR5swsGJg/ RNmOi1VUaNORmmcCbg1m767L1+QsgdcwAxK+w5fwSAUGagV6uJu/6dQp4lMJcPoSccgHfZa0GQRks MjXuatXLfOdECiffpFJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7h-00BcUi-9S; Tue, 14 Jun 2022 22:34:57 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7d-00BcQr-Qu; Tue, 14 Jun 2022 22:34:55 +0000 Received: by mail-pl1-x62d.google.com with SMTP id g8so3708937plt.8; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=EVNEZd6o3bpvxYSFtFISdR9FG0168s4U0mz6ypOOJp99KiPoh9Ik/oZ+zIH3YUQnQ2 HrLxu1Giim5FZGhqPLXL1rHISZdFRouO9OtygCS6VSiunI9tDUdPmn0m24L9MmwXzu/j KKNxIRlyokhcdqHq/190VDPEBsYt9a9HA8rLwuOC3I/KPwrPeCzRGuV4OCfN3xsv2HTk 3usgarfpE6/+sGxJyaVyfingn3erRrmcX78ZcUX56lKkhOVREgGEatdxuQzuaaWVhmr+ GvbPnDykhxVOgptRVZZnEjSXobDOW6H8uZ+Dc+sRRS/+eK4TEVX6cK2Jt0EiNNTGzQhW /t9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=AdHq8bP7Wgt30H2ZNJTKPvvPNZ8JmKFGQXduT3Bq8z+EnhzQTvy4wgm3pJxe6vTdZI v7fNAIClYDd8Nz6Q8seCtd/4VuwA7h0+oPRcw4zWWfK30DyM9oCaYWW2OU5JIBqgBYUs KUYSe5uFDOv40/UoIOgSzQcNLNVgKh02sRpcAbiio3gyhSQ/HYJzZ8eMTk6coLD6fcbi etaA4i/YB5WsV2kIouqhTLU0mbgyp2LkDYc9tDbMSvyAUeHBJj1VDJDkpEq8EXGYacBE eLQbDBLfnr8lnNpJ4OAVocvrDhYWfIygtiKGeV8mYHSYW3yXWhtbaRNodXFBfTOG0MgG ngrw== X-Gm-Message-State: AJIora9yG7zLxFEJ8keuk1AybHLsVMZf0C8Wjmr0dBsVwyVE/5wd/eq8 XQfMNaTh+CCL28yPVL4b59Y= X-Google-Smtp-Source: AGRyM1vSg0Mq52lrM13IeIik3eO1LGcurCS+YdMXofPrDxWGFdT/IKpkZVfHH2wr8mkFmN+be5zWIw== X-Received: by 2002:a17:90b:3b45:b0:1e8:8688:219d with SMTP id ot5-20020a17090b3b4500b001e88688219dmr6695879pjb.231.1655246090167; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q21-20020a170902edd500b0016797c33b6csm7736666plk.116.2022.06.14.15.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 15:34:49 -0700 (PDT) Message-ID: <749728f6-fe32-bf3f-e71b-020e58a4cde1@gmail.com> Date: Tue, 14 Jun 2022 15:34:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 2/6] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Peter Geis , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Ungerer , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Mauro Carvalho Chehab References: <20220610170541.8643-1-linux@fw-web.de> <20220610170541.8643-3-linux@fw-web.de> From: Florian Fainelli In-Reply-To: <20220610170541.8643-3-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_153453_956636_FDFB64AA X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 6/10/22 10:05, Frank Wunderlich wrote: > From: Frank Wunderlich > > Rework vlan_add/vlan_del functions in preparation for dynamic cpu port. > > Currently BIT(MT7530_CPU_PORT) is added to new_members, even though > mt7530_port_vlan_add() will be called on the CPU port too. > > Let DSA core decide when to call port_vlan_add for the CPU port, rather > than doing it implicitly. > > We can do autonomous forwarding in a certain VLAN, but not add br0 to that > VLAN and avoid flooding the CPU with those packets, if software knows it > doesn't need to process them. > > Suggested-by: Vladimir Oltean > Signed-off-by: Frank Wunderlich > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E8FFC43334 for ; Tue, 14 Jun 2022 22:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f0bz+WILH0KaAHVzEVssIypGlQVQjjKMHdZG1VheDHU=; b=AD88hKJJkllGmf U7Oc+zCiyFb0QlRH3OADwigJCh8D+jF31d62Wx5BDopPz7diylvSrk5PpIbP1ltXsevVL7HasEdEG YizFNxjLLMCv/0c3T7sWxUlNnNVe0SWuBHbvnevwFU7MsXG8Dtbgpx2jxtHjc7sNaQzhXF7P5G8XE WT1ZVNiBTANJEMZXRNNSP71q8/cMELUKQnaUSJoHo4YDsNCOtv9j0EgRLGcP4moLv/1RzbrUZ7/Yv fyF74eMNeENSnC1G5b13m3mxvWXklLouJ9NiMsR2JkvFdxyWgW0jDTDzpT0b3j19TK2P7o34IXc89 Ebp+sYZJVTlEix4qIIqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7j-00BcVs-Jn; Tue, 14 Jun 2022 22:34:59 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1F7d-00BcQr-Qu; Tue, 14 Jun 2022 22:34:55 +0000 Received: by mail-pl1-x62d.google.com with SMTP id g8so3708937plt.8; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=EVNEZd6o3bpvxYSFtFISdR9FG0168s4U0mz6ypOOJp99KiPoh9Ik/oZ+zIH3YUQnQ2 HrLxu1Giim5FZGhqPLXL1rHISZdFRouO9OtygCS6VSiunI9tDUdPmn0m24L9MmwXzu/j KKNxIRlyokhcdqHq/190VDPEBsYt9a9HA8rLwuOC3I/KPwrPeCzRGuV4OCfN3xsv2HTk 3usgarfpE6/+sGxJyaVyfingn3erRrmcX78ZcUX56lKkhOVREgGEatdxuQzuaaWVhmr+ GvbPnDykhxVOgptRVZZnEjSXobDOW6H8uZ+Dc+sRRS/+eK4TEVX6cK2Jt0EiNNTGzQhW /t9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=AdHq8bP7Wgt30H2ZNJTKPvvPNZ8JmKFGQXduT3Bq8z+EnhzQTvy4wgm3pJxe6vTdZI v7fNAIClYDd8Nz6Q8seCtd/4VuwA7h0+oPRcw4zWWfK30DyM9oCaYWW2OU5JIBqgBYUs KUYSe5uFDOv40/UoIOgSzQcNLNVgKh02sRpcAbiio3gyhSQ/HYJzZ8eMTk6coLD6fcbi etaA4i/YB5WsV2kIouqhTLU0mbgyp2LkDYc9tDbMSvyAUeHBJj1VDJDkpEq8EXGYacBE eLQbDBLfnr8lnNpJ4OAVocvrDhYWfIygtiKGeV8mYHSYW3yXWhtbaRNodXFBfTOG0MgG ngrw== X-Gm-Message-State: AJIora9yG7zLxFEJ8keuk1AybHLsVMZf0C8Wjmr0dBsVwyVE/5wd/eq8 XQfMNaTh+CCL28yPVL4b59Y= X-Google-Smtp-Source: AGRyM1vSg0Mq52lrM13IeIik3eO1LGcurCS+YdMXofPrDxWGFdT/IKpkZVfHH2wr8mkFmN+be5zWIw== X-Received: by 2002:a17:90b:3b45:b0:1e8:8688:219d with SMTP id ot5-20020a17090b3b4500b001e88688219dmr6695879pjb.231.1655246090167; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q21-20020a170902edd500b0016797c33b6csm7736666plk.116.2022.06.14.15.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 15:34:49 -0700 (PDT) Message-ID: <749728f6-fe32-bf3f-e71b-020e58a4cde1@gmail.com> Date: Tue, 14 Jun 2022 15:34:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 2/6] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Peter Geis , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Ungerer , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Mauro Carvalho Chehab References: <20220610170541.8643-1-linux@fw-web.de> <20220610170541.8643-3-linux@fw-web.de> From: Florian Fainelli In-Reply-To: <20220610170541.8643-3-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_153453_956636_FDFB64AA X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/10/22 10:05, Frank Wunderlich wrote: > From: Frank Wunderlich > > Rework vlan_add/vlan_del functions in preparation for dynamic cpu port. > > Currently BIT(MT7530_CPU_PORT) is added to new_members, even though > mt7530_port_vlan_add() will be called on the CPU port too. > > Let DSA core decide when to call port_vlan_add for the CPU port, rather > than doing it implicitly. > > We can do autonomous forwarding in a certain VLAN, but not add br0 to that > VLAN and avoid flooding the CPU with those packets, if software knows it > doesn't need to process them. > > Suggested-by: Vladimir Oltean > Signed-off-by: Frank Wunderlich > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AEEC433EF for ; Tue, 14 Jun 2022 22:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbiFNWew (ORCPT ); Tue, 14 Jun 2022 18:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbiFNWew (ORCPT ); Tue, 14 Jun 2022 18:34:52 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4B064D61A; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id g16-20020a17090a7d1000b001ea9f820449so350665pjl.5; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=EVNEZd6o3bpvxYSFtFISdR9FG0168s4U0mz6ypOOJp99KiPoh9Ik/oZ+zIH3YUQnQ2 HrLxu1Giim5FZGhqPLXL1rHISZdFRouO9OtygCS6VSiunI9tDUdPmn0m24L9MmwXzu/j KKNxIRlyokhcdqHq/190VDPEBsYt9a9HA8rLwuOC3I/KPwrPeCzRGuV4OCfN3xsv2HTk 3usgarfpE6/+sGxJyaVyfingn3erRrmcX78ZcUX56lKkhOVREgGEatdxuQzuaaWVhmr+ GvbPnDykhxVOgptRVZZnEjSXobDOW6H8uZ+Dc+sRRS/+eK4TEVX6cK2Jt0EiNNTGzQhW /t9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AHmm98PAzPcJptU2nMgRv/dq7HuAyrlYg6vwIKYPXjA=; b=Rn61eGFwW7oUqoY2g1GcCCXjWRO6/y1B4D5JbEfhgCIfIHzq2To6F7nzFzknrrKJlP g2Uc4G6ICI35JVpDEXa2LK01Ml+CucTlggfNWCkUH2n3ztXXQrpaOkmhU1IGHoCsAL7Z +qL41H+Qf6Fo8tWbDaUrBIPmOeX3hJbd4Y4UcccOYfbVShvs47Y4NOKBCn66HoEidux6 2eifm9kJZGptDbey5AIGn6F7VO6fXmgVPJcZBwYQKmw1TVw4z3kILrjoY5V7xIFJhKp9 Y//p8Tdexa4UW9rcjZK7JdQ60YloYCsvnqzJfEE9y/+h2MzFLzEKs/IrqwTlgayLn4O6 H+Tg== X-Gm-Message-State: AJIora+SA92VzIZvbUgKd15eozaluN1iCJFJ2jxF8Tux/Fw6POcPuDgn ktC7Tu5ClSxkrqGI83sOQhQ= X-Google-Smtp-Source: AGRyM1vSg0Mq52lrM13IeIik3eO1LGcurCS+YdMXofPrDxWGFdT/IKpkZVfHH2wr8mkFmN+be5zWIw== X-Received: by 2002:a17:90b:3b45:b0:1e8:8688:219d with SMTP id ot5-20020a17090b3b4500b001e88688219dmr6695879pjb.231.1655246090167; Tue, 14 Jun 2022 15:34:50 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q21-20020a170902edd500b0016797c33b6csm7736666plk.116.2022.06.14.15.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 15:34:49 -0700 (PDT) Message-ID: <749728f6-fe32-bf3f-e71b-020e58a4cde1@gmail.com> Date: Tue, 14 Jun 2022 15:34:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 2/6] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Peter Geis , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Ungerer , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Mauro Carvalho Chehab References: <20220610170541.8643-1-linux@fw-web.de> <20220610170541.8643-3-linux@fw-web.de> From: Florian Fainelli In-Reply-To: <20220610170541.8643-3-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 6/10/22 10:05, Frank Wunderlich wrote: > From: Frank Wunderlich > > Rework vlan_add/vlan_del functions in preparation for dynamic cpu port. > > Currently BIT(MT7530_CPU_PORT) is added to new_members, even though > mt7530_port_vlan_add() will be called on the CPU port too. > > Let DSA core decide when to call port_vlan_add for the CPU port, rather > than doing it implicitly. > > We can do autonomous forwarding in a certain VLAN, but not add br0 to that > VLAN and avoid flooding the CPU with those packets, if software knows it > doesn't need to process them. > > Suggested-by: Vladimir Oltean > Signed-off-by: Frank Wunderlich > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian