Re: [PATCH] smb: client: fix rlist race and missing initialization

[Paulo Alcantara <pc@manguebit.org>]

Paulo Alcantara <pc@manguebit.org> writes:

> TCP_Server_Info.rlist is allocated via kzalloc which zeros both ->next
> and ->prev to NULL instead of pointing to itself, making list_empty()
> always return false and list_add() dereference a NULL ->prev pointer.
>
> Also, cifs_signal_cifsd_for_reconnect() can be called concurrently
> from multiple cifsd threads, allowing the same server's rlist node to
> be added twice into the local list, corrupting it.
>
> Fixes: df0e03a4fb94 ("smb: client: fix potential deadlock when reconnecting channels")
> Signed-off-by: Paulo Alcantara <pc@manguebit.org>
> Cc: Namjae Jeon <linkinjeon@kernel.org>
> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Cc: Shyam Prasad N <sprasad@microsoft.com>
> Cc: Tom Talpey <tom@talpey.com>
> Cc: Bharath SM <bharathsm@microsoft.com>
> Cc: stable@vger.kernel.org

Please ignore it.  Sashiko found out a potential issue with this patch.

I'll rework it and then post v2 soon.