From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/7] meson: avoid recompiling HTTP sources several times
Date: Mon, 5 Oct 2026 13:33:46 +0530 [thread overview]
Message-ID: <74b22ec2-280e-4fca-9f5b-c21a7c12a78f@gmail.com> (raw)
In-Reply-To: <20260924-pks-meson-improvements-v1-1-90b7f79f1c4e@pks.im>
On 9/24/26 19:39, Patrick Steinhardt wrote:
> We only link curl into a subset of our subcommands. Consequently, as
> both "http.c" and "http-walker.c" depend on curl, we don't compile these
> into "libgit.a" but instead only link those into the commands that
> depend on curl.
>
> In Meson, we wire these dependencies into the target executables by
> using the `sources:` keyword. But this has the consequence that we're
> recompiling those multiple several times, once for every different
s/multiple several/multiple/
Rest of the patch look good to me.
--
Sivaraam
next prev parent reply other threads:[~2026-10-05 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 14:09 [PATCH 0/7] A couple of Meson improvements Patrick Steinhardt
2026-09-24 14:09 ` [PATCH 1/7] meson: avoid recompiling HTTP sources several times Patrick Steinhardt
2026-09-30 12:00 ` Karthik Nayak
2026-10-05 8:03 ` Kaartic Sivaraam [this message]
2026-09-24 14:09 ` [PATCH 2/7] meson: don't recompile git-remote-http(1) multiple times for tests Patrick Steinhardt
2026-09-24 14:09 ` [PATCH 3/7] meson: use precompiled headers for our test-helper Patrick Steinhardt
2026-09-30 12:20 ` Karthik Nayak
2026-09-24 14:09 ` [PATCH 4/7] meson: use precompiled headers for unit tests Patrick Steinhardt
2026-10-05 9:34 ` Kaartic Sivaraam
2026-10-05 10:24 ` Patrick Steinhardt
2026-09-24 14:09 ` [PATCH 5/7] meson: fix outdated completion helpers Patrick Steinhardt
2026-09-24 14:09 ` [PATCH 6/7] meson: update wrappers Patrick Steinhardt
2026-09-30 12:24 ` Karthik Nayak
2026-10-05 9:42 ` Kaartic Sivaraam
2026-10-05 10:25 ` Patrick Steinhardt
2026-09-24 14:09 ` [PATCH 7/7] gitlab-ci: fix hanging MSVC jobs Patrick Steinhardt
2026-09-30 12:26 ` Karthik Nayak
2026-09-30 12:48 ` Patrick Steinhardt
2026-09-30 12:26 ` [PATCH 0/7] A couple of Meson improvements Karthik Nayak
2026-10-05 9:51 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b22ec2-280e-4fca-9f5b-c21a7c12a78f@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.