From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B3E20E700; Thu, 6 Mar 2025 13:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741267009; cv=none; b=I++cMkxxuc9w7e1gdiHQDDggFiEQ40IHAMZehQp+7Gl26UNMxUl56EYWmz+CjgbcykoboIPCBcVwLjxHkSYz0h6BUJrIGT7gLnh34q/BR5knw4CZD204ORU8G2gjBYUaKNIG1fYpAtNvBh/Xz0rkBo9jPuK7UR2PLgwjOM5/mjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741267009; c=relaxed/simple; bh=BNTdlz+O6/yoAxyZStm5+vjqcla/S1CJaC4VhpHhXmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qozcsT0OH/lIywegFx2OEylOR4MEttE02HWjhpeXwaiXTguJ1tFdZ0cQy4ZfrDPZWxBrk4+bd+ywHjMJb/0vJerT1Q80cZDe4aJUpTi5QTxo8srbNiFnxWcE3yz1CiFKWiNQda6fIprn7xmtAIsWTje9g0+dFniJNglKMBSVNXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k7mj3JoI; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k7mj3JoI" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-223fd89d036so10730825ad.1; Thu, 06 Mar 2025 05:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741267007; x=1741871807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F7U7pk8UvOy5bs7uwLzg5dC0QofSOExWhjQaOhFe4NU=; b=k7mj3JoIncS3s/PHQXX2fY7xBoRA6HBhFRM7N10M7wAkEHwcuxsxOd5339Z+WVtio9 AtR/A4HHobVKMqA7ThtWpu89P5SEp+OZa+DSlZsnFzlPg5GVgzjYrsVJtiz+Qd1OacPa IPTKHH2eywRwQUx+KdcTEbhb0TIEi6IqltBQdfrbcY67bh6FoH+pGr0IqIE/EEtxKpbm Cwtg7g2gqpMfe+9Gx0IlwjYOGiD/JNc2DKwbzxD3PAjEZeP3x4QfxPqcZBVr4F4ohOTx ASCAOYMgUgqNxVRSImEt0i9O5fvv8wituweZHV3WAPUE3RrkkTsTBdYH5UjnoXqthJlp Cb2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741267007; x=1741871807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F7U7pk8UvOy5bs7uwLzg5dC0QofSOExWhjQaOhFe4NU=; b=rf9c1YER2FuihMeCNwrvaEiKrNKtrU9sO7PEfM6vHxhfIVpNrALG1XK/x7XMJTcUO8 kIqb+i18gjetM37mjUlYTFb9b60JyS+cA9vvTcQQUFKTnM6vHGFk0asOSwZIFfVqeR88 lU/FYcreNn8kAF7ShF+VLjSj/Xl+3t8AgtO1YYSZIO39FOVh6Vl11fEHS6+M0AZgDbD2 OrtmASNIiINu4bSHKBLHhNng07Ce5ecSU5J14aO39d4SOE6pJRQ1hs8VZfTEa/ZohSV0 nHLO2BkbhEfyUsjccxbw68B8cMdIobd145d0FUvgUpZa6jEzG9bPUVV/K6JXCQFqahuV xdlQ== X-Forwarded-Encrypted: i=1; AJvYcCVdP35oo8bJWlWNLcUy9Pf2qGZgbQziWdxfaw6ZPxb4FF5A84yquz93Y4nxuFrrUaShqWmdJq24UgS4tIzq@vger.kernel.org, AJvYcCWfpIAAvS4y3S/vgamISXyUaJ3rAQKhJepUUeP9psqDyPOCyMYMSBhmyS0qxfR2BRMIpqkMPkgtdPvT@vger.kernel.org, AJvYcCXIXJ1naR/opyKoaAlliP1BlCHZ1Oml7/oWraOi8vJ3a3frchTAvQV1AHY58KmDFzctDHvK3OpbIseG@vger.kernel.org X-Gm-Message-State: AOJu0YwfFlM2qeDo5snPBTKniqJwge2xWB0AAAdDpZYdQx/MslP5BLRD teDwEC+BwnFe4ktq6huTve2rz0Mryg82U60rJe4lLV00jvzofs3PwmtKUW5XEj+j+q81 X-Gm-Gg: ASbGncshnir9woZ3G1enQrqJzBVcEZq+5v49pCuIQAh9wcB6IYnKw0wXzqGQqcHgm7o G0bORanAMWqydvMUaFtbZXrMTFY4dL+BY7zFQsOKqqk7mdz4ewlY+ZfMQTtuYYn+icmep+4On5G SWK/kL0AEGyWaIWBsJlwvIPivpeSarMlBIwGNtqS11U+Vj96/yc7x7F4iACGDJcVQf5IxMuifin BvAMmAvdUK9k2j2qC7PhFdgXONhVw/CHfXGTXiX6lWvK+ij8NPBz2Xc7JIYHWNwSkBAuvHdMC7M W5nrzKgD5BaRvv8QRAq/eOK3I6eW X-Google-Smtp-Source: AGHT+IH08B/pnoIFoMdt3ja0MC9Y8MP+37dUqKED3147DhyKQtyIeRsrx4pZtAJ2Zf6ULLi0sy2u9A== X-Received: by 2002:a05:6a00:14d5:b0:736:2d84:74da with SMTP id d2e1a72fcca58-73682b84ef1mr10341398b3a.10.1741267006841; Thu, 06 Mar 2025 05:16:46 -0800 (PST) Received: from [127.0.0.1] ([2a0d:2683:c100::bf]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736985158f3sm1303566b3a.137.2025.03.06.05.16.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 05:16:46 -0800 (PST) Message-ID: <74b70a83-e10e-4496-9bc6-e376211db670@gmail.com> Date: Thu, 6 Mar 2025 21:16:37 +0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v5 2/2] i2c: spacemit: add support for SpacemiT K1 SoC To: Alex Elder , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan Cc: linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev References: <20250303-k1-i2c-master-v5-0-21dfc7adfe37@gmail.com> <20250303-k1-i2c-master-v5-2-21dfc7adfe37@gmail.com> Content-Language: en-US From: Troy Mitchell In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2025/3/4 08:01, Alex Elder wrote: > On 3/2/25 11:30 PM, Troy Mitchell wrote: >> This patch introduces basic I2C support for the SpacemiT K1 SoC, >> utilizing interrupts for transfers. >> >> The driver has been tested using i2c-tools on a Bananapi-F3 board, >> and basic I2C read/write operations have been confirmed to work. >> >> Signed-off-by: Troy Mitchell > > I have some more comments, and some questions.  I appreciate > seeing some of the changes you've made based on my feedback. Hi, Alex. Thanks for your review. >> +static void spacemit_i2c_init(struct spacemit_i2c_dev *i2c) >> +{ >> +    u32 val; >> + >> +    /* >> +     * Unmask interrupt bits for all xfer mode: >> +     * bus error, arbitration loss detected. >> +     * For transaction complete signal, we use master stop >> +     * interrupt, so we don't need to unmask SPACEMIT_CR_TXDONEIE. >> +     */ >> +    val = SPACEMIT_CR_BEIE | SPACEMIT_CR_ALDIE; >> + >> +    /* >> +     * Unmask interrupt bits for interrupt xfer mode: >> +     * DBR rx full. >> +     * For tx empty interrupt SPACEMIT_CR_DTEIE, we only >> +     * need to enable when trigger byte transfer to start >> +     * data sending. >> +     */ >> +    val |= SPACEMIT_CR_DRFIE; >> + >> +    /* set speed bits: default fast mode */ > > It is not *default* fast mode, it *is* fast mode.  (There > is no other mode used in this driver, right?) yes. I will talk it below. > >> +    val |= SPACEMIT_CR_MODE_FAST; >> + >> +    /* disable response to general call */ >> +    val |= SPACEMIT_CR_GCD; >> + >> +    /* enable SCL clock output */ >> +    val |= SPACEMIT_CR_SCLE; >> + >> +    /* enable master stop detected */ >> +    val |= SPACEMIT_CR_MSDE | SPACEMIT_CR_MSDIE; >> + >> +    writel(val, i2c->base + SPACEMIT_ICR); >> +} >> + >> + >> +static int spacemit_i2c_xfer_core(struct spacemit_i2c_dev *i2c) >> +{ >> +    int ret; >> + >> +    spacemit_i2c_reset(i2c); > > I don't have a lot of experience with I2C drivers, but is it normal > to reset before every transfer? > > If it is, just tell me that.  But if it's not, can you explain why > it's necessary here? My initial idea was to keep the I2C state in its initial state before each transmission.  But after testing, this is not necessary. I will move it to `probe` function. > >> + >> +    spacemit_i2c_calc_timeout(i2c); >> + >> +    spacemit_i2c_init(i2c); >> + > > Here too, maybe I just don't know what most I2C drivers do, but > is it necessary to only enable the I2C adapter and its interrupt > handler when performing a transfer? It is necessary to enable before each transmission.  I have tested moving the `spacemit_i2c_enable` to the probe function.  It will cause transmission errors. As for the `enable_irq`, I think it can be moved to the `probe` function. > >> +    spacemit_i2c_enable(i2c); >> +    enable_irq(i2c->irq); >> + >> +    /* i2c wait for bus busy */ >> +    ret = spacemit_i2c_recover_bus_busy(i2c); >> +    if (ret) >> +        return ret; >> + >> +    ret = spacemit_i2c_xfer_msg(i2c); >> +    if (ret < 0) >> +        dev_dbg(i2c->dev, "i2c transfer error\n"); > > If you're reporting the error you might as well say what > it is. > >     dev_dbg(i2c->dev, "i2c transfer error: %d\n", ret); > >> + >> +    return ret; >> +} >> + >> +static int spacemit_i2c_xfer(struct i2c_adapter *adapt, struct i2c_msg >> *msgs, int num) >> +{ >> +    struct spacemit_i2c_dev *i2c = i2c_get_adapdata(adapt); >> +    int ret; >> +    u32 err = SPACEMIT_I2C_GET_ERR(i2c->status); >> + >> +    i2c->msgs = msgs; >> +    i2c->msg_num = num; >> + >> +    ret = spacemit_i2c_xfer_core(i2c); >> +    if (!ret) >> +        spacemit_i2c_check_bus_release(i2c); >> + > > The enable_irq() call that matches the disable call below is > found in spacemit_i2c_xfer_core().  That's where this call > belongs. > >> +    disable_irq(i2c->irq); >> + > > Same with the next call--it should be in the same function > that its corresponding spacemit_i2c_enable() is called. > > With these suggestions in mind, I think you can safely > just get rid of spacemit_i2c_xfer_core().  It is only > called in this one spot (above), and you can just do > everything within spacemit_i2c_xfer() instead. > >> +    spacemit_i2c_disable(i2c); >> + >> +    if (ret == -ETIMEDOUT || ret == -EAGAIN) >> +        dev_alert(i2c->dev, "i2c transfer failed, ret %d err 0x%x\n", ret, >> err); >> + >> +    return ret < 0 ? ret : num; >> +} >> + >> +static u32 spacemit_i2c_func(struct i2c_adapter *adap) >> +{ >> +    return I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); >> +} >> + >> +static const struct i2c_algorithm spacemit_i2c_algo = { >> +    .xfer = spacemit_i2c_xfer, >> +    .functionality = spacemit_i2c_func, >> +}; >> + >> +static int spacemit_i2c_probe(struct platform_device *pdev) >> +{ >> +    struct clk *clk; >> +    struct device *dev = &pdev->dev; >> +    struct device_node *of_node = pdev->dev.of_node; >> +    struct spacemit_i2c_dev *i2c; >> +    int ret = 0; > > There is no need to initialize ret. > >> + >> +    i2c = devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL); >> +    if (!i2c) >> +        return -ENOMEM; >> + >> +    ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); >> +    if (ret) >> +        return dev_err_probe(dev, ret, "failed to read clock-frequency >> property"); >> + >> +    /* For now, this driver doesn't support high-speed. */ >> +    if (i2c->clock_freq < 1 || i2c->clock_freq > 400000) { > > In your device tree binding, you indicate that three different > modes are supported, and that the maximum frequency is 3300000 Hz. > This says that only ranges from 1-400000 Hz are allowed. > > In fact, although you look up this clock frequency in DT, I see > nothing that actually is affected by this value.  I.e., no I2C > bus frequency changes, regardless of what frequency you specify. > The only place the clock_freq field is used is in calculating > the timeout for a transfer. > > So two things: > - My guess is that you are relying on whatever frequency the >   hardware already is using, and maybe that's 400000 Hz. >   That's fine, though at some point it should be more >   directly controlled (set somehow). > - Since you don't actually support any other frequency, >   drop this "clock-frequency" feature for now, and add it >   when you're ready to actually support it. > > And I might be wrong about this, but I don't think your > (new) DTS binding should specify behavior that is not > supported by the driver. > >                     -Alex I will support standard mode in next version. We just need to modify the function `spacemit_i2c_init`. > >> +        dev_warn(dev, "unsupport clock frequency: %d, default: 400000", >> i2c->clock_freq); >> +        i2c->clock_freq = 400000; >> +    } >> + >> +    i2c->dev = &pdev->dev; >> + >> +    i2c->base = devm_platform_ioremap_resource(pdev, 0); >> +    if (IS_ERR(i2c->base)) >> +        return dev_err_probe(dev, PTR_ERR(i2c->base), "failed to do ioremap"); >> + >> +    i2c->irq = platform_get_irq(pdev, 0); >> +    if (i2c->irq < 0) >> +        return dev_err_probe(dev, i2c->irq, "failed to get irq resource"); >> + >> +    ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler, >> +                   IRQF_NO_SUSPEND | IRQF_ONESHOT, dev_name(i2c->dev), i2c); >> +    if (ret) >> +        return dev_err_probe(dev, ret, "failed to request irq"); >> + >> +    disable_irq(i2c->irq); >> + >> +    clk = devm_clk_get_enabled(dev, "apb"); >> +    if (IS_ERR(clk)) >> +        return dev_err_probe(dev, PTR_ERR(clk), "failed to enable apb clock"); >> + >> +    clk = devm_clk_get_enabled(dev, "twsi"); >> +    if (IS_ERR(clk)) >> +        return dev_err_probe(dev, PTR_ERR(clk), "failed to enable twsi clock"); >> + >> +    i2c_set_adapdata(&i2c->adapt, i2c); >> +    i2c->adapt.owner = THIS_MODULE; >> +    i2c->adapt.algo = &spacemit_i2c_algo; >> +    i2c->adapt.dev.parent = i2c->dev; >> +    i2c->adapt.nr = pdev->id; >> + >> +    i2c->adapt.dev.of_node = of_node; >> +    i2c->adapt.algo_data = i2c; >> + >> +    strscpy(i2c->adapt.name, "spacemit-i2c-adapter", sizeof(i2c->adapt.name)); >> + >> +    init_completion(&i2c->complete); >> + >> +    platform_set_drvdata(pdev, i2c); >> + >> +    ret = i2c_add_numbered_adapter(&i2c->adapt); >> +    if (ret) >> +        return dev_err_probe(&pdev->dev, ret, "failed to add i2c adapter"); >> + >> +    return 0; >> +} >> + >> +static void spacemit_i2c_remove(struct platform_device *pdev) >> +{ >> +    struct spacemit_i2c_dev *i2c = platform_get_drvdata(pdev); >> + >> +    i2c_del_adapter(&i2c->adapt); >> +} >> + >> +static const struct of_device_id spacemit_i2c_of_match[] = { >> +    { .compatible = "spacemit,k1-i2c", }, >> +    { /* sentinel */ } >> +}; >> +MODULE_DEVICE_TABLE(of, spacemit_i2c_of_match); >> + >> +static struct platform_driver spacemit_i2c_driver = { >> +    .probe = spacemit_i2c_probe, >> +    .remove = spacemit_i2c_remove, >> +    .driver = { >> +        .name = "i2c-k1", >> +        .of_match_table = spacemit_i2c_of_match, >> +    }, >> +}; >> +module_platform_driver(spacemit_i2c_driver); >> + >> +MODULE_LICENSE("GPL"); >> +MODULE_DESCRIPTION("I2C bus driver for SpacemiT K1 SoC"); >> > -- Troy Mitchell From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAF67C282D1 for ; Thu, 6 Mar 2025 13:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z7JC6ySkTEeZEsVfPA4RXi/K0F9nIO3DA/tc1fJDm2E=; b=Ys2hC1iek5KXOT JLjAQ+DfmOKi0hTzzEhCUSftMUEyobjHyxsQyTTYG9mU1uIywVFEjt46WwZ0vvgPNZdkElxhJB8BF oCXPvDvyrKTEK48veiC+m/5aduw9L6bHmWojc5kmQ6WSGxcvwg8vpTYHhoHiP0ASAPBjuZWKJ8NVJ x8xRVuKV3Fyj0nD9yED5gh99QqBhimma2Ds99XzqL4MSm3haS+pq1zTk5kb0MCAVpPuJ9CjM84znT JLoA3MUqLmiG6ZRN5ZJp/Q3O1May2KCazFjalh/jkcIRdV+zBBZVCMyH9FLkkLv3UU3zyEtFYv4uX zQgkJJF4ScUgiOZ0otlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqBCe-0000000B2uc-0har; Thu, 06 Mar 2025 13:23:56 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqB5k-0000000B1bD-2bb4 for linux-riscv@lists.infradead.org; Thu, 06 Mar 2025 13:16:49 +0000 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-22349bb8605so10004335ad.0 for ; Thu, 06 Mar 2025 05:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741267007; x=1741871807; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F7U7pk8UvOy5bs7uwLzg5dC0QofSOExWhjQaOhFe4NU=; b=XkmaANZnUj+iXvnaOsv5der1xe0f7nX/W25y5mn9FRK8IWqMOC8XYZM9CZZG8wM0UF N8Nir2gS78PTkTtFWunWLn/1TyHes9PH3tIuCrIdc0Vt18Axx8vfhX8z5JbGKERqfsuX P/DNBRz2WEnqRHMpD8icCV5ejYWQAHHHOfg46WinPUmbFv4LWPgfzBcIgfCUcf+vjq3g UP37m1FL8MBWsBZ4HyEHXf/FHoTXaYMHhfC8njl+HgZx29G/YYtxFFYKdwwh/TYf5PN0 FhbFBHdoH9UVmsVF1wCJgsMA/mao+N4DPAeNjzies0GlfQ2G2rC0DJ1oTUH4VpUV4ZKQ kYSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741267007; x=1741871807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F7U7pk8UvOy5bs7uwLzg5dC0QofSOExWhjQaOhFe4NU=; b=BWGT/ez0tjyi+vx0SwTcYKX6w/gMb29+7dghesoK1t81EcGOCsvhtJkhC0ibIyIvcl L5kFtvJRjjBp1yT0lbPxLyx+cfS8RHJP2YtHXwRbBJt/40CYev9LiTQgsWXNeNAtmcnc 6NzyejJhkKeURRYiIL9acaPhEnE0irLkHSNW0k0Vt2/Ad/5SM7xSLwsOrg+ZW3SHMp/U D3wfRn4IblkzW9AijxTA39vzZDGwe8Qgta4t/oMtdXe6JNFsF/+5XW0/ggfKt9EVHvuP EMjpXgJ3zQgvKwjmcu8Q2Cb5mM7rY9rFFr3kshGCgriqLg2NslvnF86oWAXz/KxXjomI 0hcQ== X-Gm-Message-State: AOJu0YwoLuK1NZ2yRHyej/RoDqXYONTrXgJis4FIuqClno7SmHqEobwy 7diJV5AOS10ZaocEJDVlOJfJ0h/WtsYZG5gvJOEE9uPwc4RmbUKP X-Gm-Gg: ASbGnctCBTgGe5+seJRbciFAw1H7aPYvzVH2AUH+YHm8RP41U2pk8K5NLS91/Pkz1T1 oGEcGjBnZieKar/oFPPnLB93RXA2sHPkl94aziPcoJtYIANi0cLRrzPEthZFRgNXmX8eTXsRsGg bPx9dN3IiC8VWIZpnVJUjOSsbDyr+nISx34cyhkE/LGbDRrn0nif5SBLINUz8gsNkAvYTkS1gNi ysmsslnqBixyg70K/xoN5qy/Vnzk3uOte/XiPuS/OZgvDi9+qMR1JceBJj9Qu3LwOQvFEPme7I3 1MrbOVrMudhaQOXF0PVe7+CHDM72 X-Google-Smtp-Source: AGHT+IH08B/pnoIFoMdt3ja0MC9Y8MP+37dUqKED3147DhyKQtyIeRsrx4pZtAJ2Zf6ULLi0sy2u9A== X-Received: by 2002:a05:6a00:14d5:b0:736:2d84:74da with SMTP id d2e1a72fcca58-73682b84ef1mr10341398b3a.10.1741267006841; Thu, 06 Mar 2025 05:16:46 -0800 (PST) Received: from [127.0.0.1] ([2a0d:2683:c100::bf]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736985158f3sm1303566b3a.137.2025.03.06.05.16.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 05:16:46 -0800 (PST) Message-ID: <74b70a83-e10e-4496-9bc6-e376211db670@gmail.com> Date: Thu, 6 Mar 2025 21:16:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v5 2/2] i2c: spacemit: add support for SpacemiT K1 SoC To: Alex Elder , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan Cc: linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev References: <20250303-k1-i2c-master-v5-0-21dfc7adfe37@gmail.com> <20250303-k1-i2c-master-v5-2-21dfc7adfe37@gmail.com> Content-Language: en-US From: Troy Mitchell In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_051648_684321_A1DA4995 X-CRM114-Status: GOOD ( 45.05 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyNS8zLzQgMDg6MDEsIEFsZXggRWxkZXIgd3JvdGU6Cgo+IE9uIDMvMi8yNSAxMTozMCBQ TSwgVHJveSBNaXRjaGVsbCB3cm90ZToKPj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGJhc2ljIEky QyBzdXBwb3J0IGZvciB0aGUgU3BhY2VtaVQgSzEgU29DLAo+PiB1dGlsaXppbmcgaW50ZXJydXB0 cyBmb3IgdHJhbnNmZXJzLgo+Pgo+PiBUaGUgZHJpdmVyIGhhcyBiZWVuIHRlc3RlZCB1c2luZyBp MmMtdG9vbHMgb24gYSBCYW5hbmFwaS1GMyBib2FyZCwKPj4gYW5kIGJhc2ljIEkyQyByZWFkL3dy aXRlIG9wZXJhdGlvbnMgaGF2ZSBiZWVuIGNvbmZpcm1lZCB0byB3b3JrLgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBUcm95IE1pdGNoZWxsIDx0cm95bWl0Y2hlbGw5ODhAZ21haWwuY29tPgo+Cj4gSSBo YXZlIHNvbWUgbW9yZSBjb21tZW50cywgYW5kIHNvbWUgcXVlc3Rpb25zLsKgIEkgYXBwcmVjaWF0 ZQo+IHNlZWluZyBzb21lIG9mIHRoZSBjaGFuZ2VzIHlvdSd2ZSBtYWRlIGJhc2VkIG9uIG15IGZl ZWRiYWNrLgpIaSwgQWxleC4gVGhhbmtzIGZvciB5b3VyIHJldmlldy4KPj4gK3N0YXRpYyB2b2lk IHNwYWNlbWl0X2kyY19pbml0KHN0cnVjdCBzcGFjZW1pdF9pMmNfZGV2ICppMmMpCj4+ICt7Cj4+ ICvCoMKgwqAgdTMyIHZhbDsKPj4gKwo+PiArwqDCoMKgIC8qCj4+ICvCoMKgwqDCoCAqIFVubWFz ayBpbnRlcnJ1cHQgYml0cyBmb3IgYWxsIHhmZXIgbW9kZToKPj4gK8KgwqDCoMKgICogYnVzIGVy cm9yLCBhcmJpdHJhdGlvbiBsb3NzIGRldGVjdGVkLgo+PiArwqDCoMKgwqAgKiBGb3IgdHJhbnNh Y3Rpb24gY29tcGxldGUgc2lnbmFsLCB3ZSB1c2UgbWFzdGVyIHN0b3AKPj4gK8KgwqDCoMKgICog aW50ZXJydXB0LCBzbyB3ZSBkb24ndCBuZWVkIHRvIHVubWFzayBTUEFDRU1JVF9DUl9UWERPTkVJ RS4KPj4gK8KgwqDCoMKgICovCj4+ICvCoMKgwqAgdmFsID0gU1BBQ0VNSVRfQ1JfQkVJRSB8IFNQ QUNFTUlUX0NSX0FMRElFOwo+PiArCj4+ICvCoMKgwqAgLyoKPj4gK8KgwqDCoMKgICogVW5tYXNr IGludGVycnVwdCBiaXRzIGZvciBpbnRlcnJ1cHQgeGZlciBtb2RlOgo+PiArwqDCoMKgwqAgKiBE QlIgcnggZnVsbC4KPj4gK8KgwqDCoMKgICogRm9yIHR4IGVtcHR5IGludGVycnVwdCBTUEFDRU1J VF9DUl9EVEVJRSwgd2Ugb25seQo+PiArwqDCoMKgwqAgKiBuZWVkIHRvIGVuYWJsZSB3aGVuIHRy aWdnZXIgYnl0ZSB0cmFuc2ZlciB0byBzdGFydAo+PiArwqDCoMKgwqAgKiBkYXRhIHNlbmRpbmcu Cj4+ICvCoMKgwqDCoCAqLwo+PiArwqDCoMKgIHZhbCB8PSBTUEFDRU1JVF9DUl9EUkZJRTsKPj4g Kwo+PiArwqDCoMKgIC8qIHNldCBzcGVlZCBiaXRzOiBkZWZhdWx0IGZhc3QgbW9kZSAqLwo+Cj4g SXQgaXMgbm90ICpkZWZhdWx0KiBmYXN0IG1vZGUsIGl0ICppcyogZmFzdCBtb2RlLsKgIChUaGVy ZQo+IGlzIG5vIG90aGVyIG1vZGUgdXNlZCBpbiB0aGlzIGRyaXZlciwgcmlnaHQ/KQp5ZXMuIEkg d2lsbCB0YWxrIGl0IGJlbG93Lgo+Cj4+ICvCoMKgwqAgdmFsIHw9IFNQQUNFTUlUX0NSX01PREVf RkFTVDsKPj4gKwo+PiArwqDCoMKgIC8qIGRpc2FibGUgcmVzcG9uc2UgdG8gZ2VuZXJhbCBjYWxs ICovCj4+ICvCoMKgwqAgdmFsIHw9IFNQQUNFTUlUX0NSX0dDRDsKPj4gKwo+PiArwqDCoMKgIC8q IGVuYWJsZSBTQ0wgY2xvY2sgb3V0cHV0ICovCj4+ICvCoMKgwqAgdmFsIHw9IFNQQUNFTUlUX0NS X1NDTEU7Cj4+ICsKPj4gK8KgwqDCoCAvKiBlbmFibGUgbWFzdGVyIHN0b3AgZGV0ZWN0ZWQgKi8K Pj4gK8KgwqDCoCB2YWwgfD0gU1BBQ0VNSVRfQ1JfTVNERSB8IFNQQUNFTUlUX0NSX01TRElFOwo+ PiArCj4+ICvCoMKgwqAgd3JpdGVsKHZhbCwgaTJjLT5iYXNlICsgU1BBQ0VNSVRfSUNSKTsKPj4g K30KPj4gKwo+PiArCj4+ICtzdGF0aWMgaW50IHNwYWNlbWl0X2kyY194ZmVyX2NvcmUoc3RydWN0 IHNwYWNlbWl0X2kyY19kZXYgKmkyYykKPj4gK3sKPj4gK8KgwqDCoCBpbnQgcmV0Owo+PiArCj4+ ICvCoMKgwqAgc3BhY2VtaXRfaTJjX3Jlc2V0KGkyYyk7Cj4KPiBJIGRvbid0IGhhdmUgYSBsb3Qg b2YgZXhwZXJpZW5jZSB3aXRoIEkyQyBkcml2ZXJzLCBidXQgaXMgaXQgbm9ybWFsCj4gdG8gcmVz ZXQgYmVmb3JlIGV2ZXJ5IHRyYW5zZmVyPwo+Cj4gSWYgaXQgaXMsIGp1c3QgdGVsbCBtZSB0aGF0 LsKgIEJ1dCBpZiBpdCdzIG5vdCwgY2FuIHlvdSBleHBsYWluIHdoeQo+IGl0J3MgbmVjZXNzYXJ5 IGhlcmU/CgpNeSBpbml0aWFsIGlkZWEgd2FzIHRvIGtlZXAgdGhlIEkyQyBzdGF0ZSBpbiBpdHMg aW5pdGlhbCBzdGF0ZSBiZWZvcmUgZWFjaAp0cmFuc21pc3Npb24uwqAKCkJ1dCBhZnRlciB0ZXN0 aW5nLCB0aGlzIGlzIG5vdCBuZWNlc3NhcnkuIEkgd2lsbCBtb3ZlIGl0IHRvIGBwcm9iZWAgZnVu Y3Rpb24uCgo+Cj4+ICsKPj4gK8KgwqDCoCBzcGFjZW1pdF9pMmNfY2FsY190aW1lb3V0KGkyYyk7 Cj4+ICsKPj4gK8KgwqDCoCBzcGFjZW1pdF9pMmNfaW5pdChpMmMpOwo+PiArCj4KPiBIZXJlIHRv bywgbWF5YmUgSSBqdXN0IGRvbid0IGtub3cgd2hhdCBtb3N0IEkyQyBkcml2ZXJzIGRvLCBidXQK PiBpcyBpdCBuZWNlc3NhcnkgdG8gb25seSBlbmFibGUgdGhlIEkyQyBhZGFwdGVyIGFuZCBpdHMg aW50ZXJydXB0Cj4gaGFuZGxlciB3aGVuIHBlcmZvcm1pbmcgYSB0cmFuc2Zlcj8KCkl0IGlzIG5l Y2Vzc2FyeSB0byBlbmFibGUgYmVmb3JlIGVhY2ggdHJhbnNtaXNzaW9uLsKgCgpJIGhhdmUgdGVz dGVkIG1vdmluZyB0aGUgYHNwYWNlbWl0X2kyY19lbmFibGVgIHRvIHRoZSBwcm9iZSBmdW5jdGlv bi7CoAoKSXQgd2lsbCBjYXVzZSB0cmFuc21pc3Npb24gZXJyb3JzLgoKQXMgZm9yIHRoZSBgZW5h YmxlX2lycWAsIEkgdGhpbmsgaXQgY2FuIGJlIG1vdmVkIHRvIHRoZSBgcHJvYmVgIGZ1bmN0aW9u LgoKPgo+PiArwqDCoMKgIHNwYWNlbWl0X2kyY19lbmFibGUoaTJjKTsKPj4gK8KgwqDCoCBlbmFi bGVfaXJxKGkyYy0+aXJxKTsKPj4gKwo+PiArwqDCoMKgIC8qIGkyYyB3YWl0IGZvciBidXMgYnVz eSAqLwo+PiArwqDCoMKgIHJldCA9IHNwYWNlbWl0X2kyY19yZWNvdmVyX2J1c19idXN5KGkyYyk7 Cj4+ICvCoMKgwqAgaWYgKHJldCkKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+ICsK Pj4gK8KgwqDCoCByZXQgPSBzcGFjZW1pdF9pMmNfeGZlcl9tc2coaTJjKTsKPj4gK8KgwqDCoCBp ZiAocmV0IDwgMCkKPj4gK8KgwqDCoMKgwqDCoMKgIGRldl9kYmcoaTJjLT5kZXYsICJpMmMgdHJh bnNmZXIgZXJyb3JcbiIpOwo+Cj4gSWYgeW91J3JlIHJlcG9ydGluZyB0aGUgZXJyb3IgeW91IG1p Z2h0IGFzIHdlbGwgc2F5IHdoYXQKPiBpdCBpcy4KPgo+IMKgwqDCoMKgZGV2X2RiZyhpMmMtPmRl diwgImkyYyB0cmFuc2ZlciBlcnJvcjogJWRcbiIsIHJldCk7Cj4KPj4gKwo+PiArwqDCoMKgIHJl dHVybiByZXQ7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBpbnQgc3BhY2VtaXRfaTJjX3hmZXIoc3Ry dWN0IGkyY19hZGFwdGVyICphZGFwdCwgc3RydWN0IGkyY19tc2cKPj4gKm1zZ3MsIGludCBudW0p Cj4+ICt7Cj4+ICvCoMKgwqAgc3RydWN0IHNwYWNlbWl0X2kyY19kZXYgKmkyYyA9IGkyY19nZXRf YWRhcGRhdGEoYWRhcHQpOwo+PiArwqDCoMKgIGludCByZXQ7Cj4+ICvCoMKgwqAgdTMyIGVyciA9 IFNQQUNFTUlUX0kyQ19HRVRfRVJSKGkyYy0+c3RhdHVzKTsKPj4gKwo+PiArwqDCoMKgIGkyYy0+ bXNncyA9IG1zZ3M7Cj4+ICvCoMKgwqAgaTJjLT5tc2dfbnVtID0gbnVtOwo+PiArCj4+ICvCoMKg wqAgcmV0ID0gc3BhY2VtaXRfaTJjX3hmZXJfY29yZShpMmMpOwo+PiArwqDCoMKgIGlmICghcmV0 KQo+PiArwqDCoMKgwqDCoMKgwqAgc3BhY2VtaXRfaTJjX2NoZWNrX2J1c19yZWxlYXNlKGkyYyk7 Cj4+ICsKPgo+IFRoZSBlbmFibGVfaXJxKCkgY2FsbCB0aGF0IG1hdGNoZXMgdGhlIGRpc2FibGUg Y2FsbCBiZWxvdyBpcwo+IGZvdW5kIGluIHNwYWNlbWl0X2kyY194ZmVyX2NvcmUoKS7CoCBUaGF0 J3Mgd2hlcmUgdGhpcyBjYWxsCj4gYmVsb25ncy4KPgo+PiArwqDCoMKgIGRpc2FibGVfaXJxKGky Yy0+aXJxKTsKPj4gKwo+Cj4gU2FtZSB3aXRoIHRoZSBuZXh0IGNhbGwtLWl0IHNob3VsZCBiZSBp biB0aGUgc2FtZSBmdW5jdGlvbgo+IHRoYXQgaXRzIGNvcnJlc3BvbmRpbmcgc3BhY2VtaXRfaTJj X2VuYWJsZSgpIGlzIGNhbGxlZC4KPgo+IFdpdGggdGhlc2Ugc3VnZ2VzdGlvbnMgaW4gbWluZCwg SSB0aGluayB5b3UgY2FuIHNhZmVseQo+IGp1c3QgZ2V0IHJpZCBvZiBzcGFjZW1pdF9pMmNfeGZl cl9jb3JlKCkuwqAgSXQgaXMgb25seQo+IGNhbGxlZCBpbiB0aGlzIG9uZSBzcG90IChhYm92ZSks IGFuZCB5b3UgY2FuIGp1c3QgZG8KPiBldmVyeXRoaW5nIHdpdGhpbiBzcGFjZW1pdF9pMmNfeGZl cigpIGluc3RlYWQuCj4KPj4gK8KgwqDCoCBzcGFjZW1pdF9pMmNfZGlzYWJsZShpMmMpOwo+PiAr Cj4+ICvCoMKgwqAgaWYgKHJldCA9PSAtRVRJTUVET1VUIHx8IHJldCA9PSAtRUFHQUlOKQo+PiAr wqDCoMKgwqDCoMKgwqAgZGV2X2FsZXJ0KGkyYy0+ZGV2LCAiaTJjIHRyYW5zZmVyIGZhaWxlZCwg cmV0ICVkIGVyciAweCV4XG4iLCByZXQsCj4+IGVycik7Cj4+ICsKPj4gK8KgwqDCoCByZXR1cm4g cmV0IDwgMCA/IHJldCA6IG51bTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHUzMiBzcGFjZW1pdF9p MmNfZnVuYyhzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFkYXApCj4+ICt7Cj4+ICvCoMKgwqAgcmV0dXJu IEkyQ19GVU5DX0kyQyB8IChJMkNfRlVOQ19TTUJVU19FTVVMICYgfkkyQ19GVU5DX1NNQlVTX1FV SUNLKTsKPj4gK30KPj4gKwo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBpMmNfYWxnb3JpdGhtIHNw YWNlbWl0X2kyY19hbGdvID0gewo+PiArwqDCoMKgIC54ZmVyID0gc3BhY2VtaXRfaTJjX3hmZXIs Cj4+ICvCoMKgwqAgLmZ1bmN0aW9uYWxpdHkgPSBzcGFjZW1pdF9pMmNfZnVuYywKPj4gK307Cj4+ ICsKPj4gK3N0YXRpYyBpbnQgc3BhY2VtaXRfaTJjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4+ICt7Cj4+ICvCoMKgwqAgc3RydWN0IGNsayAqY2xrOwo+PiArwqDCoMKgIHN0 cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9u b2RlICpvZl9ub2RlID0gcGRldi0+ZGV2Lm9mX25vZGU7Cj4+ICvCoMKgwqAgc3RydWN0IHNwYWNl bWl0X2kyY19kZXYgKmkyYzsKPj4gK8KgwqDCoCBpbnQgcmV0ID0gMDsKPgo+IFRoZXJlIGlzIG5v IG5lZWQgdG8gaW5pdGlhbGl6ZSByZXQuCj4KPj4gKwo+PiArwqDCoMKgIGkyYyA9IGRldm1fa3ph bGxvYyhkZXYsIHNpemVvZigqaTJjKSwgR0ZQX0tFUk5FTCk7Cj4+ICvCoMKgwqAgaWYgKCFpMmMp Cj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVOT01FTTsKPj4gKwo+PiArwqDCoMKgIHJldCA9 IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG9mX25vZGUsICJjbG9jay1mcmVxdWVuY3kiLCAmaTJjLT5j bG9ja19mcmVxKTsKPj4gK8KgwqDCoCBpZiAocmV0KQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJu IGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJmYWlsZWQgdG8gcmVhZCBjbG9jay1mcmVxdWVuY3kK Pj4gcHJvcGVydHkiKTsKPj4gKwo+PiArwqDCoMKgIC8qIEZvciBub3csIHRoaXMgZHJpdmVyIGRv ZXNuJ3Qgc3VwcG9ydCBoaWdoLXNwZWVkLiAqLwo+PiArwqDCoMKgIGlmIChpMmMtPmNsb2NrX2Zy ZXEgPCAxIHx8IGkyYy0+Y2xvY2tfZnJlcSA+IDQwMDAwMCkgewo+Cj4gSW4geW91ciBkZXZpY2Ug dHJlZSBiaW5kaW5nLCB5b3UgaW5kaWNhdGUgdGhhdCB0aHJlZSBkaWZmZXJlbnQKPiBtb2RlcyBh cmUgc3VwcG9ydGVkLCBhbmQgdGhhdCB0aGUgbWF4aW11bSBmcmVxdWVuY3kgaXMgMzMwMDAwMCBI ei4KPiBUaGlzIHNheXMgdGhhdCBvbmx5IHJhbmdlcyBmcm9tIDEtNDAwMDAwIEh6IGFyZSBhbGxv d2VkLgo+Cj4gSW4gZmFjdCwgYWx0aG91Z2ggeW91IGxvb2sgdXAgdGhpcyBjbG9jayBmcmVxdWVu Y3kgaW4gRFQsIEkgc2VlCj4gbm90aGluZyB0aGF0IGFjdHVhbGx5IGlzIGFmZmVjdGVkIGJ5IHRo aXMgdmFsdWUuwqAgSS5lLiwgbm8gSTJDCj4gYnVzIGZyZXF1ZW5jeSBjaGFuZ2VzLCByZWdhcmRs ZXNzIG9mIHdoYXQgZnJlcXVlbmN5IHlvdSBzcGVjaWZ5Lgo+IFRoZSBvbmx5IHBsYWNlIHRoZSBj bG9ja19mcmVxIGZpZWxkIGlzIHVzZWQgaXMgaW4gY2FsY3VsYXRpbmcKPiB0aGUgdGltZW91dCBm b3IgYSB0cmFuc2Zlci4KPgo+IFNvIHR3byB0aGluZ3M6Cj4gLSBNeSBndWVzcyBpcyB0aGF0IHlv dSBhcmUgcmVseWluZyBvbiB3aGF0ZXZlciBmcmVxdWVuY3kgdGhlCj4gwqAgaGFyZHdhcmUgYWxy ZWFkeSBpcyB1c2luZywgYW5kIG1heWJlIHRoYXQncyA0MDAwMDAgSHouCj4gwqAgVGhhdCdzIGZp bmUsIHRob3VnaCBhdCBzb21lIHBvaW50IGl0IHNob3VsZCBiZSBtb3JlCj4gwqAgZGlyZWN0bHkg Y29udHJvbGxlZCAoc2V0IHNvbWVob3cpLgo+IC0gU2luY2UgeW91IGRvbid0IGFjdHVhbGx5IHN1 cHBvcnQgYW55IG90aGVyIGZyZXF1ZW5jeSwKPiDCoCBkcm9wIHRoaXMgImNsb2NrLWZyZXF1ZW5j eSIgZmVhdHVyZSBmb3Igbm93LCBhbmQgYWRkIGl0Cj4gwqAgd2hlbiB5b3UncmUgcmVhZHkgdG8g YWN0dWFsbHkgc3VwcG9ydCBpdC4KPgo+IEFuZCBJIG1pZ2h0IGJlIHdyb25nIGFib3V0IHRoaXMs IGJ1dCBJIGRvbid0IHRoaW5rIHlvdXIKPiAobmV3KSBEVFMgYmluZGluZyBzaG91bGQgc3BlY2lm eSBiZWhhdmlvciB0aGF0IGlzIG5vdAo+IHN1cHBvcnRlZCBieSB0aGUgZHJpdmVyLgo+Cj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLUFsZXgKCkkgd2lsbCBzdXBwb3J0 IHN0YW5kYXJkIG1vZGUgaW4gbmV4dCB2ZXJzaW9uLgoKV2UganVzdCBuZWVkIHRvIG1vZGlmeSB0 aGUgZnVuY3Rpb24gYHNwYWNlbWl0X2kyY19pbml0YC4KCj4KPj4gK8KgwqDCoMKgwqDCoMKgIGRl dl93YXJuKGRldiwgInVuc3VwcG9ydCBjbG9jayBmcmVxdWVuY3k6ICVkLCBkZWZhdWx0OiA0MDAw MDAiLAo+PiBpMmMtPmNsb2NrX2ZyZXEpOwo+PiArwqDCoMKgwqDCoMKgwqAgaTJjLT5jbG9ja19m cmVxID0gNDAwMDAwOwo+PiArwqDCoMKgIH0KPj4gKwo+PiArwqDCoMKgIGkyYy0+ZGV2ID0gJnBk ZXYtPmRldjsKPj4gKwo+PiArwqDCoMKgIGkyYy0+YmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1h cF9yZXNvdXJjZShwZGV2LCAwKTsKPj4gK8KgwqDCoCBpZiAoSVNfRVJSKGkyYy0+YmFzZSkpCj4+ ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIoaTJjLT5i YXNlKSwgImZhaWxlZCB0byBkbyBpb3JlbWFwIik7Cj4+ICsKPj4gK8KgwqDCoCBpMmMtPmlycSA9 IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7Cj4+ICvCoMKgwqAgaWYgKGkyYy0+aXJxIDwgMCkK Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgaTJjLT5pcnEsICJm YWlsZWQgdG8gZ2V0IGlycSByZXNvdXJjZSIpOwo+PiArCj4+ICvCoMKgwqAgcmV0ID0gZGV2bV9y ZXF1ZXN0X2lycShpMmMtPmRldiwgaTJjLT5pcnEsIHNwYWNlbWl0X2kyY19pcnFfaGFuZGxlciwK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBJUlFGX05PX1NVU1BFTkQg fCBJUlFGX09ORVNIT1QsIGRldl9uYW1lKGkyYy0+ZGV2KSwgaTJjKTsKPj4gK8KgwqDCoCBpZiAo cmV0KQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJm YWlsZWQgdG8gcmVxdWVzdCBpcnEiKTsKPj4gKwo+PiArwqDCoMKgIGRpc2FibGVfaXJxKGkyYy0+ aXJxKTsKPj4gKwo+PiArwqDCoMKgIGNsayA9IGRldm1fY2xrX2dldF9lbmFibGVkKGRldiwgImFw YiIpOwo+PiArwqDCoMKgIGlmIChJU19FUlIoY2xrKSkKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVy biBkZXZfZXJyX3Byb2JlKGRldiwgUFRSX0VSUihjbGspLCAiZmFpbGVkIHRvIGVuYWJsZSBhcGIg Y2xvY2siKTsKPj4gKwo+PiArwqDCoMKgIGNsayA9IGRldm1fY2xrX2dldF9lbmFibGVkKGRldiwg InR3c2kiKTsKPj4gK8KgwqDCoCBpZiAoSVNfRVJSKGNsaykpCj4+ICvCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIoY2xrKSwgImZhaWxlZCB0byBlbmFibGUg dHdzaSBjbG9jayIpOwo+PiArCj4+ICvCoMKgwqAgaTJjX3NldF9hZGFwZGF0YSgmaTJjLT5hZGFw dCwgaTJjKTsKPj4gK8KgwqDCoCBpMmMtPmFkYXB0Lm93bmVyID0gVEhJU19NT0RVTEU7Cj4+ICvC oMKgwqAgaTJjLT5hZGFwdC5hbGdvID0gJnNwYWNlbWl0X2kyY19hbGdvOwo+PiArwqDCoMKgIGky Yy0+YWRhcHQuZGV2LnBhcmVudCA9IGkyYy0+ZGV2Owo+PiArwqDCoMKgIGkyYy0+YWRhcHQubnIg PSBwZGV2LT5pZDsKPj4gKwo+PiArwqDCoMKgIGkyYy0+YWRhcHQuZGV2Lm9mX25vZGUgPSBvZl9u b2RlOwo+PiArwqDCoMKgIGkyYy0+YWRhcHQuYWxnb19kYXRhID0gaTJjOwo+PiArCj4+ICvCoMKg wqAgc3Ryc2NweShpMmMtPmFkYXB0Lm5hbWUsICJzcGFjZW1pdC1pMmMtYWRhcHRlciIsIHNpemVv ZihpMmMtPmFkYXB0Lm5hbWUpKTsKPj4gKwo+PiArwqDCoMKgIGluaXRfY29tcGxldGlvbigmaTJj LT5jb21wbGV0ZSk7Cj4+ICsKPj4gK8KgwqDCoCBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBp MmMpOwo+PiArCj4+ICvCoMKgwqAgcmV0ID0gaTJjX2FkZF9udW1iZXJlZF9hZGFwdGVyKCZpMmMt PmFkYXB0KTsKPj4gK8KgwqDCoCBpZiAocmV0KQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGRl dl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgcmV0LCAiZmFpbGVkIHRvIGFkZCBpMmMgYWRhcHRlciIp Owo+PiArCj4+ICvCoMKgwqAgcmV0dXJuIDA7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIHNw YWNlbWl0X2kyY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4gK3sKPj4g K8KgwqDCoCBzdHJ1Y3Qgc3BhY2VtaXRfaTJjX2RldiAqaTJjID0gcGxhdGZvcm1fZ2V0X2RydmRh dGEocGRldik7Cj4+ICsKPj4gK8KgwqDCoCBpMmNfZGVsX2FkYXB0ZXIoJmkyYy0+YWRhcHQpOwo+ PiArfQo+PiArCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBzcGFjZW1pdF9p MmNfb2ZfbWF0Y2hbXSA9IHsKPj4gK8KgwqDCoCB7IC5jb21wYXRpYmxlID0gInNwYWNlbWl0LGsx LWkyYyIsIH0sCj4+ICvCoMKgwqAgeyAvKiBzZW50aW5lbCAqLyB9Cj4+ICt9Owo+PiArTU9EVUxF X0RFVklDRV9UQUJMRShvZiwgc3BhY2VtaXRfaTJjX29mX21hdGNoKTsKPj4gKwo+PiArc3RhdGlj IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgc3BhY2VtaXRfaTJjX2RyaXZlciA9IHsKPj4gK8KgwqDC oCAucHJvYmUgPSBzcGFjZW1pdF9pMmNfcHJvYmUsCj4+ICvCoMKgwqAgLnJlbW92ZSA9IHNwYWNl bWl0X2kyY19yZW1vdmUsCj4+ICvCoMKgwqAgLmRyaXZlciA9IHsKPj4gK8KgwqDCoMKgwqDCoMKg IC5uYW1lID0gImkyYy1rMSIsCj4+ICvCoMKgwqDCoMKgwqDCoCAub2ZfbWF0Y2hfdGFibGUgPSBz cGFjZW1pdF9pMmNfb2ZfbWF0Y2gsCj4+ICvCoMKgwqAgfSwKPj4gK307Cj4+ICttb2R1bGVfcGxh dGZvcm1fZHJpdmVyKHNwYWNlbWl0X2kyY19kcml2ZXIpOwo+PiArCj4+ICtNT0RVTEVfTElDRU5T RSgiR1BMIik7Cj4+ICtNT0RVTEVfREVTQ1JJUFRJT04oIkkyQyBidXMgZHJpdmVyIGZvciBTcGFj ZW1pVCBLMSBTb0MiKTsKPj4KPgotLSAKVHJveSBNaXRjaGVsbAoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAps aW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK