Re: [PATCH 8/8] i386/cpu: Enable 0x1f leaf for SapphireRapids by default

["Mi, Dapeng" <dapeng1.mi@linux.intel.com>]

On 6/26/2025 4:31 PM, Zhao Liu wrote:
> Host SapphireRapids CPU has 0x1f leaf by default, so that enable it for
> Guest CPU by default as well.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Changes since RFC:
>  * Rename the property to "x-force-cpuid-0x1f". (Igor)
> ---
>  target/i386/cpu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index acf7e0de184d..c7f157a0f71c 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -5084,8 +5084,11 @@ static const X86CPUDefinition builtin_x86_defs[] = {
>              },
>              {
>                  .version = 4,
> -                .note = "with spr-sp cache model",
> +                .note = "with spr-sp cache model and 0x1f leaf",

ditto.

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>



>                  .cache_info = &xeon_spr_cache_info,
> +                .props = (PropValue[]) {
> +                    { "x-force-cpuid-0x1f", "on" },
> +                }
>              },
>              { /* end of list */ }
>          }