From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] nvme: default to 0 poll queues
Date: Mon, 19 Nov 2018 08:18:52 -0700 [thread overview]
Message-ID: <74ea552a-d942-b741-e85a-b3d3bc4dc2b2@kernel.dk> (raw)
In-Reply-To: <20181119075737.GA10256@lst.de>
On 11/19/18 12:57 AM, Christoph Hellwig wrote:
> On Sat, Nov 17, 2018@10:06:20AM -0700, Jens Axboe wrote:
>> We need a better way of configuring this, and given that
>> polling is (still) a bit niche, let's default to using
>> 0 poll queues. That way we'll have the same read/write/poll
>> behavior as 4.20, and users that want to test/use polling
>> are required to do manual configuration of the number of
>> poll queues.
>>
>> Signed-off-by: Jens Axboe <axboe at kernel.dk>
>
> Looks good (except that you could use more of each line for the
> commit log).
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> Given that the poll queues were introduced in the block tree, can you
> queue it up there?
Yep will do, stretched to 72 as well :-)
--
Jens Axboe
next prev parent reply other threads:[~2018-11-19 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 17:06 [PATCH] nvme: default to 0 poll queues Jens Axboe
2018-11-19 7:57 ` Christoph Hellwig
2018-11-19 15:18 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-09 0:49 Guenter Roeck
2018-12-09 5:38 ` Jens Axboe
2018-12-09 5:38 ` Jens Axboe
2018-12-09 6:22 ` Guenter Roeck
2018-12-09 6:22 ` Guenter Roeck
2018-12-09 6:31 ` Jens Axboe
2018-12-09 6:31 ` Jens Axboe
2018-12-09 7:32 ` Guenter Roeck
2018-12-09 7:32 ` Guenter Roeck
2018-12-09 18:18 ` Jens Axboe
2018-12-09 18:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ea552a-d942-b741-e85a-b3d3bc4dc2b2@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.