From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "lihuisong (C)" <lihuisong@huawei.com>,
Jie Hai <haijie1@huawei.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Shiyang He <shiyangx.he@intel.com>,
"Jiale, SongX" <songx.jiale@intel.com>
Cc: dev@dpdk.org, liudongdong3@huawei.com, alialnu@nvidia.com,
"Mcnamara, John" <john.mcnamara@intel.com>,
Qi Z Zhang <qi.z.zhang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port
Date: Wed, 5 Jul 2023 09:02:37 +0100 [thread overview]
Message-ID: <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> (raw)
In-Reply-To: <da3e4ff4-350f-42da-3725-acbbf1570e88@huawei.com>
On 7/5/2023 4:16 AM, lihuisong (C) wrote:
>
> 在 2023/7/4 18:59, Ferruh Yigit 写道:
>> On 7/4/2023 9:45 AM, Jie Hai wrote:
>>> Function update_queue_state updates queue state of all queues
>>> of all ports, using the queue num nb_rxq|nb_txq stored locally
>>> by testpmd. An error on the invalid queue ID occurs if we run
>>> testpmd with two ports and detach-attach one of them and start
>>> the other port first. This is because the attached port has not
>>> been configured and has no queues, which differs from nb_rxq|nb_txq.
>>> The similar error happens in multi-process senoris if secondary
>>> process attaches a port and starts it.
>>>
>>> This patch updates queue state of the specified port, which has
>>> been configured by primary process. As the secondary process
>>> cannot configure the ports, make sure that the secondary process
>>> starts the port only after the primary process has done so.
> Now look good to me.
> Acked-by: Huisong Li <lihuisong@huawei.com>
>>>
>>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling
>>> all queues")
>>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
>>> forwarding")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>>
>> The problem description and solution looks reasonable to me, but Intel
>> testing still reporting the issue.
>>
>> There is a chance that the issue Intel side observing is different,
>> waiting for more information from Intel test team.
>>
>> .
Hi Song,
As far as I understand this patch works with an update from ixgbevf
driver, can you please confirm?
And can we have the ixgbevf fix soon, to not block the -rc3?
Thanks,
ferruh
next prev parent reply other threads:[~2023-07-05 8:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:02 [PATCH] app/testpmd: fix invalid queue ID when start port Jie Hai
2023-07-03 12:33 ` Ali Alnubani
2023-07-04 2:01 ` Jie Hai
2023-07-04 2:22 ` lihuisong (C)
2023-07-04 8:45 ` [PATCH v2] " Jie Hai
2023-07-04 9:16 ` Ali Alnubani
2023-07-04 9:42 ` fengchengwen
2023-07-04 10:59 ` Ferruh Yigit
2023-07-05 3:16 ` lihuisong (C)
2023-07-05 8:02 ` Ferruh Yigit [this message]
2023-07-05 8:07 ` Ferruh Yigit
2023-07-05 9:40 ` lihuisong (C)
2023-07-05 11:41 ` Ferruh Yigit
2023-07-06 2:48 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=alialnu@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haijie1@huawei.com \
--cc=john.mcnamara@intel.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=qi.z.zhang@intel.com \
--cc=shiyangx.he@intel.com \
--cc=songx.jiale@intel.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.