From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB2CC433DF for ; Wed, 19 Aug 2020 20:50:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B0322083B for ; Wed, 19 Aug 2020 20:50:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yAEYEK4F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PX5Mjhu0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B0322083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gjuwcKkHo7k4LdIbXIbyO3AVhIC13sZuoIIJ4pPq/X8=; b=yAEYEK4FnD0DxzkfzooQezhVN aPnwd5CPnc4mnSq0A5bh6cpw+dfTAPKU9nh2OcaTj3ALXqKmuF+FURJ4cNtDlb2Mp3OqwPnhJHj72 DVVrmT7ve1NfwogucdKzzAbBPwPZvRLoA4R2wqX1KpkCSv1VbZ3nUpX8jWjF5dJHFsxdiHzRViP9t vD/53pXA2HsTErmgX4JVsGxvplTkda49SCqTXN8XKn1CyNzl1cGhfjJxfFIIphX5Ovuv9y8l/KDx+ 5gYEeZxe6lwN1vA3RyfDM9jb8roEVhUV8uPt79vdiHuh8C+N4Xblovw0OlNOg68bY3wbRmdoQW8NY k7Z75GVSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8V0n-00022p-CM; Wed, 19 Aug 2020 20:48:45 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8V0k-00021k-II for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 20:48:43 +0000 Received: by mail-ed1-x543.google.com with SMTP id i6so19222368edy.5 for ; Wed, 19 Aug 2020 13:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mdnZglwI4EjvNb/esSyk9gVq6ig88nPzaI7IUsXkz/Y=; b=PX5Mjhu03HyeYYhfatP1x50gNnSApx04aOGnQcg36XJxZhpwXgNNt5k2SqYRFRdfLZ tbTrp0sqEw9dPDVMhD/kRlsu3n9pF73WzpwobOfh926j7oQWkwst7L2+Yq2mTwGmTQYq +D5yZTEVp3FWmB9Zxc1+CvUNaXx2SMVGCHburPSYGEbzAf0QLfqWVugoQEQZqnFZ4XC+ slcXjXXeSkwIb4agMPWRJDAo4e4MaOf2bdheY9PgJ295nhMn2P6+Ef4dsVCM8lp/dlle JinNx31bdaahLStC8hx+TMzHUO7Zqptp1yD0kjToMxWXsP2YOWlWFzZpMjFGQQHcx9Mc 6SGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mdnZglwI4EjvNb/esSyk9gVq6ig88nPzaI7IUsXkz/Y=; b=a14bPZEuqbfXB8M9yxoAJUq16MXCWdAsWbM9oxbVbXDF5GaqOwDaqvAjcPNTgoqUDp hBVED+GUufL6szV1T8MCY9x42uwtmuuG0muhpzs1vrIPRDR2034CvQqvJ+lEuF/KgaaR J+kqsfjfjpXarvJ5QQ4/rDjO+aCjaP1MvKuX9u+poRitih73I8ZquiJrZeojpaBwhphc jiLQksjyOIXkWWtc4tbSx6vVvbZ3RQwPLLUQzRh4CzTdqa4ZkcqKF7osQ7kk2rVd2blm v6tgZkHD2i5TPE3cbgjwGFCwGKcayNideNSdxDSr7iXRXFqSJBoWDMDb2h8VzVSSIVy+ cAXg== X-Gm-Message-State: AOAM533nnApbHOeK/4N15CV45LO1OEdtqFLEqq2xp33TquW2LPaV2z8i h192c9bBQVKnpkA2omvMfts= X-Google-Smtp-Source: ABdhPJx1mnImvIxu6eqtbKhO+TId8N68r59WzshKC5S78XgfC+g8tY+6DqAe34oWDS6x54ifvveFkA== X-Received: by 2002:a05:6402:1430:: with SMTP id c16mr25995987edx.144.1597870119863; Wed, 19 Aug 2020 13:48:39 -0700 (PDT) Received: from debian64.daheim (pd9e294f0.dip0.t-ipconnect.de. [217.226.148.240]) by smtp.gmail.com with ESMTPSA id b9sm20368932ejz.57.2020.08.19.13.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 13:48:38 -0700 (PDT) Received: from localhost.daheim ([127.0.0.1]) by debian64.daheim with esmtp (Exim 4.94) (envelope-from ) id 1k8V0d-001EXU-R2; Wed, 19 Aug 2020 22:48:35 +0200 Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node To: Florian Fainelli , linux-arm-kernel@lists.infradead.org References: <20200819042308.19043-1-f.fainelli@gmail.com> From: Christian Lamparter Message-ID: <7501cb2f-ea5a-8339-40a0-6706fea32a06@gmail.com> Date: Wed, 19 Aug 2020 22:48:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200819042308.19043-1-f.fainelli@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_164842_628691_F8DC3EA9 X-CRM114-Status: GOOD ( 27.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Rob Herring , "maintainer:BROADCOM BCM5301X ARM ARCHITECTURE" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wOC0xOSAwNjoyMywgRmxvcmlhbiBGYWluZWxsaSB3cm90ZToKPiBUaGUgcGluIGNv bnRyb2xsZXIgcmVzb3VyY2VzIHN0YXJ0IGF0IDB4YzAgZnJvbSB0aGUgQ1JVIGJhc2Ugd2hpY2gg aXMgYXQKPiAweDEwMCBmcm9tIHRoIERNVSBiYXNlLCBmb3IgYSBmaW5hbCBhZGRyZXNzIG9mIDB4 MTgwMF9jMWMwLCB3aGVyZWFzIHdlCj4gYXJlIGN1cnJlbnRseSBvZmYgYnkgMHgxMDAuIFRoZSBy ZXNvdXJjZSBzaXplIG9mIHRoZSBDUlUgaXMgYWxzbwo+IGluY29ycmVjdCBhbmQgc2hvdWxkIGVu ZCBhdCAweDI0OCBieXRlcyBmcm9tIDB4MTAwIHdoaWNoIGlzIHRoZSBzdGFydAo+IGFkZHJlc3Mu IEZpbmFsbHksIHRoZSBjb21wYXRpYmlsaXR5IHN0cmluZ3MgZGVmaW5lZCBmb3IgdGhlCj4gcGlu LWNvbnRyb2xsZXIgbm9kZSBzaG91bGQgcmVmbGVjdCB0aGUgU29DIGJlaW5nIHVzZWQuCj4gCj4g Rml4ZXM6IDk5OTQyNDFhYzk3YyAoIkFSTTogZHRzOiBCQ001MzAxWDogRGVzY3JpYmUgTm9ydGhz dGFyIHBpbnMgbXV4IGNvbnRyb2xsZXIiKQo+IFJlcG9ydGVkLWJ5OiBDaHJpc3RpYW4gTGFtcGFy dGVyIDxjaHVua2VleUBnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRmxvcmlhbiBGYWluZWxs aSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+Cj4gLS0tCj4gQ2hyaXN0aWFuLCBjYW4geW91IHRlc3Qg dGhpcyBhcyBhIHByZWxpbWluYXJ5IHBhdGNoIGZvciB5b3VyIENpc2NvCj4gTWVyYWtpIE1SMzIg c2VyaWVzPyBUaGFua3MhCgpIbSwgaXQgbG9va3MgbGlrZSB0aGlzIGlzIG1vcmUgY29tcGxpY2F0 ZWQgdGhhbiB0aGlzLiBXZSBzaG91bGQgaGF2ZSAKbG9va2VkIGF0IHBpbmN0cmwtbnMuYydzIG5z X3BpbmN0cmxfcHJvYmUoKSBbMF0gYmVmb3JlIGNhbGxpbmcgaXQuCgp8CW5zX3BpbmN0cmwtPnJl Z21hcCA9IHN5c2Nvbl9ub2RlX3RvX3JlZ21hcChvZl9nZXRfcGFyZW50KG5wKSk7CnwJaWYgKElT X0VSUihuc19waW5jdHJsLT5yZWdtYXApKSB7CnwJCWludCBlcnIgPSBQVFJfRVJSKG5zX3BpbmN0 cmwtPnJlZ21hcCk7CnwKfAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbWFwIHBpbmN0cmwgcmVn czogJWRcbiIsIGVycik7CnwKfAkJcmV0dXJuIGVycjsKfAl9CnwKfAlpZiAob2ZfcHJvcGVydHlf cmVhZF91MzIobnAsICJvZmZzZXQiLCAmbnNfcGluY3RybC0+b2Zmc2V0KSkgewp8CQlkZXZfZXJy KGRldiwgIkZhaWxlZCB0byBnZXQgcmVnaXN0ZXIgb2Zmc2V0XG4iKTsKfAkJcmV0dXJuIC1FTk9F TlQ7CnwJfQoKU28sIHRoZSBuc19waW5jdHJsX3Byb2JlKCkgdGFrZXMgdGhlIGFkZHJlc3Mgb2Yg dGhlIHBhcmVudCBub2RlIChjcnUpCmFuZCB0aGVuIGxvb2tzIGZvciBhICJvZmZzZXQiIHByb3Bl cnR5IHRvIGFkZCB0byB0aGlzICh3aGljaCBpcyBtaXNzaW5nCmluIHRoZSBiY201MzAxeC5kdHNp IFsxXSkuCgpUaGluZyBpcywgZm9yIHRoaXMgdG8gd29yaywgdGhlIHBhcmVudC1ub2RlIHNob3Vs ZCBiZSBhICJzaW1wbGUtbWZkIiAoc28gCmEgcmVnbWFwIGlzIGNyZWF0ZWQgZm9yIHRoZSByZWcp LCByaWdodD8gVGhpcyB3b3VsZCBhbHNvIG1lYW4gdGhhdCB0aGUgCiJyZWciIHByb3BlcnR5IGlu IHRoZSBwaW4tY29udHJvbGxlciBub2RlIGlzIGp1c3QgY29zbWV0aWMuCgpJIGd1ZXNzIHRoZSBy ZWFzb24gd2h5IHRoaXMgc29ydC1vZi13b3JrcyBmb3IgbWUgaXMgYmVjYXVzZSBJJ20gdXNpbmcg CnRoaXMgTVIzMiB3aXRoIE9wZW5XcnQgKFJhZmHFgiBNacWCZWNraSBpcyBwcm9iYWJseSB1c2lu ZyBpdCB0b28gOykgKS4KCihOb3RlOiBXZSBzaG91bGQgbm90IGZvcmdldCB0byB1cGRhdGUgdGhl IGJpbmRpbmctZG9jdW1lbnRhdGlvbiBhcyB3ZWxsISkKCkJUVzogSSdsbCByZXBseSBteSBmaW5k aW5ncyBmb3IgdGhlIGkyYyBpc3N1ZSB3aXRoIHRoZSBNUjMyIGluIHRoZSBvdGhlciAKbWFpbC4K Cj4gCj4gICBhcmNoL2FybS9ib290L2R0cy9iY200NzA4LmR0c2kgIHwgNCArKysrCj4gICBhcmNo L2FybS9ib290L2R0cy9iY200NzA5LmR0c2kgIHwgNCArKysrCj4gICBhcmNoL2FybS9ib290L2R0 cy9iY201MzAxeC5kdHNpIHwgOCArKysrLS0tLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290 L2R0cy9iY200NzA4LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9iY200NzA4LmR0c2kKPiBpbmRl eCAxYTE5ZTk3YTk4N2QuLjUwNjRmZTUxZTQwMiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290 L2R0cy9iY200NzA4LmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9iY200NzA4LmR0c2kK PiBAQCAtNDMsNiArNDMsMTAgQEAgY3B1QDEgewo+ICAgCj4gICB9Owo+ICAgCj4gKyZwaW5jdHJs IHsKPiArCWNvbXBhdGlibGUgPSAiYnJjbSxiY200NzA4LXBpbm11eCI7Cj4gK307Cj4gKwo+ICAg JnVhcnQwIHsKPiAgIAlzdGF0dXMgPSAib2theSI7Cj4gICB9Owo+IGRpZmYgLS1naXQgYS9hcmNo L2FybS9ib290L2R0cy9iY200NzA5LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9iY200NzA5LmR0 c2kKPiBpbmRleCBlMWJiODY2MTk1NWYuLjc0MTdjMjc1ZWE5ZCAxMDA2NDQKPiAtLS0gYS9hcmNo L2FybS9ib290L2R0cy9iY200NzA5LmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9iY200 NzA5LmR0c2kKPiBAQCAtNSw2ICs1LDEwIEBACj4gICAKPiAgICNpbmNsdWRlICJiY200NzA4LmR0 c2kiCj4gICAKPiArJnBpbmN0cmwgewo+ICsJY29tcGF0aWJsZSA9ICJicmNtLGJjbTQ3MDktcGlu bXV4IjsKPiArfTsKPiArCj4gICAmdWFydDAgewo+ICAgCWNsb2NrLWZyZXF1ZW5jeSA9IDwxMjUw MDAwMDA+Owo+ICAgCXN0YXR1cyA9ICJva2F5IjsKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9v dC9kdHMvYmNtNTMwMXguZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL2JjbTUzMDF4LmR0c2kKPiBp bmRleCAyZDliNGRkMDU4MzAuLmJmNDk5NDNmNTA0YSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9i b290L2R0cy9iY201MzAxeC5kdHNpCj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMXgu ZHRzaQo+IEBAIC00MDIsMTQgKzQwMiwxNCBAQCBkbXVAMTgwMGMwMDAgewo+ICAgCj4gICAJCWNy dUAxMDAgewo+ICAgCQkJY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsKPiAtCQkJcmVnID0gPDB4 MTAwIDB4MWE0PjsKPiArCQkJcmVnID0gPDB4MTAwIDB4MjQ4PjsKPiAgIAkJCXJhbmdlczsKPiAg IAkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICAgCQkJI3NpemUtY2VsbHMgPSA8MT47Cj4gICAK PiAtCQkJcGluLWNvbnRyb2xsZXJAMWMwIHsKPiAtCQkJCWNvbXBhdGlibGUgPSAiYnJjbSxiY200 NzA4LXBpbm11eCI7Cj4gLQkJCQlyZWcgPSA8MHgxYzAgMHgyND47Cj4gKwkJCXBpbmN0cmw6IHBp bi1jb250cm9sbGVyQGMwIHsKPiArCQkJCWNvbXBhdGlibGUgPSAiYnJjbSxiY201MzAxMi1waW5t dXgiOwo+ICsJCQkJcmVnID0gPDB4YzAgMHgyND47Cj4gICAJCQkJcmVnLW5hbWVzID0gImNydV9n cGlvX2NvbnRyb2wiOwo+ICAgCj4gICAJCQkJc3BpLXBpbnMgewo+IAoKWzBdIAo8aHR0cHM6Ly9l bGl4aXIuYm9vdGxpbi5jb20vbGludXgvdjUuOS1yYzEvc291cmNlL2RyaXZlcnMvcGluY3RybC9i Y20vcGluY3RybC1ucy5jI0wzMDI+CgpbMV0gCjxodHRwczovL2VsaXhpci5ib290bGluLmNvbS9s aW51eC92NS45LXJjMS9zb3VyY2UvYXJjaC9hcm0vYm9vdC9kdHMvYmNtNTMwMXguZHRzaSNMNDEw PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83075C433E1 for ; Wed, 19 Aug 2020 20:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E3921744 for ; Wed, 19 Aug 2020 20:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PX5Mjhu0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgHSUsm (ORCPT ); Wed, 19 Aug 2020 16:48:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgHSUsl (ORCPT ); Wed, 19 Aug 2020 16:48:41 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93597C061757; Wed, 19 Aug 2020 13:48:41 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id df16so19241048edb.9; Wed, 19 Aug 2020 13:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mdnZglwI4EjvNb/esSyk9gVq6ig88nPzaI7IUsXkz/Y=; b=PX5Mjhu03HyeYYhfatP1x50gNnSApx04aOGnQcg36XJxZhpwXgNNt5k2SqYRFRdfLZ tbTrp0sqEw9dPDVMhD/kRlsu3n9pF73WzpwobOfh926j7oQWkwst7L2+Yq2mTwGmTQYq +D5yZTEVp3FWmB9Zxc1+CvUNaXx2SMVGCHburPSYGEbzAf0QLfqWVugoQEQZqnFZ4XC+ slcXjXXeSkwIb4agMPWRJDAo4e4MaOf2bdheY9PgJ295nhMn2P6+Ef4dsVCM8lp/dlle JinNx31bdaahLStC8hx+TMzHUO7Zqptp1yD0kjToMxWXsP2YOWlWFzZpMjFGQQHcx9Mc 6SGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mdnZglwI4EjvNb/esSyk9gVq6ig88nPzaI7IUsXkz/Y=; b=TIyflaoltsUgRH1+0jngWFxtzA5a5rBbMFz77FftIsfF5/y+GI72uJnxfRUWbnxz0A 7cN2o4goINpRHyn39nl+kmKbvGLowjrNfuVRGl7GgUNKkbTYtIw4QdCKq/bwK0yRH0+7 dPhgzI/4iXybrrfuYUNahagicJtpqJGr6GVYmv7LkLIH2MpQJ2eT1fEbyVC1aav1fzyg jyjYVckss64HXPM7g7WAPI1O6SyMFCgPyKsnbQqXYHha4zdxcqr4Byso0Z3alW4SW6c6 cD+tLkeTFc8hw+tco4XRzwslQg8W7KUGVnJ01qzYpv1jdzr190Bd2jz8tMLNgzFpbYFO imJQ== X-Gm-Message-State: AOAM531XdgzwkYIpiYrTiIvdGZxO5aoFBlPH/PmkskpTIoHKa7cMhvRm aO0jdt1ZeVpOKK38O+YspIkQc8BmeoE= X-Google-Smtp-Source: ABdhPJx1mnImvIxu6eqtbKhO+TId8N68r59WzshKC5S78XgfC+g8tY+6DqAe34oWDS6x54ifvveFkA== X-Received: by 2002:a05:6402:1430:: with SMTP id c16mr25995987edx.144.1597870119863; Wed, 19 Aug 2020 13:48:39 -0700 (PDT) Received: from debian64.daheim (pd9e294f0.dip0.t-ipconnect.de. [217.226.148.240]) by smtp.gmail.com with ESMTPSA id b9sm20368932ejz.57.2020.08.19.13.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 13:48:38 -0700 (PDT) Received: from localhost.daheim ([127.0.0.1]) by debian64.daheim with esmtp (Exim 4.94) (envelope-from ) id 1k8V0d-001EXU-R2; Wed, 19 Aug 2020 22:48:35 +0200 Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node To: Florian Fainelli , linux-arm-kernel@lists.infradead.org Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "maintainer:BROADCOM BCM5301X ARM ARCHITECTURE" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20200819042308.19043-1-f.fainelli@gmail.com> From: Christian Lamparter Message-ID: <7501cb2f-ea5a-8339-40a0-6706fea32a06@gmail.com> Date: Wed, 19 Aug 2020 22:48:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200819042308.19043-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-08-19 06:23, Florian Fainelli wrote: > The pin controller resources start at 0xc0 from the CRU base which is at > 0x100 from th DMU base, for a final address of 0x1800_c1c0, whereas we > are currently off by 0x100. The resource size of the CRU is also > incorrect and should end at 0x248 bytes from 0x100 which is the start > address. Finally, the compatibility strings defined for the > pin-controller node should reflect the SoC being used. > > Fixes: 9994241ac97c ("ARM: dts: BCM5301X: Describe Northstar pins mux controller") > Reported-by: Christian Lamparter > Signed-off-by: Florian Fainelli > --- > Christian, can you test this as a preliminary patch for your Cisco > Meraki MR32 series? Thanks! Hm, it looks like this is more complicated than this. We should have looked at pinctrl-ns.c's ns_pinctrl_probe() [0] before calling it. | ns_pinctrl->regmap = syscon_node_to_regmap(of_get_parent(np)); | if (IS_ERR(ns_pinctrl->regmap)) { | int err = PTR_ERR(ns_pinctrl->regmap); | | dev_err(dev, "Failed to map pinctrl regs: %d\n", err); | | return err; | } | | if (of_property_read_u32(np, "offset", &ns_pinctrl->offset)) { | dev_err(dev, "Failed to get register offset\n"); | return -ENOENT; | } So, the ns_pinctrl_probe() takes the address of the parent node (cru) and then looks for a "offset" property to add to this (which is missing in the bcm5301x.dtsi [1]). Thing is, for this to work, the parent-node should be a "simple-mfd" (so a regmap is created for the reg), right? This would also mean that the "reg" property in the pin-controller node is just cosmetic. I guess the reason why this sort-of-works for me is because I'm using this MR32 with OpenWrt (Rafał Miłecki is probably using it too ;) ). (Note: We should not forget to update the binding-documentation as well!) BTW: I'll reply my findings for the i2c issue with the MR32 in the other mail. > > arch/arm/boot/dts/bcm4708.dtsi | 4 ++++ > arch/arm/boot/dts/bcm4709.dtsi | 4 ++++ > arch/arm/boot/dts/bcm5301x.dtsi | 8 ++++---- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm4708.dtsi b/arch/arm/boot/dts/bcm4708.dtsi > index 1a19e97a987d..5064fe51e402 100644 > --- a/arch/arm/boot/dts/bcm4708.dtsi > +++ b/arch/arm/boot/dts/bcm4708.dtsi > @@ -43,6 +43,10 @@ cpu@1 { > > }; > > +&pinctrl { > + compatible = "brcm,bcm4708-pinmux"; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/bcm4709.dtsi b/arch/arm/boot/dts/bcm4709.dtsi > index e1bb8661955f..7417c275ea9d 100644 > --- a/arch/arm/boot/dts/bcm4709.dtsi > +++ b/arch/arm/boot/dts/bcm4709.dtsi > @@ -5,6 +5,10 @@ > > #include "bcm4708.dtsi" > > +&pinctrl { > + compatible = "brcm,bcm4709-pinmux"; > +}; > + > &uart0 { > clock-frequency = <125000000>; > status = "okay"; > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index 2d9b4dd05830..bf49943f504a 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -402,14 +402,14 @@ dmu@1800c000 { > > cru@100 { > compatible = "simple-bus"; > - reg = <0x100 0x1a4>; > + reg = <0x100 0x248>; > ranges; > #address-cells = <1>; > #size-cells = <1>; > > - pin-controller@1c0 { > - compatible = "brcm,bcm4708-pinmux"; > - reg = <0x1c0 0x24>; > + pinctrl: pin-controller@c0 { > + compatible = "brcm,bcm53012-pinmux"; > + reg = <0xc0 0x24>; > reg-names = "cru_gpio_control"; > > spi-pins { > [0] [1]