Re: [PATCH v5 0/8] Introduce initial AMD ASF Controller driver support

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 9/14/2024 00:50, Andy Shevchenko wrote:
> On Fri, Sep 13, 2024 at 05:41:02PM +0530, Shyam Sundar S K wrote:
>> The AMD ASF (Alert Standard Format) function block is essentially an SMBus
>> controller with built-in ASF functionality. It features two pins SCL1 and
>> SDA1 that facilitate communication with other SMBus devices. This dual
>> capability allows the ASF controller to issue generic SMBus packets and
>> communicate with the DASH controller using MCTP over ASF. Additionally,
>> the ASF controller supports remote commands defined by the ASF
>> specification, such as shutdown, reset, power-up, and power-down, without
>> requiring any software interaction.
>>
>> The concept is to enable a remote system to communicate with the target
>> system over the network. The local network controller, such as an Ethernet
>> MAC, receives remote packets and relays the commands to the FCH
>> (Fusion Controller Hub) through the ASF. Examples of these commands
>> include shutdown and reset. Since ASF uses the SMBus protocol, this
>> controller can be configured as a secondary SMBus controller.
>>
>> This series of updates focuses on extending the i2c-piix4 driver to
>> support the ASF driver by exporting several functions from the i2c-piix4
>> driver, allowing the AMD ASF driver to leverage existing functionalities.
>> Additionally, this change incorporates core ASF functionality, including
>> ACPI integration and the implementation of i2c_algorithm callbacks for ASF
>> operations.
> 
> ACPI code is much better now, but can be even better.
> See my individual comments.
> 

Thank you for the feedback and apologies for the delay. I have few
questions that needs a bit of clarity. Please see the individual patches.

Thanks,
Shyam