Hi Michael,

On 5/13/22 08:53, Michael Johnson wrote:
> Hi Denis,
> 
> I've been running this patch for the day and I don't think it's
> actually fixed the retry. I have set a low lease time and then block
> the DHCP server for the ACK and I can see that the retry still doesn't
> happen.

I suspect it does fix one bug, but not another...  I'm not near my test box 
right now, so debugging this is a bit painful.

Could you debug-print the 'next_timeout' we calculate in 
dhcp_client_t1_expired() here:

         next_timeout = dhcp_rebind_renew_retry_time(client->start_t,
                                                         client->lease->t2);

And also put in
         L_WARN_ON(!client->timeout_resend);

after the timeout_resend timer is created?

 From your 'other' bug report yesterday, we calculate the t1 timer correctly, 
but the timer still doesn't fire.
It almost feels like the timers are just not being created.  Is there anything 
suspicious in the kernel logs?

Regards,
-Denis