Re: [PATCH] drm/amdgpu: Always align dumb buffer at PAGE_SIZE

["Christian König" <christian.koenig@amd.com>]

Am 23.09.22 um 01:04 schrieb Lepton Wu:
> Since size has been aligned to PAGE_SIZE already, just align it
> to PAGE_SIZE so later the buffer can be used as a texture in mesa
> after https://cgit.freedesktop.org/mesa/mesa/commit/?id=f7a4051b8
> Otherwise, si_texture_create_object will fail at line
> "buf->alignment < tex->surface.alignment"

I don't think that those Mesa checks are a good idea in the first place.

The alignment value is often specified as zero when it doesn't matter 
because the minimum alignment can never be less than the page size.

Christian.

>
> Signed-off-by: Lepton Wu <ytht.net@gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index 8ef31d687ef3b..8dca0c920d3ce 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -928,7 +928,7 @@ int amdgpu_mode_dumb_create(struct drm_file *file_priv,
>   	args->size = ALIGN(args->size, PAGE_SIZE);
>   	domain = amdgpu_bo_get_preferred_domain(adev,
>   				amdgpu_display_supported_domains(adev, flags));
> -	r = amdgpu_gem_object_create(adev, args->size, 0, domain, flags,
> +	r = amdgpu_gem_object_create(adev, args->size, PAGE_SIZE, domain, flags,
>   				     ttm_bo_type_device, NULL, &gobj);
>   	if (r)
>   		return -ENOMEM;