All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wachowski, Karol" <karol.wachowski@linux.intel.com>
To: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
	lizhi.hou@amd.com, dawid.osuchowski@linux.intel.com
Subject: Re: [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling
Date: Thu, 8 Oct 2026 12:31:33 +0200	[thread overview]
Message-ID: <7531e594-41dd-419e-b78a-8600162b6d24@linux.intel.com> (raw)
In-Reply-To: <20261008100013.3006983-1-andrzej.kacprowski@linux.intel.com>

On 08-Oct-26 12:00, Andrzej Kacprowski wrote:
> In FW_TEST mode, boot the firmware but skip the ready wait and all
> subsequent firmware communication. The firmware test reports its
> results through the firmware log.
> 
> Disable driver timeouts in this mode so timeout handling does not
> interrupt the firmware test.
> 
> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_drv.c | 3 +++
>   drivers/accel/ivpu/ivpu_hw.c  | 2 +-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index 6b71edf566e7..8c3fb0f01a31 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -539,6 +539,9 @@ int ivpu_boot(struct ivpu_device *vdev)
>   	ivpu_hw_irq_enable(vdev);
>   	ivpu_ipc_enable(vdev);
>   
> +	if (ivpu_test_mode & IVPU_TEST_MODE_FW_TEST)
> +		return 0;
> +
>   	if (!ivpu_fw_is_warm_boot(vdev)) {
>   		ret = ivpu_pm_dct_init(vdev);
>   		if (ret)
> diff --git a/drivers/accel/ivpu/ivpu_hw.c b/drivers/accel/ivpu/ivpu_hw.c
> index 59a5de8d9270..8b63140e3160 100644
> --- a/drivers/accel/ivpu/ivpu_hw.c
> +++ b/drivers/accel/ivpu/ivpu_hw.c
> @@ -94,7 +94,7 @@ static void wa_init(struct ivpu_device *vdev)
>   
>   static void timeouts_init(struct ivpu_device *vdev)
>   {
> -	if (ivpu_test_mode & IVPU_TEST_MODE_DISABLE_TIMEOUTS) {
> +	if (ivpu_test_mode & (IVPU_TEST_MODE_DISABLE_TIMEOUTS | IVPU_TEST_MODE_FW_TEST)) {
>   		/* in milliseconds, negative value disables the timeout */
>   		vdev->timeout.boot = -1;
>   		vdev->timeout.jsm = -1;

Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>

  reply	other threads:[~2026-10-08 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 10:00 [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling Andrzej Kacprowski
2026-10-08 10:31 ` Wachowski, Karol [this message]
2026-10-08 15:46 ` Jeff Hugo
2026-10-09  6:20   ` Wachowski, Karol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7531e594-41dd-419e-b78a-8600162b6d24@linux.intel.com \
    --to=karol.wachowski@linux.intel.com \
    --cc=andrzej.kacprowski@linux.intel.com \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=lizhi.hou@amd.com \
    --cc=oded.gabbay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.