From: Jens Axboe <axboe@kernel.dk>
To: Christian Brauner <brauner@kernel.org>, Stefan Roesch <shr@fb.com>
Cc: linux-fsdevel@vger.kernel.org, kernel-team@fb.com, jack@suse.cz,
hch@lst.de, djwong@kernel.org
Subject: Re: [PATCH v1] fs: __file_remove_privs(): restore call to inode_has_no_xattr()
Date: Tue, 16 Aug 2022 11:07:05 -0600 [thread overview]
Message-ID: <753d37cd-6b63-4fb5-eeb9-dd9f620ad8ad@kernel.dk> (raw)
In-Reply-To: <20220816170128.inzqyuj4snywiwqx@wittgenstein>
On 8/16/22 11:01 AM, Christian Brauner wrote:
> On Tue, Aug 16, 2022 at 08:31:58AM -0700, Stefan Roesch wrote:
>> This restores the call to inode_has_no_xattr() in the function
>> __file_remove_privs(). In case the dentry_meeds_remove_privs() returned
>> 0, the function inode_has_no_xattr() was not called.
>>
>> Signed-off-by: Stefan Roesch <shr@fb.com>
>> ---
>
> Looks good to me. As Jens said, this should get a fixes tag and should
> probably also have a link to the perf regression I debugged this on so
> that we can see whether this was actually the cause,
> Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Yes good point, this is a case where the Link actually makes a lot of
sense.
--
Jens Axboe
prev parent reply other threads:[~2022-08-16 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 15:31 [PATCH v1] fs: __file_remove_privs(): restore call to inode_has_no_xattr() Stefan Roesch
2022-08-16 15:36 ` Jens Axboe
2022-08-16 17:01 ` Christian Brauner
2022-08-16 17:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=753d37cd-6b63-4fb5-eeb9-dd9f620ad8ad@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shr@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.