All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Gregory Price (Meta)" <gourry@gourry.net>
Cc: Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>, Andy Whitcroft <apw@canonical.com>,
	Miaohe Lin <linmiaohe@huawei.com>, Michal Hocko <mhocko@suse.com>,
	Rik van Riel <riel@surriel.com>, Hugh Dickins <hughd@google.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Vivek Kasireddy <vivek.kasireddy@intel.com>,
	Dave Airlie <airlied@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Peter Xu <peterx@redhat.com>, Breno Leitao <leitao@debian.org>,
	Will Deacon <will@kernel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	Nick Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	linux-doc@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-s390@vger.kernel.org, Chris Mason <mason@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 13/15] mm/hugetlb: fix reservation leak on min_size= mounts
Date: Mon, 16 Nov 2026 17:10:28 +0100	[thread overview]
Message-ID: <7544e13b-e926-4350-a48a-cd76df456bd2@kernel.org> (raw)
In-Reply-To: <179467919954.482102.5381456550239958011.b4-reply@b4>

On 11/14/26 18:59, Gregory Price (Meta) wrote:
> On 2026-10-28 21:13 +0100, David Hildenbrand (Arm) wrote:
>> From: Chris Mason <mason@kernel.org>
>>
>> Failed allocations for CoW mappings can leak reservations on hugetlbfs
>> mounts with min_size= and no size=. The leaked reservations survive
>> unmount.
>>
>> HPG_restore_reserve makes free_huge_folio() restore the global
>> reservation without returning it to the subpool. This assumes the
>> reserve map holds the reservation. However, a CoW mapping may have no
>> reserve map, or the map may already account for another folio at the
>> same index.
>>
>> Commit 58db7c5fbe7d ("mm/hugetlb: fix avoid_reserve to allow taking
>> folio from subpool") allowed owner CoW allocations to consume subpool
>> reservations. Commit 51e1de00acdb ("mm/hugetlb: simplify
>> vma_has_reserves()") later extended this to CoW mappings without a
>> reserve map.
>>
>> For example, with a subpool minimum of one page and a
>> MAP_PRIVATE|MAP_NORESERVE mapping:
>>
>>                                       subpool       global
>>                                       rsv_hpages    resv_huge_pages
>>   1. Mount                             1             1
>>   2. Allocate using subpool reserve    0             0
>>   3. Free on error with flag set       0             1
>>   4. Allocate without a reservation    0             1
>>   5. Free and return to subpool        1             2
>>
>> Call folio_clear_hugetlb_restore_reserve() for CoW mappings when
>> map_chg != MAP_CHG_REUSE, meaning no reserve-map reservation was consumed.
>> This lets free_huge_folio() return subpool reservations to the subpool
>> on error.
>>
>> Do not set the flag again if region-cache allocation fails during
>> rollback: that would undo the flag clearing and skip returning the
>> reservation to the subpool. This also fixes the older case where setting
>> the flag invents a reservation for an unreserved allocation for a CoW
>> mapping.
>>
>> The doc still mentions PagePrivate at various places: future work should
>> clean that up.
>>
>> Fix generated by an LLM and sent by Chris Mason in private.
>>
>> Fixes: 846be08578ed ("mm/hugetlb: expand restore_reserve_on_error functionality")
>> Fixes: 58db7c5fbe7d ("mm/hugetlb: fix avoid_reserve to allow taking folio from subpool")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Chris Mason <mason@kernel.org>
>> [ david: simplify comments and improve description; updated Fixes ]
>> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> 
> Commit message is still hard to read :| (or maybe HugeTLB is just awful
> and no amount of massaging the message will ever help this).

It's just absolutely horrible stuff.

> 
> Maybe note - this is an accounting error only, the pages do not leak.

Ack, I will add this.

> 
> Was able to reproduce the issue with a UFFDIO_COPY the provides an invalid
> invalid source address (src=0).
> 
> 1. Create the pool and mapping (hugetlbfs w/ pagesize=2M,min_size=2M)
> 2. invalid UFFDIO_COPY  (kernel allocates, fails the, rolls back)
> 3. Close uffd, cause a normal fault
> 4. Unmap and truncate the file
> 5. Remove the file and unmount
> 
>                   Base                    Patch
> step 2:  total=2 free=2 rsvd=1     total=2 free=2 rsvd=1
> step 3:	 total=2 free=2 rsvd=2     total=2 free=2 rsvd=1*
> step 5:  total=2 free=2 rsvd=1     total=2 free=2 rsvd=0*
> 
> Result looks correct to me.
> The code hurts my brain but looks reasonable.
> 
> Tested-by: Gregory Price (Meta) <gourry@gourry.net>
> Reviewed-by: Gregory Price (Meta) <gourry@gourry.net>

Thanks!

-- 
Cheers,

David

  reply	other threads:[~2026-11-16 16:10 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 20:13 [PATCH 00/15] mm/hugetlb: various fixes David Hildenbrand (Arm)
2026-10-28 20:13 ` [PATCH 01/15] hugetlbfs: fix integer overflow in fallocate() David Hildenbrand (Arm)
2026-10-29  3:37   ` Muchun Song
2026-10-29  9:05   ` Oscar Salvador (SUSE)
2026-10-29 20:16   ` sashiko-bot
2026-10-29 20:53   ` Ackerley Tng
2026-11-13 21:42   ` Gregory Price (Meta)
2026-10-28 20:13 ` [PATCH 02/15] mm/hugetlb: compare against persistent count when freeing lowmem folios David Hildenbrand (Arm)
2026-10-29  3:39   ` Muchun Song
2026-11-02 12:54     ` David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-28 20:13 ` [PATCH 03/15] mm/hugetlb: preserve reservations when shrinking on HIGHMEM David Hildenbrand (Arm)
2026-10-29  3:41   ` Muchun Song
2026-10-29 20:16   ` sashiko-bot
2026-10-28 20:13 ` [PATCH 04/15] mm/hugetlb: account temporary folios separately David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-30  9:07   ` Muchun Song
2026-11-02 12:56   ` David Hildenbrand (Arm)
2026-10-28 20:13 ` [PATCH 05/15] mm/hugetlb: keep surplus folios when the pool shrinks David Hildenbrand (Arm)
2026-10-29  3:51   ` Muchun Song
2026-10-29 20:16   ` sashiko-bot
2026-11-13 21:47   ` Gregory Price (Meta)
2026-10-28 20:13 ` [PATCH 06/15] mm/hugetlb: fix mremap() racing with page migration David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-30  9:20   ` Muchun Song
2026-10-28 20:13 ` [PATCH 07/15] hugetlbfs: fix unmapping folios from private VMAs David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-30  9:39   ` Muchun Song
2026-10-28 20:13 ` [PATCH 08/15] mm/hugetlb: serialize page-cache allocations with truncation David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-28 20:13 ` [PATCH 09/15] mm/memfd: recheck the page cache before allocating a hugetlb folio David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-04  9:24   ` Muchun Song
2026-10-28 20:13 ` [PATCH 10/15] mm/hugetlb: count again if the reserve map shrank David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-10-28 20:13 ` [PATCH 11/15] hugetlbfs: do not grow a sealed file in mmap() David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-04  9:55   ` Muchun Song
2026-11-13 21:49   ` Gregory Price (Meta)
2026-10-28 20:13 ` [PATCH 12/15] mm/hugetlb: keep surplus folios that are reserved David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-02  8:08   ` Muchun Song
2026-11-14 17:45   ` Gregory Price (Meta)
2026-10-28 20:13 ` [PATCH 13/15] mm/hugetlb: fix reservation leak on min_size= mounts David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-14 17:59   ` Gregory Price (Meta)
2026-11-16 16:10     ` David Hildenbrand (Arm) [this message]
2026-10-28 20:13 ` [PATCH 14/15] RFC: mm/hugetlb: account restored reservations before freeing folios David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-02 13:42     ` David Hildenbrand (Arm)
2026-11-05 10:09   ` David Hildenbrand (Arm)
2026-10-28 20:13 ` [PATCH 15/15] RFC: mm/hugetlb: delay anon folio rmap removal until after the TLB flush David Hildenbrand (Arm)
2026-10-29 20:16   ` sashiko-bot
2026-11-13 20:22 ` [PATCH 00/15] mm/hugetlb: various fixes David Hildenbrand (Arm)
2026-11-14  0:43   ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7544e13b-e926-4350-a48a-cd76df456bd2@kernel.org \
    --to=david@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=airlied@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=corbet@lwn.net \
    --cc=gor@linux.ibm.com \
    --cc=gourry@gourry.net \
    --cc=hca@linux.ibm.com \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kraxel@redhat.com \
    --cc=leitao@debian.org \
    --cc=liam@infradead.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=mason@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nao.horiguchi@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=osalvador@suse.de \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=riel@surriel.com \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    --cc=vivek.kasireddy@intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.