From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [IPv6:2001:44b8:8060:ff02:300:1:6:4]) by ozlabs.org (Postfix) with ESMTP id 301412C00BA for ; Mon, 24 Feb 2014 13:09:22 +1100 (EST) From: Alistair Popple To: Mark Rutland Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Date: Mon, 24 Feb 2014 13:09:19 +1100 Message-ID: <7545458.ltLKFumBkZ@mexican> In-Reply-To: <20140221111823.GA8783@e106331-lin.cambridge.arm.com> References: <1392964293-13687-1-git-send-email-alistair@popple.id.au> <1392964293-13687-3-git-send-email-alistair@popple.id.au> <20140221111823.GA8783@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "netdev@vger.kernel.org" , "David S. Miller" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote: > On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote: [...] > > > + /* Check for RGMII flags */ > > + if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL)) > > + dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO; > > You can use of_property_read_bool here. Thanks. I will update it. Regards, Alistair > > Cheers, > Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alistair Popple Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Date: Mon, 24 Feb 2014 13:09:19 +1100 Message-ID: <7545458.ltLKFumBkZ@mexican> References: <1392964293-13687-1-git-send-email-alistair@popple.id.au> <1392964293-13687-3-git-send-email-alistair@popple.id.au> <20140221111823.GA8783@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20140221111823.GA8783-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "David S. Miller" List-Id: devicetree@vger.kernel.org On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote: > On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote: [...] > > > + /* Check for RGMII flags */ > > + if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL)) > > + dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO; > > You can use of_property_read_bool here. Thanks. I will update it. Regards, Alistair > > Cheers, > Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbaBXCJ0 (ORCPT ); Sun, 23 Feb 2014 21:09:26 -0500 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:58607 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbaBXCJY (ORCPT ); Sun, 23 Feb 2014 21:09:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApcDAP6oClOl5H4JgWdsb2JhbABZwXSDB4EkDgEBFiYogiUBAQQBJxM/EAsYCRUQDwFHBogQCMZOF45kB4Q4BKxKgVIo From: Alistair Popple To: Mark Rutland Cc: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Date: Mon, 24 Feb 2014 13:09:19 +1100 Message-ID: <7545458.ltLKFumBkZ@mexican> User-Agent: KMail/4.9.5 (Linux/3.5.0-45-generic; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20140221111823.GA8783@e106331-lin.cambridge.arm.com> References: <1392964293-13687-1-git-send-email-alistair@popple.id.au> <1392964293-13687-3-git-send-email-alistair@popple.id.au> <20140221111823.GA8783@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote: > On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote: [...] > > > + /* Check for RGMII flags */ > > + if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL)) > > + dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO; > > You can use of_property_read_bool here. Thanks. I will update it. Regards, Alistair > > Cheers, > Mark.