From: Julien Olivain <juju@cotds.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/freescale-imx/firmware-imx: install mx8qm-ahab-container.img
Date: Thu, 20 Feb 2020 21:28:49 +0100 [thread overview]
Message-ID: <7545eeef70f4b10fee1944b35832e152@cotds.org> (raw)
In-Reply-To: <20200220021858.700249-2-thomas.petazzoni@bootlin.com>
Hi Thomas,
Patch looks good. Thanks.
On 2020-02-20 03:18, Thomas Petazzoni wrote:
> This commit ensures the mx8qm-ahab-container.img file gets installed
> for the i.MX8 platform (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8). This
> is needed for board/freescale/common/imx/imx8-bootloader-prepare.sh to
> find this file when creating the bootloader image.
>
> Note that it means that the default FIRMWARE_IMX_INSTALL_TARGET_CMDS
> that applies to all platforms except i.MX8M, i.MX8MM and i.MX8X also
> no longer applies to i.MX8. But this is anyway probably relevant, as
> most likely i.MX8 also needs a special variant of
> FIRMWARE_IMX_INSTALL_TARGET_CMDS.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> NOTE: some review on this patch from i.MX people would be greatly
> appreciated. Thanks!
> ---
> package/freescale-imx/firmware-imx/firmware-imx.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk
> b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index b251fcda2a..b79973a104 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -59,6 +59,14 @@ define FIRMWARE_IMX_INSTALL_TARGET_CMDS
> $(INSTALL) -D -m 0644 $(@D)/firmware/vpu/vpu_fw_imx8_enc.bin \
> $(TARGET_DIR)/lib/firmware/vpu/vpu_fw_imx8_enc.bin
> endef
> +else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
> +FIRMWARE_IMX_INSTALL_IMAGES = YES
> +define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
> + # SECO firmware is needed when generating imx8-boot-sd.bin which
> + # is done in post-image script.
> + cp $(@D)/firmware/seco/mx8qm-ahab-container.img \
> + $(BINARIES_DIR)/ahab-container.img
> +endef
> else
> define FIRMWARE_IMX_INSTALL_TARGET_CMDS
> mkdir -p $(TARGET_DIR)/lib/firmware/imx
Reviewed-by: Julien Olivain <juju@cotds.org>
Tested-by: Julien Olivain <juju@cotds.org>
next prev parent reply other threads:[~2020-02-20 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 2:18 [Buildroot] [PATCH 1/2] board/freescale: use correct ahab-container.img file name Thomas Petazzoni
2020-02-20 2:18 ` [Buildroot] [PATCH 2/2] package/freescale-imx/firmware-imx: install mx8qm-ahab-container.img Thomas Petazzoni
2020-02-20 7:02 ` Refik Tuzakli
2020-02-20 20:28 ` Julien Olivain [this message]
2020-07-27 13:25 ` Thomas Petazzoni
2020-02-20 20:27 ` [Buildroot] [PATCH 1/2] board/freescale: use correct ahab-container.img file name Julien Olivain
2020-02-20 20:33 ` Fabio Estevam
2020-02-26 21:28 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7545eeef70f4b10fee1944b35832e152@cotds.org \
--to=juju@cotds.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.