All of lore.kernel.org
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] monitor: Fix use of uninitialized variable
Date: Tue, 24 Nov 2015 20:57:49 +0100	[thread overview]
Message-ID: <7546151.u5ofOufstg@ix> (raw)
In-Reply-To: <1448136544-18660-1-git-send-email-szymon.janc@codecoup.pl>

On Saturday 21 November 2015 21:09:03 Szymon Janc wrote:
> subevent code was never set in vendor_evt() resulting in printing
> random stack data as subevent opcode in print_subevent().
> ---
>  monitor/packet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 4c18cb2..70bd153 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -8471,6 +8471,7 @@ static void vendor_evt(const void *data, uint8_t size)
> vendor_data.str = vendor_str;
>  		} else
>  			vendor_data.str = vnd->str;
> +		vendor_data.subevent = subevent;
>  		vendor_data.func = vnd->evt_func;
>  		vendor_data.size = vnd->evt_size;
>  		vendor_data.fixed = vnd->evt_fixed;

Applied.

-- 
pozdrawiam
Szymon Janc

      parent reply	other threads:[~2015-11-24 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 20:09 [PATCH 1/2] monitor: Fix use of uninitialized variable Szymon Janc
2015-11-21 20:09 ` [PATCH 2/2] monitor: Fix possible crash on unknown LE Meta Event Szymon Janc
2015-11-24 19:57 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7546151.u5ofOufstg@ix \
    --to=szymon.janc@codecoup.pl \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.