Re: [dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, October 30, 2020 6:52 PM
> To: Guo, Jia <jia.guo@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>
> Subject: Re: [PATCH v12] net/iavf: support flex desc metadata extraction
> 
> On 10/30/2020 8:40 AM, Jeff Guo wrote:
> > Enable metadata extraction for flexible descriptors in AVF, that would
> > allow network function directly get metadata without additional
> > parsing which would reduce the CPU cost for VFs. The enabling metadata
> > extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS
> > flexible descriptors, and the VF could negotiate the capability of the
> > flexible descriptor with PF and correspondingly configure the specific
> > offload at receiving queues.
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > v12:
> > refine doc to be briefly
> >
> > v11:
> > update doc in .map and .rst
> >
> > v10:
> > delete the makefile configure and rename the dynamic mbuf name
> >
> > v9:
> > change the undef config
> >
> > v8:
> > rebase patch for apply issue
> >
> > v7:
> > clean some useless and add doc
> >
> > v6:
> > rebase patch
> >
> > v5:
> > remove ovs configure since ovs is not protocol extraction
> >
> > v4:
> > add flex desc type in rx queue for handling vector path handle ovs
> > flex type
> >
> > v3:
> > export these global symbols into .map
> >
> > v2:
> > remove makefile change and modify the rxdid handling
> > ---
> >   doc/guides/nics/intel_vf.rst            |   4 +
> >   doc/guides/rel_notes/release_20_11.rst  |   6 +
> >   drivers/net/iavf/iavf.h                 |  24 +-
> >   drivers/net/iavf/iavf_ethdev.c          | 394
> ++++++++++++++++++++++++
> >   drivers/net/iavf/iavf_rxtx.c            | 252 +++++++++++++--
> >   drivers/net/iavf/iavf_rxtx.h            | 169 +++++-----
> >   drivers/net/iavf/iavf_rxtx_vec_common.h |   3 +
> >   drivers/net/iavf/iavf_vchnl.c           |  22 +-
> >   drivers/net/iavf/meson.build            |   2 +
> >   drivers/net/iavf/rte_pmd_iavf.h         | 250 +++++++++++++++
> 
> We should add this public header to the API documentation, if that is the only
> change I can do while merging. Something like:

Yes, it think this is the only change, thanks.

>   diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
>   index a9c12d1a2f..36f8ed7ba8 100644
>   --- a/doc/api/doxy-api-index.md
>   +++ b/doc/api/doxy-api-index.md
>   @@ -41,6 +41,7 @@ The public API headers are grouped by topics:
>      [vhost]              (@ref rte_vhost.h),
>      [vdpa]               (@ref rte_vdpa.h),
>      [KNI]                (@ref rte_kni.h),
>   +  [iavf]               (@ref rte_pmd_iavf.h),
>      [ixgbe]              (@ref rte_pmd_ixgbe.h),
>      [i40e]               (@ref rte_pmd_i40e.h),
>      [ice]                (@ref rte_pmd_ice.h),