From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH v6 3/6] livepatch: NOP if func->new_addr is
	zero.
Date: Wed, 21 Sep 2016 14:21:47 +0100
Message-ID: <754be4a1-e87b-946b-8bb7-bdb651da2dfb@citrix.com>
References: <1474039754-25816-1-git-send-email-konrad.wilk@oracle.com>
 <1474039754-25816-4-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=0657416a3=ross.lagerwall@citrix.com>)
 id 1bmhTJ-0006Xl-2R
 for xen-devel@lists.xenproject.org; Wed, 21 Sep 2016 13:21:57 +0000
In-Reply-To: <1474039754-25816-4-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

T24gMDkvMTYvMjAxNiAwNDoyOSBQTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IFRo
ZSBOT1AgZnVuY3Rpb25hbGl0eSB3aWxsIE5PUCBhbnkgb2YgdGhlIGNvZGUgYXQKPiB0aGUgJ29s
ZF9hZGRyJyBvciBhdCAnbmFtZScgaWYgdGhlICduZXdfYWRkcicgaXMgemVyby4KPiBUaGUgcHVy
cG9zZSBvZiB0aGlzIGlzIHRvIE5PUCBvdXQgY2FsbHMsIHN1Y2ggYXM6Cj4KPiAgZTggPDQtYnl0
ZXMtb2Zmc2V0Pgo+Cj4gKDUgYnl0ZSBpbnNuKSwgb3Igb24gQVJNIGEgNCBieXRlIGluc24gZm9y
IGJyYW5jaGluZy4KPgo+IFdlIG5lZWQgdGhlIEVJUCBvZiB3aGVyZSB3ZSBuZWVkIHRvIHRoZSBO
T1AsIGFuZCB0aGF0IGNhbgo+IGJlIHByb3ZpZGVkIHZpYSB0aGUgYG9sZF9hZGRyYCBvciBgbmFt
ZWAuCj4KPiBJZiB0aGUgYG9sZF9hZGRyYCBpcyBwcm92aWRlZCB3ZSB3aWxsIE5PUCAnbmV3X3Np
emUnCj4gYW1vdW50IG9mIGJ5dGVzIGF0IHRoYXQgbG9jYXRpb24uCj4KPiBUaGUgYW1vdW50IGlz
IHVwIHRvIDMxIGluc3RydWN0aW9ucyBpZiBkZXNpcmVkICh3aGljaCBpcwo+IHRoZSBzaXplIG9m
IHRoZSBvcGFxdWUgbWVtYmVyKS4gSWYgdGhlcmUgaXMgYSBuZWVkIHRvIE5PUAo+IG1vcmUgdGhl
bjogYSkgbW9yZSAnc3RydWN0IGxpdmVwYXRjaF9mdW5jJyBzdHJ1Y3R1cmVzIG5lZWQKPiB0byBi
ZSBwcmVzZW50LCBiKSB3ZSBoYXZlIHRvIGltcGxlbWVudCBhIHZhcmlhYmxlIHNpemUKPiBidWZm
ZXIgKGluIHRoZSBmdXR1cmUpLCBvciBjKSBmaXJzdCBieXRlIGFuIHVuY29uZGl0aW9uYWwKPiBi
cmFuY2ggc2tpcHBpbmcgdGhlIHRvIGJlIGRpc2FibGVkIGNvZGUgKG9mIGNvdXJzZSBwcm92aWRl
ZAo+IHRoZXJlIGFyZSBubyBicmFuY2ggdGFyZ2V0cyBpbiB0aGUgbWlkZGxlKS4KPgo+IFdoaWxl
IGF0IGl0LCBhbHNvIHVuaWZ5IHRoZSBjb2RlIG9uIHg4NiBwYXRjaGluZyBzbwo+IGl0IGlzIGEg
Yml0IHNpbXBsZXIgKGluc3RlYWQgb2YgdHdvIHNlcGVyYXRlIHdyaXRlcwo+IGp1c3QgbWFrZSBp
dCBvbmUgbWVtY3B5KS4KPgo+IEFuZCBpbnRyb2R1Y2UgYSBnZW5lcmFsIGxpdmVwYXRjaF9pbnNu
X2xlbiBpbmxpbmUgZnVuY3Rpb24KPiB0aGF0IHdvdWxkIGRlcGVuZCBvbiBwbGF0Zm9ybSBzcGVj
aWZpYyBpbnN0cnVjdGlvbiBzaXplCj4gKGZvciBhIHVuY29uZGl0aW9uYWwgYnJhbmNoKS4gQXMg
c3VjaCB3ZSBhbHNvIHJlbmFtZSB0aGUKPiBQQVRDSF9JTlNOX1NJWkUgdG8gQVJDSF9QQVRDSF9J
TlNOX1NJWkUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBLb25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJh
ZC53aWxrQG9yYWNsZS5jb20+Cj4Kc25pcAo+IGRpZmYgLS1naXQgYS9kb2NzL21pc2MvbGl2ZXBh
dGNoLm1hcmtkb3duIGIvZG9jcy9taXNjL2xpdmVwYXRjaC5tYXJrZG93bgo+IGluZGV4IDgxZjRm
YzkuLmE4ZTcwYTggMTAwNjQ0Cj4gLS0tIGEvZG9jcy9taXNjL2xpdmVwYXRjaC5tYXJrZG93bgo+
ICsrKyBiL2RvY3MvbWlzYy9saXZlcGF0Y2gubWFya2Rvd24KPiBAQCAtMzIwLDEwICszMjAsMTMg
QEAgVGhlIHNpemUgb2YgdGhlIHN0cnVjdHVyZSBpcyA2NCBieXRlcyBvbiA2NC1iaXQgaHlwZXJ2
aXNvcnMuIEl0IHdpbGwgYmUKPgo+ICAqIGBuZXdfYWRkcmAgaXMgdGhlIGFkZHJlc3Mgb2YgdGhl
IGZ1bmN0aW9uIHRoYXQgaXMgcmVwbGFjaW5nIHRoZSBvbGQKPiAgICBmdW5jdGlvbi4gVGhlIGFk
ZHJlc3MgaXMgZmlsbGVkIGluIGR1cmluZyByZWxvY2F0aW9uLiBUaGUgdmFsdWUgKipNVVNUKiog
YmUKPiAtICB0aGUgYWRkcmVzcyBvZiB0aGUgbmV3IGZ1bmN0aW9uIGluIHRoZSBmaWxlLgo+ICsg
IGVpdGhlciB0aGUgYWRkcmVzcyBvZiB0aGUgbmV3IGZ1bmN0aW9uIGluIHRoZSBmaWxlLCBvciB6
ZXJvIGlmIHdlIGFyZSBOT1Bpbmcgb3V0Cj4gKyAgYXQgYG9sZF9hZGRyYCAoYW5kIGBuZXdfc2l6
ZWAgKipNVVNUKiogbm90IGJlIHplcm8pLgoKVGhlIHByZWNlZGluZyB1bnRvdWNoZWQgbGluZXMg
Ii4uLmlzIHRoZSBhZGRyZXNzIG9mIHRoZSBmdW5jdGlvbiB0aGF0IGlzIApyZXBsYWNpbmcgdGhl
IG9sZCBmdW5jdGlvbi4gVGhlIGFkZHJlc3MgaXMgZmlsbGVkIGluIGR1cmluZyAKcmVsb2NhdGlv
bi4uLiIgYXJlIGEgYml0IHN0YWxlIG5vdy4gUGVyaGFwcyB0aGUgd2hvbGUgcGFyYWdyYXBoIG5l
ZWRzIHRvIApiZSByZXBsYWNlZD8KCj4KPiAgKiBgb2xkX3NpemVgIGFuZCBgbmV3X3NpemVgIGNv
bnRhaW4gdGhlIHNpemVzIG9mIHRoZSByZXNwZWN0aXZlIGZ1bmN0aW9ucyBpbiBieXRlcy4KPiAt
ICAgVGhlIHZhbHVlIG9mIGBvbGRfc2l6ZWAgKipNVVNUKiogbm90IGJlIHplcm8uCj4gKyAgIFRo
ZSB2YWx1ZSBvZiBgb2xkX3NpemVgICoqTVVTVCoqIG5vdCBiZSB6ZXJvLiBJZiB0aGUgdmFsdWUg
b2YgYG5ld19hZGRyYCBpcwo+ICsgICB6ZXJvIHRoZW4gYG5ld19zaXplYCBkZXRlcm1pbmVzIGhv
dyBtYW55IGluc3RydWN0aW9uIGJ5dGVzIHRvIE5PUCAodXAgdG8KPiArICAgb3BhcXVlIHNpemUg
bW9kdWxvIHNtYWxsZXN0IHBsYXRmb3JtIGluc3RydWN0aW9uIC0gMSBieXRlIHg4NiBhbmQgNCBi
eXRlcyBvbiBBUk0pLgoKVGhpcyBsaW5lIGlzIHByb2JhYmx5IGFsc28gc3RhbGUgbm93OiAiLi4u
Y29udGFpbiB0aGUgc2l6ZXMgb2YgdGhlIApyZXNwZWN0aXZlIGZ1bmN0aW9ucyBpbiBieXRlcy4u
LiIKCj4KPiAgKiBgdmVyc2lvbmAgaXMgdG8gYmUgb25lLgo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9h
cmNoL3g4Ni9hbHRlcm5hdGl2ZS5jIGIveGVuL2FyY2gveDg2L2FsdGVybmF0aXZlLmMKPiBpbmRl
eCAwNWUzZWI4Li42ZWFhMTBmIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9hbHRlcm5hdGl2
ZS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2FsdGVybmF0aXZlLmMKPiBAQCAtMTAxLDcgKzEwMSw3
IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBhcmNoX2luaXRfaWRlYWxfbm9wcyh2b2lkKQo+ICB9Cj4K
PiAgLyogVXNlIHRoaXMgdG8gYWRkIG5vcHMgdG8gYSBidWZmZXIsIHRoZW4gdGV4dF9wb2tlIHRo
ZSB3aG9sZSBidWZmZXIuICovCj4gLXN0YXRpYyB2b2lkIGluaXRfb3JfbGl2ZXBhdGNoIGFkZF9u
b3BzKHZvaWQgKmluc25zLCB1bnNpZ25lZCBpbnQgbGVuKQo+ICt2b2lkIGluaXRfb3JfbGl2ZXBh
dGNoIGFkZF9ub3BzKHZvaWQgKmluc25zLCB1bnNpZ25lZCBpbnQgbGVuKQo+ICB7Cj4gICAgICB3
aGlsZSAoIGxlbiA+IDAgKQo+ICAgICAgewpzbmlwCj4gIHZvaWQgYXJjaF9saXZlcGF0Y2hfYXBw
bHlfam1wKHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKPiAgewo+IC0gICAgaW50MzJfdCB2
YWw7Cj4gICAgICB1aW50OF90ICpvbGRfcHRyOwo+IC0KPiAtICAgIEJVSUxEX0JVR19PTihQQVRD
SF9JTlNOX1NJWkUgPiBzaXplb2YoZnVuYy0+b3BhcXVlKSk7Cj4gLSAgICBCVUlMRF9CVUdfT04o
UEFUQ0hfSU5TTl9TSVpFICE9ICgxICsgc2l6ZW9mKHZhbCkpKTsKPiArICAgIHVpbnQ4X3QgaW5z
bltzaXplb2YoZnVuYy0+b3BhcXVlKV07Cj4gKyAgICB1bnNpZ25lZCBpbnQgbGVuOwo+Cj4gICAg
ICBvbGRfcHRyID0gZnVuYy0+b2xkX2FkZHI7Cj4gLSAgICBtZW1jcHkoZnVuYy0+b3BhcXVlLCBv
bGRfcHRyLCBQQVRDSF9JTlNOX1NJWkUpOwo+ICsgICAgbGVuID0gbGl2ZXBhdGNoX2luc25fbGVu
KGZ1bmMpOwo+ICsgICAgaWYgKCAhbGVuICkKPiArICAgICAgICByZXR1cm47Cj4gKwo+ICsgICAg
bWVtY3B5KGZ1bmMtPm9wYXF1ZSwgb2xkX3B0ciwgbGVuKTsKPiArICAgIGlmICggZnVuYy0+bmV3
X2FkZHIgKQo+ICsgICAgewo+ICsgICAgICAgIGludDMyX3QgdmFsOwo+ICsKPiArICAgICAgICBC
VUlMRF9CVUdfT04oQVJDSF9QQVRDSF9JTlNOX1NJWkUgIT0gKDEgKyBzaXplb2YodmFsKSkpOwo+
ICsKPiArICAgICAgICBpbnNuWzBdID0gMHhlOTsKPiArICAgICAgICB2YWwgPSBmdW5jLT5uZXdf
YWRkciAtIGZ1bmMtPm9sZF9hZGRyIC0gQVJDSF9QQVRDSF9JTlNOX1NJWkU7Cj4gKwo+ICsgICAg
ICAgIG1lbWNweSgmaW5zblsxXSwgJnZhbCwgc2l6ZW9mKHZhbCkpOwo+ICsgICAgfQo+ICsgICAg
ZWxzZQo+ICsgICAgICAgIGFkZF9ub3BzKCZpbnNuLCBsZW4pOwoKSXQgcHJvYmFibHkgZG9lc24n
dCBtYWtlIGEgZGlmZmVyZW5jZSwgYnV0IEknZCBwcmVmZXIgdGhpcyB0byBiZSAKImFkZF9ub3Bz
KGluc24sIGxlbik7Ii4KCj4KPiAtICAgICpvbGRfcHRyKysgPSAweGU5OyAvKiBSZWxhdGl2ZSBq
dW1wICovCj4gLSAgICB2YWwgPSBmdW5jLT5uZXdfYWRkciAtIGZ1bmMtPm9sZF9hZGRyIC0gUEFU
Q0hfSU5TTl9TSVpFOwo+IC0gICAgbWVtY3B5KG9sZF9wdHIsICZ2YWwsIHNpemVvZih2YWwpKTsK
PiArICAgIG1lbWNweShvbGRfcHRyLCBpbnNuLCBsZW4pOwo+ICB9Cj4KPiAgdm9pZCBhcmNoX2xp
dmVwYXRjaF9yZXZlcnRfam1wKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKPiAg
ewo+IC0gICAgbWVtY3B5KGZ1bmMtPm9sZF9hZGRyLCBmdW5jLT5vcGFxdWUsIFBBVENIX0lOU05f
U0laRSk7Cj4gKyAgICBtZW1jcHkoZnVuYy0+b2xkX2FkZHIsIGZ1bmMtPm9wYXF1ZSwgbGl2ZXBh
dGNoX2luc25fbGVuKGZ1bmMpKTsKPiAgfQo+CgotLSAKUm9zcyBMYWdlcndhbGwKCl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n
IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1k
ZXZlbAo=