All of lore.kernel.org
 help / color / mirror / Atom feed
From: gang.yan@linux.dev
To: "Matthieu Baerts" <matttbe@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Cc: "MPTCP Linux" <mptcp@lists.linux.dev>
Subject: Re: CI failures on nipa
Date: Thu, 13 Aug 2026 09:37:24 +0000	[thread overview]
Message-ID: <754c2939260e07b2c73c14e951dd2afc4da62a58@linux.dev> (raw)
In-Reply-To: <be3d9d4d-2a4c-4ed6-a341-f184d85cc664@kernel.org>

August 13, 2026 at 5:20 PM, "Matthieu Baerts" <matttbe@kernel.org mailto:matttbe@kernel.org?to=%22Matthieu%20Baerts%22%20%3Cmatttbe%40kernel.org%3E > wrote:


> 
> Hi Gang,
> 
> On 13/08/2026 10:59, gang.yan@linux.dev wrote:
> 
> > 
> > August 13, 2026 at 3:57 PM, "Paolo Abeni" <pabeni@redhat.com mailto:pabeni@redhat.com?to=%22Paolo%20Abeni%22%20%3Cpabeni%40redhat.com%3E > wrote:
> > 
> (...)
> 
> > 
> > > 
> > > Judging on the final status, I *think*/*guess* the (re)connect is
> > >  hanged, possibly due to bad remote address?!? It could be useful to
> > >  print out on stderr the reconnect destination address.
> > > 
> >  
> >  Hi Paolo,
> >  
> >  That reminds me of an issue when I was reading mptcp_connect.c a long
> >  time ago:
> >  
> >  At the end of 'sock_connect_mptcp()', it calls 'freeaddrinfo(addr)',
> >  the 'peer' pointer (which points into 'addr') remains. Later, the main loop
> >  uses this peer pointer for reconnection attempts. If the memory has been freed
> >  and reused, the address data could be overwritten, resulting in an invalid
> >  remote address.
> >  
> >  That might cause the hangs or failures you are seeing, right?
> > 
> Good catch!
> 
> Are you working on a fix for that? I guess we should copy the content,
> not just the pointer. Or maybe we don't need to do this copy:
> getaddrinfo() should return the same thing, no?

Hi Matt

I can working on this right now – and with the help of AI, I believe we can resolve
it quickly. :)

Thanks
Gang

> 
> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.
>

  reply	other threads:[~2026-08-13  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  7:57 CI failures on nipa Paolo Abeni
2026-08-13  8:59 ` gang.yan
2026-08-13  9:20   ` Matthieu Baerts
2026-08-13  9:37     ` gang.yan [this message]
2026-08-13  9:15 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=754c2939260e07b2c73c14e951dd2afc4da62a58@linux.dev \
    --to=gang.yan@linux.dev \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.