Re: [PATCH v2] ALSA: hda: intel-dsp-cfg: Use AVS driver on SKL/KBL/APL Chromebooks

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2023-10-30 7:58 PM, Brady Norander wrote:
> The legacy SKL driver no longer works properly on these Chromebook
> platforms. Use the new AVS driver by default instead.

Hello,

Thank you for the patch. The code looks fine but it will cause backward 
compatibility problems on driver <-> topology line which I'd like to avoid.

There's an ongoing discussion regarding 24/32 format support for HDAudio 
drivers which is currently incorrect for all Intel AudioDSP drivers. 
Until the discussion is finished I'd like to avoid switching. While the 
avs-driver deprecates the skylake-driver since v5.4, the topology file 
package is not yet part of any official distro release.

I've high hopes to finish the process by the end of November. That 
means: driver code gets updated to properly represent 24/32 format AND 
the avs-topology-xml repo [1] receives equivalent update making it a 
candidate for distro integration. I'll bump this patch once the process 
concludes.

[1]: https://github.com/thesofproject/avs-topology-xml

Czarek