From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [Outreachy kernel] [PATCH v2] firewire: Replace timeval with timespec64
Date: Thu, 22 Oct 2015 00:58:52 +0200 [thread overview]
Message-ID: <7551827.VsyUKdOpMQ@wuerfel> (raw)
In-Reply-To: <20151021223500.GA26701@amitoj-Inspiron-3542>
On Thursday 22 October 2015 04:05:00 Amitoj Kaur Chawla wrote:
> 32 bit systems using 'struct timeval' will break in the year 2038, so
> we replace the code appropriately. However, this driver is not broken
> in 2038 since we are using only the microseconds portion of the
> current time.
>
> This patch replaces timeval with timespec64.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
(adding the y2038 mailing list as well)
> Changes in v2:
> -Replaced timespec with timspec64
> -Modified commit message
> -Used ktime_get_real_ts64() instead of getnstimeofday64()
>
> drivers/firewire/nosy.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
> index 76b2d39..8a46077 100644
> --- a/drivers/firewire/nosy.c
> +++ b/drivers/firewire/nosy.c
> @@ -33,6 +33,7 @@
> #include <linux/sched.h> /* required for linux/wait.h */
> #include <linux/slab.h>
> #include <linux/spinlock.h>
> +#include <linux/time64.h>
> #include <linux/timex.h>
> #include <linux/uaccess.h>
> #include <linux/wait.h>
> @@ -413,17 +414,18 @@ static void
> packet_irq_handler(struct pcilynx *lynx)
> {
> struct client *client;
> - u32 tcode_mask, tcode;
> + u32 tcode_mask, tcode, timestamp;
> size_t length;
> - struct timeval tv;
> + struct timespec64 ts64;
>
> /* FIXME: Also report rcv_speed. */
>
> length = __le32_to_cpu(lynx->rcv_pcl->pcl_status) & 0x00001fff;
> tcode = __le32_to_cpu(lynx->rcv_buffer[1]) >> 4 & 0xf;
>
> - do_gettimeofday(&tv);
> - lynx->rcv_buffer[0] = (__force __le32)tv.tv_usec;
> + ktime_get_real_ts64(&ts64);
> + timestamp = ts64.tv_nsec / NSEC_PER_USEC;
> + lynx->rcv_buffer[0] = (__force __le32)timestamp;
>
> if (length == PHY_PACKET_SIZE)
> tcode_mask = 1 << TCODE_PHY_PACKET;
>
next prev parent reply other threads:[~2015-10-21 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 22:35 [PATCH v2] firewire: Replace timeval with timespec64 Amitoj Kaur Chawla
2015-10-21 22:58 ` Arnd Bergmann [this message]
2015-10-22 13:07 ` Stefan Richter
2015-10-22 13:17 ` Arnd Bergmann
2015-11-05 13:34 ` [Outreachy kernel] " Stefan Richter
2015-11-05 14:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7551827.VsyUKdOpMQ@wuerfel \
--to=arnd@arndb.de \
--cc=amitoj1606@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.